Re: [PATCH] drivers: thermal: qcom: tsens: Fix memory leak from qfprom read

2019-08-28 Thread Zhang Rui
On Fri, 2019-08-23 at 17:29 +0530, Amit Kucheria wrote: > On Fri, Aug 23, 2019 at 3:08 PM Srinivas Kandagatla > wrote: > > > > memory returned as part of nvmem_read via qfprom_read should be > > freed by the consumer once done. > > Existing code is not doing it so fix it. > > > > Below memory

Re: [PATCH] drivers: thermal: qcom: tsens: Fix memory leak from qfprom read

2019-08-23 Thread Amit Kucheria
On Fri, Aug 23, 2019 at 3:08 PM Srinivas Kandagatla wrote: > > memory returned as part of nvmem_read via qfprom_read should be > freed by the consumer once done. > Existing code is not doing it so fix it. > > Below memory leak detected by kmemleak >[] kmemleak_alloc+0x50/0x84 > []

[PATCH] drivers: thermal: qcom: tsens: Fix memory leak from qfprom read

2019-08-23 Thread Srinivas Kandagatla
memory returned as part of nvmem_read via qfprom_read should be freed by the consumer once done. Existing code is not doing it so fix it. Below memory leak detected by kmemleak [] kmemleak_alloc+0x50/0x84 [] __kmalloc+0xe8/0x168 [] nvmem_cell_read+0x30/0x80 [] qfprom_read+0x4c/0x7c