Re: [PATCH] drm/atomic: Handling the case when setting old crtc for plane

2018-05-03 Thread Daniel Vetter
On Thu, May 03, 2018 at 01:55:03PM +0300, Ville Syrjälä wrote: > On Thu, May 03, 2018 at 11:24:59AM +0200, Daniel Vetter wrote: > > On Thu, May 03, 2018 at 11:19:32AM +0530, Satendra Singh Thakur wrote: > > > In the func drm_atomic_set_crtc_for_plane, with the current code, > > > if crtc of the

Re: [PATCH] drm/atomic: Handling the case when setting old crtc for plane

2018-05-03 Thread Daniel Vetter
On Thu, May 03, 2018 at 01:55:03PM +0300, Ville Syrjälä wrote: > On Thu, May 03, 2018 at 11:24:59AM +0200, Daniel Vetter wrote: > > On Thu, May 03, 2018 at 11:19:32AM +0530, Satendra Singh Thakur wrote: > > > In the func drm_atomic_set_crtc_for_plane, with the current code, > > > if crtc of the

Re: [PATCH] drm/atomic: Handling the case when setting old crtc for plane

2018-05-03 Thread Ville Syrjälä
On Thu, May 03, 2018 at 11:24:59AM +0200, Daniel Vetter wrote: > On Thu, May 03, 2018 at 11:19:32AM +0530, Satendra Singh Thakur wrote: > > In the func drm_atomic_set_crtc_for_plane, with the current code, > > if crtc of the plane_state and crtc passed as argument to the func > > are same, entire

Re: [PATCH] drm/atomic: Handling the case when setting old crtc for plane

2018-05-03 Thread Ville Syrjälä
On Thu, May 03, 2018 at 11:24:59AM +0200, Daniel Vetter wrote: > On Thu, May 03, 2018 at 11:19:32AM +0530, Satendra Singh Thakur wrote: > > In the func drm_atomic_set_crtc_for_plane, with the current code, > > if crtc of the plane_state and crtc passed as argument to the func > > are same, entire

Re: [PATCH] drm/atomic: Handling the case when setting old crtc for plane

2018-05-03 Thread Daniel Vetter
On Thu, May 03, 2018 at 11:19:32AM +0530, Satendra Singh Thakur wrote: > In the func drm_atomic_set_crtc_for_plane, with the current code, > if crtc of the plane_state and crtc passed as argument to the func > are same, entire func will executed in vein. > It will get state of crtc and clear and

Re: [PATCH] drm/atomic: Handling the case when setting old crtc for plane

2018-05-03 Thread Daniel Vetter
On Thu, May 03, 2018 at 11:19:32AM +0530, Satendra Singh Thakur wrote: > In the func drm_atomic_set_crtc_for_plane, with the current code, > if crtc of the plane_state and crtc passed as argument to the func > are same, entire func will executed in vein. > It will get state of crtc and clear and

[PATCH] drm/atomic: Handling the case when setting old crtc for plane

2018-05-02 Thread Satendra Singh Thakur
In the func drm_atomic_set_crtc_for_plane, with the current code, if crtc of the plane_state and crtc passed as argument to the func are same, entire func will executed in vein. It will get state of crtc and clear and set the bits in plane_mask. All these steps are not required for same old crtc.

[PATCH] drm/atomic: Handling the case when setting old crtc for plane

2018-05-02 Thread Satendra Singh Thakur
In the func drm_atomic_set_crtc_for_plane, with the current code, if crtc of the plane_state and crtc passed as argument to the func are same, entire func will executed in vein. It will get state of crtc and clear and set the bits in plane_mask. All these steps are not required for same old crtc.