Re: [PATCH] drm/bridge: tpd12s015: Fix irq registering in tpd12s015_probe

2020-11-02 Thread Tomi Valkeinen
On 02/11/2020 11:36, Yuehaibing wrote: > On 2020/11/2 14:57, Tomi Valkeinen wrote: >> On 31/10/2020 09:19, Sam Ravnborg wrote: >>> Hi YueHaibing >>> >>> Thanks for the fix. Appreciated but please update as per comments below. >>> >>> On Sat, Oct 31, 2020 at 11:16:48AM +0800, YueHaibing wrote:

Re: [PATCH] drm/bridge: tpd12s015: Fix irq registering in tpd12s015_probe

2020-11-02 Thread Yuehaibing
On 2020/11/2 14:57, Tomi Valkeinen wrote: > On 31/10/2020 09:19, Sam Ravnborg wrote: >> Hi YueHaibing >> >> Thanks for the fix. Appreciated but please update as per comments below. >> >> On Sat, Oct 31, 2020 at 11:16:48AM +0800, YueHaibing wrote: >>> gpiod_to_irq() return negative value in case of

Re: [PATCH] drm/bridge: tpd12s015: Fix irq registering in tpd12s015_probe

2020-11-01 Thread Tomi Valkeinen
On 31/10/2020 09:19, Sam Ravnborg wrote: > Hi YueHaibing > > Thanks for the fix. Appreciated but please update as per comments below. > > On Sat, Oct 31, 2020 at 11:16:48AM +0800, YueHaibing wrote: >> gpiod_to_irq() return negative value in case of error, >> the existing code handle negative erro

Re: [PATCH] drm/bridge: tpd12s015: Fix irq registering in tpd12s015_probe

2020-10-31 Thread Yuehaibing
On 2020/10/31 15:19, Sam Ravnborg wrote: > Hi YueHaibing > > Thanks for the fix. Appreciated but please update as per comments below. > > On Sat, Oct 31, 2020 at 11:16:48AM +0800, YueHaibing wrote: >> gpiod_to_irq() return negative value in case of error, >> the existing code handle negative erro

Re: [PATCH] drm/bridge: tpd12s015: Fix irq registering in tpd12s015_probe

2020-10-31 Thread Sam Ravnborg
Hi YueHaibing Thanks for the fix. Appreciated but please update as per comments below. On Sat, Oct 31, 2020 at 11:16:48AM +0800, YueHaibing wrote: > gpiod_to_irq() return negative value in case of error, > the existing code handle negative error codes wrongly. > > Fixes: cff5e6f7e83f ("drm/bridg

[PATCH] drm/bridge: tpd12s015: Fix irq registering in tpd12s015_probe

2020-10-30 Thread YueHaibing
gpiod_to_irq() return negative value in case of error, the existing code handle negative error codes wrongly. Fixes: cff5e6f7e83f ("drm/bridge: Add driver for the TI TPD12S015 HDMI level shifter") Signed-off-by: YueHaibing --- drivers/gpu/drm/bridge/ti-tpd12s015.c | 2 +- 1 file changed, 1 inse