Re: [PATCH] drm/fb_helper: Disable all crtc's when initial setup fails.

2017-11-29 Thread Maarten Lankhorst
Op 28-11-17 om 16:13 schreef Thomas Voegtle: > On Tue, 28 Nov 2017, Daniel Vetter wrote: > >> On Tue, Nov 28, 2017 at 12:16:03PM +0100, Maarten Lankhorst wrote: >>> Some drivers like i915 start with crtc's enabled, but with deferred >>> fbcon setup they were no longer disabled as part of fbdev

Re: [PATCH] drm/fb_helper: Disable all crtc's when initial setup fails.

2017-11-29 Thread Maarten Lankhorst
Op 28-11-17 om 16:13 schreef Thomas Voegtle: > On Tue, 28 Nov 2017, Daniel Vetter wrote: > >> On Tue, Nov 28, 2017 at 12:16:03PM +0100, Maarten Lankhorst wrote: >>> Some drivers like i915 start with crtc's enabled, but with deferred >>> fbcon setup they were no longer disabled as part of fbdev

Re: [PATCH] drm/fb_helper: Disable all crtc's when initial setup fails.

2017-11-28 Thread Thomas Voegtle
On Tue, 28 Nov 2017, Daniel Vetter wrote: On Tue, Nov 28, 2017 at 12:16:03PM +0100, Maarten Lankhorst wrote: Some drivers like i915 start with crtc's enabled, but with deferred fbcon setup they were no longer disabled as part of fbdev setup. Headless units could no longer enter pc3 state

Re: [PATCH] drm/fb_helper: Disable all crtc's when initial setup fails.

2017-11-28 Thread Thomas Voegtle
On Tue, 28 Nov 2017, Daniel Vetter wrote: On Tue, Nov 28, 2017 at 12:16:03PM +0100, Maarten Lankhorst wrote: Some drivers like i915 start with crtc's enabled, but with deferred fbcon setup they were no longer disabled as part of fbdev setup. Headless units could no longer enter pc3 state

Re: [PATCH] drm/fb_helper: Disable all crtc's when initial setup fails.

2017-11-28 Thread Daniel Vetter
On Tue, Nov 28, 2017 at 12:16:03PM +0100, Maarten Lankhorst wrote: > Some drivers like i915 start with crtc's enabled, but with deferred > fbcon setup they were no longer disabled as part of fbdev setup. > Headless units could no longer enter pc3 state because the crtc was > still enabled. > >

Re: [PATCH] drm/fb_helper: Disable all crtc's when initial setup fails.

2017-11-28 Thread Daniel Vetter
On Tue, Nov 28, 2017 at 12:16:03PM +0100, Maarten Lankhorst wrote: > Some drivers like i915 start with crtc's enabled, but with deferred > fbcon setup they were no longer disabled as part of fbdev setup. > Headless units could no longer enter pc3 state because the crtc was > still enabled. > >

[PATCH] drm/fb_helper: Disable all crtc's when initial setup fails.

2017-11-28 Thread Maarten Lankhorst
Some drivers like i915 start with crtc's enabled, but with deferred fbcon setup they were no longer disabled as part of fbdev setup. Headless units could no longer enter pc3 state because the crtc was still enabled. Fix this by calling restore_fbdev_mode when we would have called it otherwise

[PATCH] drm/fb_helper: Disable all crtc's when initial setup fails.

2017-11-28 Thread Maarten Lankhorst
Some drivers like i915 start with crtc's enabled, but with deferred fbcon setup they were no longer disabled as part of fbdev setup. Headless units could no longer enter pc3 state because the crtc was still enabled. Fix this by calling restore_fbdev_mode when we would have called it otherwise