Re: [PATCH] drm/i915: Take modeset locks around intel_modeset_setup_hw_state()

2013-12-02 Thread Paul Bolle
On Mon, 2013-12-02 at 14:12 +0200, Ville Syrjälä wrote: > On Mon, Dec 02, 2013 at 11:00:29AM +0100, Paul Bolle wrote: > > I assume I need to test this, on top of 7c063c725987 ("drm/i915: take > > mode config lock around crtc disable at suspend"), to see if this makes > > the WARNING that I

Re: [PATCH] drm/i915: Take modeset locks around intel_modeset_setup_hw_state()

2013-12-02 Thread Ville Syrjälä
On Mon, Dec 02, 2013 at 11:00:29AM +0100, Paul Bolle wrote: > On Mon, 2013-12-02 at 11:08 +0200, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > Some lower level things get angry if we don't have modeset locks > > during intel_modeset_setup_hw_state(). Actually the resume

Re: [PATCH] drm/i915: Take modeset locks around intel_modeset_setup_hw_state()

2013-12-02 Thread Paul Bolle
On Mon, 2013-12-02 at 11:08 +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Some lower level things get angry if we don't have modeset locks > during intel_modeset_setup_hw_state(). Actually the resume and > lid_notify codepaths alreday hold the locks, but the init codepath

[PATCH] drm/i915: Take modeset locks around intel_modeset_setup_hw_state()

2013-12-02 Thread ville . syrjala
From: Ville Syrjälä Some lower level things get angry if we don't have modeset locks during intel_modeset_setup_hw_state(). Actually the resume and lid_notify codepaths alreday hold the locks, but the init codepath doesn't, so fix that. Signed-off-by: Ville Syrjälä --- Totally untested, but

[PATCH] drm/i915: Take modeset locks around intel_modeset_setup_hw_state()

2013-12-02 Thread ville . syrjala
From: Ville Syrjälä ville.syrj...@linux.intel.com Some lower level things get angry if we don't have modeset locks during intel_modeset_setup_hw_state(). Actually the resume and lid_notify codepaths alreday hold the locks, but the init codepath doesn't, so fix that. Signed-off-by: Ville Syrjälä

Re: [PATCH] drm/i915: Take modeset locks around intel_modeset_setup_hw_state()

2013-12-02 Thread Paul Bolle
On Mon, 2013-12-02 at 11:08 +0200, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com Some lower level things get angry if we don't have modeset locks during intel_modeset_setup_hw_state(). Actually the resume and lid_notify codepaths alreday hold the

Re: [PATCH] drm/i915: Take modeset locks around intel_modeset_setup_hw_state()

2013-12-02 Thread Ville Syrjälä
On Mon, Dec 02, 2013 at 11:00:29AM +0100, Paul Bolle wrote: On Mon, 2013-12-02 at 11:08 +0200, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com Some lower level things get angry if we don't have modeset locks during intel_modeset_setup_hw_state().

Re: [PATCH] drm/i915: Take modeset locks around intel_modeset_setup_hw_state()

2013-12-02 Thread Paul Bolle
On Mon, 2013-12-02 at 14:12 +0200, Ville Syrjälä wrote: On Mon, Dec 02, 2013 at 11:00:29AM +0100, Paul Bolle wrote: I assume I need to test this, on top of 7c063c725987 (drm/i915: take mode config lock around crtc disable at suspend), to see if this makes the WARNING that I currently see