Re: [Intel-gfx] [PATCH] drm/i915: annote drop_caches debugfs interface with lockdep

2017-03-14 Thread Daniel Vetter
On Mon, Mar 13, 2017 at 09:30:41AM +0100, Peter Zijlstra wrote: > On Mon, Mar 13, 2017 at 09:15:17AM +0100, Daniel Vetter wrote: > > On Mon, Mar 13, 2017 at 09:01:57AM +0100, Peter Zijlstra wrote: > > > On Sun, Mar 12, 2017 at 09:53:40PM +0100, Daniel Vetter wrote: > > > > > > > Peter/Ingo, > > >

Re: [PATCH] drm/i915: annote drop_caches debugfs interface with lockdep

2017-03-13 Thread Peter Zijlstra
On Mon, Mar 13, 2017 at 09:15:17AM +0100, Daniel Vetter wrote: > On Mon, Mar 13, 2017 at 09:01:57AM +0100, Peter Zijlstra wrote: > > On Sun, Mar 12, 2017 at 09:53:40PM +0100, Daniel Vetter wrote: > > > > > Peter/Ingo, > > > > > > We want this to validate the i915 shrinker locking in our fast test

Re: [PATCH] drm/i915: annote drop_caches debugfs interface with lockdep

2017-03-13 Thread Daniel Vetter
On Mon, Mar 13, 2017 at 09:01:57AM +0100, Peter Zijlstra wrote: > On Sun, Mar 12, 2017 at 09:53:40PM +0100, Daniel Vetter wrote: > > > Peter/Ingo, > > > > We want this to validate the i915 shrinker locking in our fast tests > > without thrashing badly (that takes too long, we can only thrash in >

Re: [PATCH] drm/i915: annote drop_caches debugfs interface with lockdep

2017-03-13 Thread Peter Zijlstra
On Sun, Mar 12, 2017 at 09:53:40PM +0100, Daniel Vetter wrote: > Peter/Ingo, > > We want this to validate the i915 shrinker locking in our fast tests > without thrashing badly (that takes too long, we can only thrash in > the extended runs). Can you pls take a look and if it's ok ack for > mergin

[PATCH] drm/i915: annote drop_caches debugfs interface with lockdep

2017-03-12 Thread Daniel Vetter
The trouble we have is that we can't really test all the shrinker recursion stuff exhaustively in BAT because any kind of thrashing stress test just takes too long. But that leaves a really big gap open, since shrinker recursions are one of the most annoying bugs. Now lockdep already has support f

Re: [PATCH] drm/i915: annote drop_caches debugfs interface with lockdep

2017-03-12 Thread Chris Wilson
On Sun, Mar 12, 2017 at 08:27:16PM +0100, Daniel Vetter wrote: > The trouble we have is that we can't really test all the shrinker > recursion stuff exhaustively in BAT because any kind of thrashing > stress test just takes too long. > > But that leaves a really big gap open, since shrinker recurs

[PATCH] drm/i915: annote drop_caches debugfs interface with lockdep

2017-03-12 Thread Daniel Vetter
The trouble we have is that we can't really test all the shrinker recursion stuff exhaustively in BAT because any kind of thrashing stress test just takes too long. But that leaves a really big gap open, since shrinker recursions are one of the most annoying bugs. Now lockdep already has support f