Re: [Intel-gfx] [PATCH] drm/i915: fix long-standing SNB regression in power consumption after resume

2013-07-16 Thread Jesse Barnes
On Tue, 16 Jul 2013 22:43:49 +0200 Daniel Vetter wrote: > On Tue, Jul 16, 2013 at 01:19:25PM -0700, Jesse Barnes wrote: > > On Tue, 16 Jul 2013 10:06:54 -0700 > > Jesse Barnes wrote: > > > > > On Tue, 16 Jul 2013 11:34:25 +0400 > > > Konstantin Khlebnikov wrote: > > > > I've tested that patch

Re: [Intel-gfx] [PATCH] drm/i915: fix long-standing SNB regression in power consumption after resume

2013-07-16 Thread Daniel Vetter
On Tue, Jul 16, 2013 at 01:19:25PM -0700, Jesse Barnes wrote: > On Tue, 16 Jul 2013 10:06:54 -0700 > Jesse Barnes wrote: > > > On Tue, 16 Jul 2013 11:34:25 +0400 > > Konstantin Khlebnikov wrote: > > > I've tested that patch and it really works for me. If you want change > > > something for

Re: [Intel-gfx] [PATCH] drm/i915: fix long-standing SNB regression in power consumption after resume

2013-07-16 Thread Jesse Barnes
On Tue, 16 Jul 2013 10:06:54 -0700 Jesse Barnes wrote: > On Tue, 16 Jul 2013 11:34:25 +0400 > Konstantin Khlebnikov wrote: > > I've tested that patch and it really works for me. If you want change > > something for other hardware or > > extend range where forcewake is held prease do it in a

Re: [Intel-gfx] [PATCH] drm/i915: fix long-standing SNB regression in power consumption after resume

2013-07-16 Thread Jesse Barnes
On Tue, 16 Jul 2013 11:34:25 +0400 Konstantin Khlebnikov wrote: > I've tested that patch and it really works for me. If you want change > something for other hardware or > extend range where forcewake is held prease do it in a separate patch. > This will be good for bisecting new bugs in the

Re: [PATCH] drm/i915: fix long-standing SNB regression in power consumption after resume

2013-07-16 Thread Daniel Vetter
On Tue, Jul 16, 2013 at 08:32:40AM +0200, Daniel Vetter wrote: > On Sun, Jul 14, 2013 at 08:30:09PM +0400, Konstantin Khlebnikov wrote: > > This patch fixes regression in power consumtion of sandy bridge gpu, which > > exists since v3.6 Sometimes after resuming from s2ram gpu starts thinking > >

Re: [PATCH] drm/i915: fix long-standing SNB regression in power consumption after resume

2013-07-16 Thread Daniel Vetter
On Tue, Jul 16, 2013 at 10:31 AM, Chris Wilson wrote: > On Tue, Jul 16, 2013 at 09:44:59AM +0200, Daniel Vetter wrote: >> The issue I have with the current patch is that it looks a bit like >> duct-tape since the point where we drop the forcewake references seems to >> lack justification. The

Re: [PATCH] drm/i915: fix long-standing SNB regression in power consumption after resume

2013-07-16 Thread Chris Wilson
On Tue, Jul 16, 2013 at 09:44:59AM +0200, Daniel Vetter wrote: > The issue I have with the current patch is that it looks a bit like > duct-tape since the point where we drop the forcewake references seems to > lack justification. The write to MBCTL itself will temporarily wake up the > chip, so

Re: [PATCH] drm/i915: fix long-standing SNB regression in power consumption after resume

2013-07-16 Thread Daniel Vetter
On Tue, Jul 16, 2013 at 11:34:25AM +0400, Konstantin Khlebnikov wrote: > On Tue, Jul 16, 2013 at 10:31 AM, Daniel Vetter wrote: > > > On Sun, Jul 14, 2013 at 09:56:45PM +0400, Konstantin Khlebnikov wrote: > > > Daniel Vetter wrote: > > > >On Sun, Jul 14, 2013 at 6:30 PM, Konstantin Khlebnikov >

Re: [PATCH] drm/i915: fix long-standing SNB regression in power consumption after resume

2013-07-16 Thread Daniel Vetter
On Sun, Jul 14, 2013 at 08:30:09PM +0400, Konstantin Khlebnikov wrote: > This patch fixes regression in power consumtion of sandy bridge gpu, which > exists since v3.6 Sometimes after resuming from s2ram gpu starts thinking that > it's extremely busy. After that it never reaches rc6 state. > >

Re: [PATCH] drm/i915: fix long-standing SNB regression in power consumption after resume

2013-07-16 Thread Daniel Vetter
On Sun, Jul 14, 2013 at 09:56:45PM +0400, Konstantin Khlebnikov wrote: > Daniel Vetter wrote: > >On Sun, Jul 14, 2013 at 6:30 PM, Konstantin Khlebnikov > > wrote: > >>This patch fixes regression in power consumtion of sandy bridge gpu, which > >>exists since v3.6 Sometimes after resuming from

Re: [PATCH] drm/i915: fix long-standing SNB regression in power consumption after resume

2013-07-16 Thread Daniel Vetter
On Sun, Jul 14, 2013 at 09:56:45PM +0400, Konstantin Khlebnikov wrote: Daniel Vetter wrote: On Sun, Jul 14, 2013 at 6:30 PM, Konstantin Khlebnikov khlebni...@openvz.org wrote: This patch fixes regression in power consumtion of sandy bridge gpu, which exists since v3.6 Sometimes after

Re: [PATCH] drm/i915: fix long-standing SNB regression in power consumption after resume

2013-07-16 Thread Daniel Vetter
On Sun, Jul 14, 2013 at 08:30:09PM +0400, Konstantin Khlebnikov wrote: This patch fixes regression in power consumtion of sandy bridge gpu, which exists since v3.6 Sometimes after resuming from s2ram gpu starts thinking that it's extremely busy. After that it never reaches rc6 state. Bug was

Re: [PATCH] drm/i915: fix long-standing SNB regression in power consumption after resume

2013-07-16 Thread Daniel Vetter
On Tue, Jul 16, 2013 at 11:34:25AM +0400, Konstantin Khlebnikov wrote: On Tue, Jul 16, 2013 at 10:31 AM, Daniel Vetter dan...@ffwll.ch wrote: On Sun, Jul 14, 2013 at 09:56:45PM +0400, Konstantin Khlebnikov wrote: Daniel Vetter wrote: On Sun, Jul 14, 2013 at 6:30 PM, Konstantin

Re: [PATCH] drm/i915: fix long-standing SNB regression in power consumption after resume

2013-07-16 Thread Chris Wilson
On Tue, Jul 16, 2013 at 09:44:59AM +0200, Daniel Vetter wrote: The issue I have with the current patch is that it looks a bit like duct-tape since the point where we drop the forcewake references seems to lack justification. The write to MBCTL itself will temporarily wake up the chip, so just

Re: [PATCH] drm/i915: fix long-standing SNB regression in power consumption after resume

2013-07-16 Thread Daniel Vetter
On Tue, Jul 16, 2013 at 10:31 AM, Chris Wilson ch...@chris-wilson.co.uk wrote: On Tue, Jul 16, 2013 at 09:44:59AM +0200, Daniel Vetter wrote: The issue I have with the current patch is that it looks a bit like duct-tape since the point where we drop the forcewake references seems to lack

Re: [PATCH] drm/i915: fix long-standing SNB regression in power consumption after resume

2013-07-16 Thread Daniel Vetter
On Tue, Jul 16, 2013 at 08:32:40AM +0200, Daniel Vetter wrote: On Sun, Jul 14, 2013 at 08:30:09PM +0400, Konstantin Khlebnikov wrote: This patch fixes regression in power consumtion of sandy bridge gpu, which exists since v3.6 Sometimes after resuming from s2ram gpu starts thinking that

Re: [Intel-gfx] [PATCH] drm/i915: fix long-standing SNB regression in power consumption after resume

2013-07-16 Thread Jesse Barnes
On Tue, 16 Jul 2013 11:34:25 +0400 Konstantin Khlebnikov khlebni...@openvz.org wrote: I've tested that patch and it really works for me. If you want change something for other hardware or extend range where forcewake is held prease do it in a separate patch. This will be good for bisecting new

Re: [Intel-gfx] [PATCH] drm/i915: fix long-standing SNB regression in power consumption after resume

2013-07-16 Thread Jesse Barnes
On Tue, 16 Jul 2013 10:06:54 -0700 Jesse Barnes jbar...@virtuousgeek.org wrote: On Tue, 16 Jul 2013 11:34:25 +0400 Konstantin Khlebnikov khlebni...@openvz.org wrote: I've tested that patch and it really works for me. If you want change something for other hardware or extend range where

Re: [Intel-gfx] [PATCH] drm/i915: fix long-standing SNB regression in power consumption after resume

2013-07-16 Thread Daniel Vetter
On Tue, Jul 16, 2013 at 01:19:25PM -0700, Jesse Barnes wrote: On Tue, 16 Jul 2013 10:06:54 -0700 Jesse Barnes jbar...@virtuousgeek.org wrote: On Tue, 16 Jul 2013 11:34:25 +0400 Konstantin Khlebnikov khlebni...@openvz.org wrote: I've tested that patch and it really works for me. If you

Re: [Intel-gfx] [PATCH] drm/i915: fix long-standing SNB regression in power consumption after resume

2013-07-16 Thread Jesse Barnes
On Tue, 16 Jul 2013 22:43:49 +0200 Daniel Vetter dan...@ffwll.ch wrote: On Tue, Jul 16, 2013 at 01:19:25PM -0700, Jesse Barnes wrote: On Tue, 16 Jul 2013 10:06:54 -0700 Jesse Barnes jbar...@virtuousgeek.org wrote: On Tue, 16 Jul 2013 11:34:25 +0400 Konstantin Khlebnikov

Re: [PATCH] drm/i915: fix long-standing SNB regression in power consumption after resume

2013-07-14 Thread Chris Wilson
On Sun, Jul 14, 2013 at 06:52:39PM +0200, Daniel Vetter wrote: > On Sun, Jul 14, 2013 at 6:30 PM, Konstantin Khlebnikov > wrote: > > This patch fixes regression in power consumtion of sandy bridge gpu, which > > exists since v3.6 Sometimes after resuming from s2ram gpu starts thinking > > that >

Re: [PATCH] drm/i915: fix long-standing SNB regression in power consumption after resume

2013-07-14 Thread Konstantin Khlebnikov
Daniel Vetter wrote: On Sun, Jul 14, 2013 at 6:30 PM, Konstantin Khlebnikov wrote: This patch fixes regression in power consumtion of sandy bridge gpu, which exists since v3.6 Sometimes after resuming from s2ram gpu starts thinking that it's extremely busy. After that it never reaches rc6

Re: [PATCH] drm/i915: fix long-standing SNB regression in power consumption after resume

2013-07-14 Thread Daniel Vetter
On Sun, Jul 14, 2013 at 6:30 PM, Konstantin Khlebnikov wrote: > This patch fixes regression in power consumtion of sandy bridge gpu, which > exists since v3.6 Sometimes after resuming from s2ram gpu starts thinking that > it's extremely busy. After that it never reaches rc6 state. > > Bug was

[PATCH] drm/i915: fix long-standing SNB regression in power consumption after resume

2013-07-14 Thread Konstantin Khlebnikov
This patch fixes regression in power consumtion of sandy bridge gpu, which exists since v3.6 Sometimes after resuming from s2ram gpu starts thinking that it's extremely busy. After that it never reaches rc6 state. Bug was introduce by commit b4ae3f22d238617ca11610b29fde16cf8c0bc6e0 ("drm/i915:

[PATCH] drm/i915: fix long-standing SNB regression in power consumption after resume

2013-07-14 Thread Konstantin Khlebnikov
This patch fixes regression in power consumtion of sandy bridge gpu, which exists since v3.6 Sometimes after resuming from s2ram gpu starts thinking that it's extremely busy. After that it never reaches rc6 state. Bug was introduce by commit b4ae3f22d238617ca11610b29fde16cf8c0bc6e0 (drm/i915:

Re: [PATCH] drm/i915: fix long-standing SNB regression in power consumption after resume

2013-07-14 Thread Daniel Vetter
On Sun, Jul 14, 2013 at 6:30 PM, Konstantin Khlebnikov khlebni...@openvz.org wrote: This patch fixes regression in power consumtion of sandy bridge gpu, which exists since v3.6 Sometimes after resuming from s2ram gpu starts thinking that it's extremely busy. After that it never reaches rc6

Re: [PATCH] drm/i915: fix long-standing SNB regression in power consumption after resume

2013-07-14 Thread Konstantin Khlebnikov
Daniel Vetter wrote: On Sun, Jul 14, 2013 at 6:30 PM, Konstantin Khlebnikov khlebni...@openvz.org wrote: This patch fixes regression in power consumtion of sandy bridge gpu, which exists since v3.6 Sometimes after resuming from s2ram gpu starts thinking that it's extremely busy. After that it

Re: [PATCH] drm/i915: fix long-standing SNB regression in power consumption after resume

2013-07-14 Thread Chris Wilson
On Sun, Jul 14, 2013 at 06:52:39PM +0200, Daniel Vetter wrote: On Sun, Jul 14, 2013 at 6:30 PM, Konstantin Khlebnikov khlebni...@openvz.org wrote: This patch fixes regression in power consumtion of sandy bridge gpu, which exists since v3.6 Sometimes after resuming from s2ram gpu starts