Re: [PATCH] drm/i915: remove redundant check on has_aliasing_ppgtt

2017-10-10 Thread Colin Ian King
On 10/10/17 15:35, Joonas Lahtinen wrote: > On Tue, 2017-10-10 at 14:47 +0100, Colin King wrote: >> From: Colin Ian King >> >> There is a previous check to on has_aliasing_ppgtt that returns >> 0 if it is false, so it is impossible for has_aliasing_ppgtt to >> be false

Re: [PATCH] drm/i915: remove redundant check on has_aliasing_ppgtt

2017-10-10 Thread Colin Ian King
On 10/10/17 15:35, Joonas Lahtinen wrote: > On Tue, 2017-10-10 at 14:47 +0100, Colin King wrote: >> From: Colin Ian King >> >> There is a previous check to on has_aliasing_ppgtt that returns >> 0 if it is false, so it is impossible for has_aliasing_ppgtt to >> be false on the final return of

Re: [PATCH] drm/i915: remove redundant check on has_aliasing_ppgtt

2017-10-10 Thread Joonas Lahtinen
On Tue, 2017-10-10 at 14:47 +0100, Colin King wrote: > From: Colin Ian King > > There is a previous check to on has_aliasing_ppgtt that returns > 0 if it is false, so it is impossible for has_aliasing_ppgtt to > be false on the final return of function

Re: [PATCH] drm/i915: remove redundant check on has_aliasing_ppgtt

2017-10-10 Thread Joonas Lahtinen
On Tue, 2017-10-10 at 14:47 +0100, Colin King wrote: > From: Colin Ian King > > There is a previous check to on has_aliasing_ppgtt that returns > 0 if it is false, so it is impossible for has_aliasing_ppgtt to > be false on the final return of function intel_sanitize_enable_ppgtt, > so final

[PATCH] drm/i915: remove redundant check on has_aliasing_ppgtt

2017-10-10 Thread Colin King
From: Colin Ian King There is a previous check to on has_aliasing_ppgtt that returns 0 if it is false, so it is impossible for has_aliasing_ppgtt to be false on the final return of function intel_sanitize_enable_ppgtt, so final return in the function always will return

[PATCH] drm/i915: remove redundant check on has_aliasing_ppgtt

2017-10-10 Thread Colin King
From: Colin Ian King There is a previous check to on has_aliasing_ppgtt that returns 0 if it is false, so it is impossible for has_aliasing_ppgtt to be false on the final return of function intel_sanitize_enable_ppgtt, so final return in the function always will return 1. Hence the redundant