Re: [PATCH] drm/mgag200: fix memory leak

2015-09-24 Thread Sudip Mukherjee
On Mon, Sep 07, 2015 at 05:28:30PM +0530, Sudip Mukherjee wrote: > If drm_fb_helper_alloc_fbi() fails then we were directly returning > without freeing sysram. Also if drm_fb_helper_alloc_fbi() succeeds but > mgag200_framebuffer_init() fails then we were not releasing sysram and > we were not

Re: [PATCH] drm/mgag200: fix memory leak

2015-09-24 Thread Sudip Mukherjee
On Mon, Sep 07, 2015 at 05:28:30PM +0530, Sudip Mukherjee wrote: > If drm_fb_helper_alloc_fbi() fails then we were directly returning > without freeing sysram. Also if drm_fb_helper_alloc_fbi() succeeds but > mgag200_framebuffer_init() fails then we were not releasing sysram and > we were not

Re: [PATCH] drm/mgag200: fix memory leak

2015-09-14 Thread Archit Taneja
Hi, On 9/14/2015 3:35 PM, Dave Airlie wrote: (this time with correct email address). On 14 September 2015 at 20:04, Dave Airlie wrote: If drm_fb_helper_alloc_fbi() fails then we were directly returning without freeing sysram. Also if drm_fb_helper_alloc_fbi() succeeds but

Re: [PATCH] drm/mgag200: fix memory leak

2015-09-14 Thread Sudip Mukherjee
On Mon, Sep 14, 2015 at 08:05:37PM +1000, Dave Airlie wrote: > (this time with correct email address). > > On 14 September 2015 at 20:04, Dave Airlie wrote: > >> > >> > >> There's a new regression: v4.3-rc1 crashes on bootup on non-supported > >> hardware, if > >> CONFIG_DRM_MGAG200=y (built

Re: [PATCH] drm/mgag200: fix memory leak

2015-09-14 Thread Dave Airlie
(this time with correct email address). On 14 September 2015 at 20:04, Dave Airlie wrote: >> >>> If drm_fb_helper_alloc_fbi() fails then we were directly returning >>> without freeing sysram. Also if drm_fb_helper_alloc_fbi() succeeds but >>> mgag200_framebuffer_init() fails then we were not

Re: [PATCH] drm/mgag200: fix memory leak

2015-09-14 Thread Dave Airlie
> >> If drm_fb_helper_alloc_fbi() fails then we were directly returning >> without freeing sysram. Also if drm_fb_helper_alloc_fbi() succeeds but >> mgag200_framebuffer_init() fails then we were not releasing sysram and >> we were not releasing fbi helper also. >> >> Signed-off-by: Sudip Mukherjee

Re: [PATCH] drm/mgag200: fix memory leak

2015-09-14 Thread Sudip Mukherjee
On Sun, Sep 13, 2015 at 11:36:07AM +0200, Ingo Molnar wrote: > > * Sudip Mukherjee wrote: > > > There's a new regression: v4.3-rc1 crashes on bootup on non-supported > hardware, if > CONFIG_DRM_MGAG200=y (built into the kernel). I am not able to reproduce it with and without my patch

Re: [PATCH] drm/mgag200: fix memory leak

2015-09-14 Thread Sudip Mukherjee
On Mon, Sep 14, 2015 at 08:05:37PM +1000, Dave Airlie wrote: > (this time with correct email address). > > On 14 September 2015 at 20:04, Dave Airlie wrote: > >> > >> > >> There's a new regression: v4.3-rc1 crashes on bootup on non-supported > >> hardware, if > >>

Re: [PATCH] drm/mgag200: fix memory leak

2015-09-14 Thread Archit Taneja
Hi, On 9/14/2015 3:35 PM, Dave Airlie wrote: (this time with correct email address). On 14 September 2015 at 20:04, Dave Airlie wrote: If drm_fb_helper_alloc_fbi() fails then we were directly returning without freeing sysram. Also if drm_fb_helper_alloc_fbi() succeeds

Re: [PATCH] drm/mgag200: fix memory leak

2015-09-14 Thread Sudip Mukherjee
On Sun, Sep 13, 2015 at 11:36:07AM +0200, Ingo Molnar wrote: > > * Sudip Mukherjee wrote: > > > There's a new regression: v4.3-rc1 crashes on bootup on non-supported > hardware, if > CONFIG_DRM_MGAG200=y (built into the kernel). I am not able to reproduce it

Re: [PATCH] drm/mgag200: fix memory leak

2015-09-14 Thread Dave Airlie
> >> If drm_fb_helper_alloc_fbi() fails then we were directly returning >> without freeing sysram. Also if drm_fb_helper_alloc_fbi() succeeds but >> mgag200_framebuffer_init() fails then we were not releasing sysram and >> we were not releasing fbi helper also. >> >> Signed-off-by: Sudip Mukherjee

Re: [PATCH] drm/mgag200: fix memory leak

2015-09-14 Thread Dave Airlie
(this time with correct email address). On 14 September 2015 at 20:04, Dave Airlie wrote: >> >>> If drm_fb_helper_alloc_fbi() fails then we were directly returning >>> without freeing sysram. Also if drm_fb_helper_alloc_fbi() succeeds but >>> mgag200_framebuffer_init() fails

Re: [PATCH] drm/mgag200: fix memory leak

2015-09-13 Thread Ingo Molnar
* Sudip Mukherjee wrote: > If drm_fb_helper_alloc_fbi() fails then we were directly returning > without freeing sysram. Also if drm_fb_helper_alloc_fbi() succeeds but > mgag200_framebuffer_init() fails then we were not releasing sysram and > we were not releasing fbi helper also. > >

Re: [PATCH] drm/mgag200: fix memory leak

2015-09-13 Thread Ingo Molnar
* Sudip Mukherjee wrote: > If drm_fb_helper_alloc_fbi() fails then we were directly returning > without freeing sysram. Also if drm_fb_helper_alloc_fbi() succeeds but > mgag200_framebuffer_init() fails then we were not releasing sysram and > we were not releasing fbi

[PATCH] drm/mgag200: fix memory leak

2015-09-07 Thread Sudip Mukherjee
If drm_fb_helper_alloc_fbi() fails then we were directly returning without freeing sysram. Also if drm_fb_helper_alloc_fbi() succeeds but mgag200_framebuffer_init() fails then we were not releasing sysram and we were not releasing fbi helper also. Signed-off-by: Sudip Mukherjee ---

[PATCH] drm/mgag200: fix memory leak

2015-09-07 Thread Sudip Mukherjee
If drm_fb_helper_alloc_fbi() fails then we were directly returning without freeing sysram. Also if drm_fb_helper_alloc_fbi() succeeds but mgag200_framebuffer_init() fails then we were not releasing sysram and we were not releasing fbi helper also. Signed-off-by: Sudip Mukherjee