Re: [PATCH] drm/panfrost: fix ref count leak in panfrost_job_hw_submit

2020-07-09 Thread Steven Price
On 09/07/2020 16:44, Rob Herring wrote: On Sun, Jun 14, 2020 at 12:27 AM Navid Emamdoost wrote: in panfrost_job_hw_submit, pm_runtime_get_sync is called which increments the counter even in case of failure, leading to incorrect ref count. In case of failure, decrement the ref count before

Re: [PATCH] drm/panfrost: fix ref count leak in panfrost_job_hw_submit

2020-07-09 Thread Rob Herring
On Sun, Jun 14, 2020 at 12:27 AM Navid Emamdoost wrote: > > in panfrost_job_hw_submit, pm_runtime_get_sync is called which > increments the counter even in case of failure, leading to incorrect > ref count. In case of failure, decrement the ref count before returning. > > Signed-off-by: Navid

Re: [PATCH] drm/panfrost: fix ref count leak in panfrost_job_hw_submit

2020-07-06 Thread Alyssa Rosenzweig
Acked-by: Alyssa Rosenzweig On Sun, Jun 14, 2020 at 01:27:30AM -0500, Navid Emamdoost wrote: > in panfrost_job_hw_submit, pm_runtime_get_sync is called which > increments the counter even in case of failure, leading to incorrect > ref count. In case of failure, decrement the ref count before

Re: [PATCH] drm/panfrost: fix ref count leak in panfrost_job_hw_submit

2020-06-14 Thread Markus Elfring
> in panfrost_job_hw_submit, … * Can the term “reference count” become relevant also for this commit message besides other possible adjustments? * Would you like to add the tag “Fixes”? … > +++ b/drivers/gpu/drm/panfrost/panfrost_job.c … > @@ -184,6 +183,9 @@ static void

Re: [PATCH] drm/panfrost: fix ref count leak in panfrost_job_hw_submit

2020-06-14 Thread Markus Elfring
> in panfrost_job_hw_submit, … * Can the term “reference count” become relevant also for this commit message besides other possible adjustments? * Would you like to add the tag “Fixes”? … > +++ b/drivers/gpu/drm/panfrost/panfrost_job.c … > @@ -184,6 +183,9 @@ static void

Re: [PATCH] drm/panfrost: fix ref count leak in panfrost_job_hw_submit

2020-06-14 Thread Markus Elfring
> in panfrost_job_hw_submit, … * Can the term “reference count” become relevant also for this commit message besides other possible adjustments? * Would you like to add the tag “Fixes”? … > +++ b/drivers/gpu/drm/panfrost/panfrost_job.c … > @@ -184,6 +183,9 @@ static void

[PATCH] drm/panfrost: fix ref count leak in panfrost_job_hw_submit

2020-06-14 Thread Navid Emamdoost
in panfrost_job_hw_submit, pm_runtime_get_sync is called which increments the counter even in case of failure, leading to incorrect ref count. In case of failure, decrement the ref count before returning. Signed-off-by: Navid Emamdoost --- drivers/gpu/drm/panfrost/panfrost_job.c | 8 +--- 1