Re: [PATCH] drm/pl111: add ARM_AMBA dependency

2017-05-24 Thread Arnd Bergmann
On Tue, May 23, 2017 at 12:08 AM, Eric Anholt wrote: > > Oh, yeah, we've eliminated the amba_request_regions() that used to be > why the probe had to be under the #ifdef, so your solution would get us > better coverage and simpler code. If you could send that patch to >

Re: [PATCH] drm/pl111: add ARM_AMBA dependency

2017-05-24 Thread Arnd Bergmann
On Tue, May 23, 2017 at 12:08 AM, Eric Anholt wrote: > > Oh, yeah, we've eliminated the amba_request_regions() that used to be > why the probe had to be under the #ifdef, so your solution would get us > better coverage and simpler code. If you could send that patch to > dri-devel today, I'll

Re: [PATCH] drm/pl111: add ARM_AMBA dependency

2017-05-23 Thread Krzysztof Kozlowski
On Tue, May 23, 2017 at 1:22 PM, Arnd Bergmann wrote: > On Tue, May 23, 2017 at 1:17 PM, Krzysztof Kozlowski wrote: >> On Mon, May 22, 2017 at 11:37 PM, Arnd Bergmann wrote: >>> On Mon, May 22, 2017 at 6:32 PM, Krzysztof Kozlowski

Re: [PATCH] drm/pl111: add ARM_AMBA dependency

2017-05-23 Thread Krzysztof Kozlowski
On Tue, May 23, 2017 at 1:22 PM, Arnd Bergmann wrote: > On Tue, May 23, 2017 at 1:17 PM, Krzysztof Kozlowski wrote: >> On Mon, May 22, 2017 at 11:37 PM, Arnd Bergmann wrote: >>> On Mon, May 22, 2017 at 6:32 PM, Krzysztof Kozlowski >>> wrote: On Mon, May 22, 2017 at 05:20:08PM +0200, Arnd

Re: [PATCH] drm/pl111: add ARM_AMBA dependency

2017-05-23 Thread Arnd Bergmann
On Tue, May 23, 2017 at 1:17 PM, Krzysztof Kozlowski wrote: > On Mon, May 22, 2017 at 11:37 PM, Arnd Bergmann wrote: >> On Mon, May 22, 2017 at 6:32 PM, Krzysztof Kozlowski wrote: >>> On Mon, May 22, 2017 at 05:20:08PM +0200, Arnd Bergmann wrote:

Re: [PATCH] drm/pl111: add ARM_AMBA dependency

2017-05-23 Thread Arnd Bergmann
On Tue, May 23, 2017 at 1:17 PM, Krzysztof Kozlowski wrote: > On Mon, May 22, 2017 at 11:37 PM, Arnd Bergmann wrote: >> On Mon, May 22, 2017 at 6:32 PM, Krzysztof Kozlowski wrote: >>> On Mon, May 22, 2017 at 05:20:08PM +0200, Arnd Bergmann wrote: The driver is written in a way to enable

Re: [PATCH] drm/pl111: add ARM_AMBA dependency

2017-05-23 Thread Krzysztof Kozlowski
On Mon, May 22, 2017 at 11:37 PM, Arnd Bergmann wrote: > On Mon, May 22, 2017 at 6:32 PM, Krzysztof Kozlowski wrote: >> On Mon, May 22, 2017 at 05:20:08PM +0200, Arnd Bergmann wrote: >>> The driver is written in a way to enable compile-testing without >>>

Re: [PATCH] drm/pl111: add ARM_AMBA dependency

2017-05-23 Thread Krzysztof Kozlowski
On Mon, May 22, 2017 at 11:37 PM, Arnd Bergmann wrote: > On Mon, May 22, 2017 at 6:32 PM, Krzysztof Kozlowski wrote: >> On Mon, May 22, 2017 at 05:20:08PM +0200, Arnd Bergmann wrote: >>> The driver is written in a way to enable compile-testing without >>> CONFIG_ARM_AMBA, >>> but it just causes

Re: [PATCH] drm/pl111: add ARM_AMBA dependency

2017-05-22 Thread Eric Anholt
Arnd Bergmann writes: > On Mon, May 22, 2017 at 6:23 PM, Eric Anholt wrote: >> Arnd Bergmann writes: >> >>> The driver is written in a way to enable compile-testing without >>> CONFIG_ARM_AMBA, >>> but it just causes needless warnings: >>> >>>

Re: [PATCH] drm/pl111: add ARM_AMBA dependency

2017-05-22 Thread Eric Anholt
Arnd Bergmann writes: > On Mon, May 22, 2017 at 6:23 PM, Eric Anholt wrote: >> Arnd Bergmann writes: >> >>> The driver is written in a way to enable compile-testing without >>> CONFIG_ARM_AMBA, >>> but it just causes needless warnings: >>> >>> drivers/gpu/drm/pl111/pl111_drv.c:149:26: error:

Re: [PATCH] drm/pl111: add ARM_AMBA dependency

2017-05-22 Thread Arnd Bergmann
On Mon, May 22, 2017 at 6:23 PM, Eric Anholt wrote: > Arnd Bergmann writes: > >> The driver is written in a way to enable compile-testing without >> CONFIG_ARM_AMBA, >> but it just causes needless warnings: >> >> drivers/gpu/drm/pl111/pl111_drv.c:149:26: error:

Re: [PATCH] drm/pl111: add ARM_AMBA dependency

2017-05-22 Thread Arnd Bergmann
On Mon, May 22, 2017 at 6:23 PM, Eric Anholt wrote: > Arnd Bergmann writes: > >> The driver is written in a way to enable compile-testing without >> CONFIG_ARM_AMBA, >> but it just causes needless warnings: >> >> drivers/gpu/drm/pl111/pl111_drv.c:149:26: error: 'pl111_drm_driver' defined >>

Re: [PATCH] drm/pl111: add ARM_AMBA dependency

2017-05-22 Thread Arnd Bergmann
On Mon, May 22, 2017 at 6:32 PM, Krzysztof Kozlowski wrote: > On Mon, May 22, 2017 at 05:20:08PM +0200, Arnd Bergmann wrote: >> The driver is written in a way to enable compile-testing without >> CONFIG_ARM_AMBA, >> but it just causes needless warnings: >> >>

Re: [PATCH] drm/pl111: add ARM_AMBA dependency

2017-05-22 Thread Arnd Bergmann
On Mon, May 22, 2017 at 6:32 PM, Krzysztof Kozlowski wrote: > On Mon, May 22, 2017 at 05:20:08PM +0200, Arnd Bergmann wrote: >> The driver is written in a way to enable compile-testing without >> CONFIG_ARM_AMBA, >> but it just causes needless warnings: >> >>

Re: [PATCH] drm/pl111: add ARM_AMBA dependency

2017-05-22 Thread Krzysztof Kozlowski
On Mon, May 22, 2017 at 05:20:08PM +0200, Arnd Bergmann wrote: > The driver is written in a way to enable compile-testing without > CONFIG_ARM_AMBA, > but it just causes needless warnings: > > drivers/gpu/drm/pl111/pl111_drv.c:149:26: error: 'pl111_drm_driver' defined > but not used

Re: [PATCH] drm/pl111: add ARM_AMBA dependency

2017-05-22 Thread Krzysztof Kozlowski
On Mon, May 22, 2017 at 05:20:08PM +0200, Arnd Bergmann wrote: > The driver is written in a way to enable compile-testing without > CONFIG_ARM_AMBA, > but it just causes needless warnings: > > drivers/gpu/drm/pl111/pl111_drv.c:149:26: error: 'pl111_drm_driver' defined > but not used

Re: [PATCH] drm/pl111: add ARM_AMBA dependency

2017-05-22 Thread Eric Anholt
Arnd Bergmann writes: > The driver is written in a way to enable compile-testing without > CONFIG_ARM_AMBA, > but it just causes needless warnings: > > drivers/gpu/drm/pl111/pl111_drv.c:149:26: error: 'pl111_drm_driver' defined > but not used [-Werror=unused-variable] >

Re: [PATCH] drm/pl111: add ARM_AMBA dependency

2017-05-22 Thread Eric Anholt
Arnd Bergmann writes: > The driver is written in a way to enable compile-testing without > CONFIG_ARM_AMBA, > but it just causes needless warnings: > > drivers/gpu/drm/pl111/pl111_drv.c:149:26: error: 'pl111_drm_driver' defined > but not used [-Werror=unused-variable] >

[PATCH] drm/pl111: add ARM_AMBA dependency

2017-05-22 Thread Arnd Bergmann
The driver is written in a way to enable compile-testing without CONFIG_ARM_AMBA, but it just causes needless warnings: drivers/gpu/drm/pl111/pl111_drv.c:149:26: error: 'pl111_drm_driver' defined but not used [-Werror=unused-variable] drivers/gpu/drm/pl111/pl111_drv.c:81:12: error:

[PATCH] drm/pl111: add ARM_AMBA dependency

2017-05-22 Thread Arnd Bergmann
The driver is written in a way to enable compile-testing without CONFIG_ARM_AMBA, but it just causes needless warnings: drivers/gpu/drm/pl111/pl111_drv.c:149:26: error: 'pl111_drm_driver' defined but not used [-Werror=unused-variable] drivers/gpu/drm/pl111/pl111_drv.c:81:12: error: