Re: [PATCH] drm/radeon: don't add files at control minor debugfs directory

On Mon, Dec 05, 2016 at 09:48:02AM +0100, Christian König wrote: > Am 05.12.2016 um 09:39 schrieb Nicolai Stange: > > Christian König writes: > > > > > Am 05.12.2016 um 08:27 schrieb Daniel Vetter: > > > > On Sat, Dec 03, 2016 at 03:47:00PM +0100, Nicolai Stange wrote:

Re: [PATCH] drm/radeon: don't add files at control minor debugfs directory

On Mon, Dec 05, 2016 at 09:48:02AM +0100, Christian König wrote: > Am 05.12.2016 um 09:39 schrieb Nicolai Stange: > > Christian König writes: > > > > > Am 05.12.2016 um 08:27 schrieb Daniel Vetter: > > > > On Sat, Dec 03, 2016 at 03:47:00PM +0100, Nicolai Stange wrote: > > > > > Since commit

Re: [PATCH] drm/radeon: don't add files at control minor debugfs directory

Am 05.12.2016 um 09:39 schrieb Nicolai Stange: Christian König writes: Am 05.12.2016 um 08:27 schrieb Daniel Vetter: On Sat, Dec 03, 2016 at 03:47:00PM +0100, Nicolai Stange wrote: Since commit 8a357d10043c ("drm: Nerf DRM_CONTROL nodes"), a struct drm_device's

Re: [PATCH] drm/radeon: don't add files at control minor debugfs directory

Am 05.12.2016 um 09:39 schrieb Nicolai Stange: Christian König writes: Am 05.12.2016 um 08:27 schrieb Daniel Vetter: On Sat, Dec 03, 2016 at 03:47:00PM +0100, Nicolai Stange wrote: Since commit 8a357d10043c ("drm: Nerf DRM_CONTROL nodes"), a struct drm_device's ->control member is always

Re: [PATCH] drm/radeon: don't add files at control minor debugfs directory

On 05/12/16 05:48 PM, Christian König wrote: > Am 05.12.2016 um 09:39 schrieb Nicolai Stange:>> >> I'll send compile-only tested patches either tonight or tomorrow. Shall >> they cover the oopses only or the dead code as well? > > Please start with the ops, cause we certainly will get complains

Re: [PATCH] drm/radeon: don't add files at control minor debugfs directory

On 05/12/16 05:48 PM, Christian König wrote: > Am 05.12.2016 um 09:39 schrieb Nicolai Stange:>> >> I'll send compile-only tested patches either tonight or tomorrow. Shall >> they cover the oopses only or the dead code as well? > > Please start with the ops, cause we certainly will get complains

Re: [PATCH] drm/radeon: don't add files at control minor debugfs directory

Christian König writes: > Am 05.12.2016 um 08:27 schrieb Daniel Vetter: >> On Sat, Dec 03, 2016 at 03:47:00PM +0100, Nicolai Stange wrote: >>> Since commit 8a357d10043c ("drm: Nerf DRM_CONTROL nodes"), a >>> struct drm_device's ->control member is always NULL. >>> >>>

Re: [PATCH] drm/radeon: don't add files at control minor debugfs directory

Christian König writes: > Am 05.12.2016 um 08:27 schrieb Daniel Vetter: >> On Sat, Dec 03, 2016 at 03:47:00PM +0100, Nicolai Stange wrote: >>> Since commit 8a357d10043c ("drm: Nerf DRM_CONTROL nodes"), a >>> struct drm_device's ->control member is always NULL. >>> >>> In the case of

Re: [PATCH] drm/radeon: don't add files at control minor debugfs directory

On Mon, Dec 05, 2016 at 08:42:49AM +0100, Christian König wrote: > Am 05.12.2016 um 08:27 schrieb Daniel Vetter: > > On Sat, Dec 03, 2016 at 03:47:00PM +0100, Nicolai Stange wrote: > > > Since commit 8a357d10043c ("drm: Nerf DRM_CONTROL nodes"), a > > > struct drm_device's ->control member is

Re: [PATCH] drm/radeon: don't add files at control minor debugfs directory

On Mon, Dec 05, 2016 at 08:42:49AM +0100, Christian König wrote: > Am 05.12.2016 um 08:27 schrieb Daniel Vetter: > > On Sat, Dec 03, 2016 at 03:47:00PM +0100, Nicolai Stange wrote: > > > Since commit 8a357d10043c ("drm: Nerf DRM_CONTROL nodes"), a > > > struct drm_device's ->control member is

Re: [PATCH] drm/radeon: don't add files at control minor debugfs directory

Am 05.12.2016 um 08:27 schrieb Daniel Vetter: On Sat, Dec 03, 2016 at 03:47:00PM +0100, Nicolai Stange wrote: Since commit 8a357d10043c ("drm: Nerf DRM_CONTROL nodes"), a struct drm_device's ->control member is always NULL. In the case of CONFIG_DEBUG_FS=y, radeon_debugfs_add_files() accesses

Re: [PATCH] drm/radeon: don't add files at control minor debugfs directory

Am 05.12.2016 um 08:27 schrieb Daniel Vetter: On Sat, Dec 03, 2016 at 03:47:00PM +0100, Nicolai Stange wrote: Since commit 8a357d10043c ("drm: Nerf DRM_CONTROL nodes"), a struct drm_device's ->control member is always NULL. In the case of CONFIG_DEBUG_FS=y, radeon_debugfs_add_files() accesses

Re: [PATCH] drm/radeon: don't add files at control minor debugfs directory

On Sat, Dec 03, 2016 at 03:47:00PM +0100, Nicolai Stange wrote: > Since commit 8a357d10043c ("drm: Nerf DRM_CONTROL nodes"), a > struct drm_device's ->control member is always NULL. > > In the case of CONFIG_DEBUG_FS=y, radeon_debugfs_add_files() accesses > ->control->debugfs_root though. This

Re: [PATCH] drm/radeon: don't add files at control minor debugfs directory

On Sat, Dec 03, 2016 at 03:47:00PM +0100, Nicolai Stange wrote: > Since commit 8a357d10043c ("drm: Nerf DRM_CONTROL nodes"), a > struct drm_device's ->control member is always NULL. > > In the case of CONFIG_DEBUG_FS=y, radeon_debugfs_add_files() accesses > ->control->debugfs_root though. This

[PATCH] drm/radeon: don't add files at control minor debugfs directory

Since commit 8a357d10043c ("drm: Nerf DRM_CONTROL nodes"), a struct drm_device's ->control member is always NULL. In the case of CONFIG_DEBUG_FS=y, radeon_debugfs_add_files() accesses ->control->debugfs_root though. This results in the following Oops: BUG: unable to handle kernel NULL pointer

[PATCH] drm/radeon: don't add files at control minor debugfs directory

Since commit 8a357d10043c ("drm: Nerf DRM_CONTROL nodes"), a struct drm_device's ->control member is always NULL. In the case of CONFIG_DEBUG_FS=y, radeon_debugfs_add_files() accesses ->control->debugfs_root though. This results in the following Oops: BUG: unable to handle kernel NULL pointer