Re: [PATCH] drm/vc4: clean up error handling on devm_kzalloc failure

2017-09-08 Thread Eric Anholt
Colin King writes: > From: Colin Ian King > > The current error handling on devm_kzalloc failures performs a non-null > check on connector. Thss check is redundant because connector is null > at that failure point. With this check removed, we

Re: [PATCH] drm/vc4: clean up error handling on devm_kzalloc failure

2017-09-08 Thread Eric Anholt
Colin King writes: > From: Colin Ian King > > The current error handling on devm_kzalloc failures performs a non-null > check on connector. Thss check is redundant because connector is null > at that failure point. With this check removed, we may as well make > the failure path into a trivial

Re: [PATCH] drm/vc4: clean up error handling on devm_kzalloc failure

2017-09-08 Thread Eric Engestrom
On Friday, 2017-09-08 14:17:04 +0100, Colin King wrote: > From: Colin Ian King > > The current error handling on devm_kzalloc failures performs a non-null > check on connector. Thss check is redundant because connector is null > at that failure point. With this check

Re: [PATCH] drm/vc4: clean up error handling on devm_kzalloc failure

2017-09-08 Thread Eric Engestrom
On Friday, 2017-09-08 14:17:04 +0100, Colin King wrote: > From: Colin Ian King > > The current error handling on devm_kzalloc failures performs a non-null > check on connector. Thss check is redundant because connector is null > at that failure point. With this check removed, we may as well

Re: [PATCH] drm/vc4: clean up error handling on devm_kzalloc failure

2017-09-08 Thread Emil Velikov
Hi Colin, On 8 September 2017 at 14:17, Colin King wrote: > From: Colin Ian King > > The current error handling on devm_kzalloc failures performs a non-null > check on connector. Thss check is redundant because connector is null > at that

Re: [PATCH] drm/vc4: clean up error handling on devm_kzalloc failure

2017-09-08 Thread Emil Velikov
Hi Colin, On 8 September 2017 at 14:17, Colin King wrote: > From: Colin Ian King > > The current error handling on devm_kzalloc failures performs a non-null > check on connector. Thss check is redundant because connector is null > at that failure point. With this check removed, we may as well

[PATCH] drm/vc4: clean up error handling on devm_kzalloc failure

2017-09-08 Thread Colin King
From: Colin Ian King The current error handling on devm_kzalloc failures performs a non-null check on connector. Thss check is redundant because connector is null at that failure point. With this check removed, we may as well make the failure path into a trivial

[PATCH] drm/vc4: clean up error handling on devm_kzalloc failure

2017-09-08 Thread Colin King
From: Colin Ian King The current error handling on devm_kzalloc failures performs a non-null check on connector. Thss check is redundant because connector is null at that failure point. With this check removed, we may as well make the failure path into a trivial -ENOMEM return to clean up the