Re: [PATCH] drm: bridge: rename the function drm_bridge_hpd_notify to drm_bridge_hpd_cb

2021-04-07 Thread Dafna Hirschfeld
Hi On 06.04.21 14:40, Laurent Pinchart wrote: Hi Dafna, Thank you for the patch. On Tue, Mar 30, 2021 at 01:52:00PM +0200, Dafna Hirschfeld wrote: drm_bridge_funcs has a function called 'hpd_notify'. The function drm_bridge_hpd_notify does not call 'hpd_notify' but it calls 'hpd_cb'. This is

Re: [PATCH] drm: bridge: rename the function drm_bridge_hpd_notify to drm_bridge_hpd_cb

2021-04-06 Thread Laurent Pinchart
Hi Dafna, Thank you for the patch. On Tue, Mar 30, 2021 at 01:52:00PM +0200, Dafna Hirschfeld wrote: > drm_bridge_funcs has a function called 'hpd_notify'. > The function drm_bridge_hpd_notify does not call > 'hpd_notify' but it calls 'hpd_cb'. This is rather > confusing. Rename the function to

Re: [PATCH] drm: bridge: rename the function drm_bridge_hpd_notify to drm_bridge_hpd_cb

2021-04-06 Thread Robert Foss
Reviewed-by: Robert Foss On Tue, 30 Mar 2021 at 14:28, Robert Foss wrote: > > Hey Dafna, > > Thanks for submitting a cleanup patch, it is much appreciated. It > looks good to me, feel free to add my r-b. > > I'm not going to merge this right away, but will let this patch soak > for a while to

Re: [PATCH] drm: bridge: rename the function drm_bridge_hpd_notify to drm_bridge_hpd_cb

2021-03-30 Thread Robert Foss
Hey Dafna, Thanks for submitting a cleanup patch, it is much appreciated. It looks good to me, feel free to add my r-b. I'm not going to merge this right away, but will let this patch soak for a while to let other people have a look at it. On Tue, 30 Mar 2021 at 13:52, Dafna Hirschfeld wrote:

[PATCH] drm: bridge: rename the function drm_bridge_hpd_notify to drm_bridge_hpd_cb

2021-03-30 Thread Dafna Hirschfeld
drm_bridge_funcs has a function called 'hpd_notify'. The function drm_bridge_hpd_notify does not call 'hpd_notify' but it calls 'hpd_cb'. This is rather confusing. Rename the function to fix this confusion. Signed-off-by: Dafna Hirschfeld --- drivers/gpu/drm/bridge/adv7511/adv7511_drv.c