Re: [PATCH] dsa: vsc73xx: add support for vlan filtering

2021-01-27 Thread Vladimir Oltean
Hi Pawel, On Mon, Jan 25, 2021 at 08:17:04AM +0100, Paweł Dembicki wrote: > > What are the issues that are preventing you from getting rid of > > DSA_TAG_PROTO_NONE? Not saying that making the driver VLAN aware is a > > bad idea, but maybe also adding a tagging driver should really be the > >

Re: [PATCH] dsa: vsc73xx: add support for vlan filtering

2021-01-25 Thread Linus Walleij
On Mon, Jan 25, 2021 at 12:45 AM Vladimir Oltean wrote: > Anyhow, you did not approve or disprove the tag_8021q idea. I just don't understand it well enough so I didn't know what to say about that... > With VLAN trunking on the CPU port, how would per-port traffic be > managed? Would it be

Re: [PATCH] dsa: vsc73xx: add support for vlan filtering

2021-01-24 Thread Paweł Dembicki
czw., 21 sty 2021 o 23:45 Vladimir Oltean napisał(a): > > Hi Pawel, > Hi Vladimir, Thank You for Your answer. > On Wed, Jan 20, 2021 at 07:30:18AM +0100, Pawel Dembicki wrote: > > This patch adds support for vlan filtering in vsc73xx driver. > > > > After vlan filtering enable, CPU_PORT is

Re: [PATCH] dsa: vsc73xx: add support for vlan filtering

2021-01-24 Thread Vladimir Oltean
On Mon, Jan 25, 2021 at 12:19:55AM +0100, Linus Walleij wrote: > This is due to the internal architecture of the switch, while it does > have an internal tagging format, this is stripped off before letting > it exit through the CPU port, and tagged on by the hardware > whenever the CPU transmits

Re: [PATCH] dsa: vsc73xx: add support for vlan filtering

2021-01-24 Thread Linus Walleij
On Thu, Jan 21, 2021 at 11:45 PM Vladimir Oltean wrote: > On Wed, Jan 20, 2021 at 07:30:18AM +0100, Pawel Dembicki wrote: > > This patch adds support for vlan filtering in vsc73xx driver. > > > > After vlan filtering enable, CPU_PORT is configured as trunk, without > > non-tagged frames. This

Re: [PATCH] dsa: vsc73xx: add support for vlan filtering

2021-01-21 Thread Vladimir Oltean
Hi Pawel, On Wed, Jan 20, 2021 at 07:30:18AM +0100, Pawel Dembicki wrote: > This patch adds support for vlan filtering in vsc73xx driver. > > After vlan filtering enable, CPU_PORT is configured as trunk, without > non-tagged frames. This allows to avoid problems with transmit untagged > frames

Re: [PATCH] dsa: vsc73xx: add support for vlan filtering

2021-01-20 Thread kernel test robot
Hi Pawel, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net/master] [also build test WARNING on net-next/master ipvs/master linus/master v5.11-rc4 next-20210120] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting

[PATCH] dsa: vsc73xx: add support for vlan filtering

2021-01-19 Thread Pawel Dembicki
This patch adds support for vlan filtering in vsc73xx driver. After vlan filtering enable, CPU_PORT is configured as trunk, without non-tagged frames. This allows to avoid problems with transmit untagged frames because vsc73xx is DSA_TAG_PROTO_NONE. Signed-off-by: Pawel Dembicki ---