Re: [PATCH] dt-bindings: net: dwmac: fix 'mac-mode' type

2019-09-21 Thread Jakub Kicinski
On Fri, 20 Sep 2019 20:02:58 -0700, Florian Fainelli wrote: > On 9/20/2019 6:11 PM, Jakub Kicinski wrote: > > On Tue, 17 Sep 2019 13:30:52 +0300, Alexandru Ardelean wrote: > >> The 'mac-mode' property is similar to 'phy-mode' and 'phy-connection-type', > >> which are enums of mode strings. > >>

Re: [PATCH] dt-bindings: net: dwmac: fix 'mac-mode' type

2019-09-20 Thread Florian Fainelli
On 9/20/2019 6:11 PM, Jakub Kicinski wrote: > On Tue, 17 Sep 2019 13:30:52 +0300, Alexandru Ardelean wrote: >> The 'mac-mode' property is similar to 'phy-mode' and 'phy-connection-type', >> which are enums of mode strings. >> >> The 'dwmac' driver supports almost all modes declared in the

Re: [PATCH] dt-bindings: net: dwmac: fix 'mac-mode' type

2019-09-20 Thread Jakub Kicinski
On Tue, 17 Sep 2019 13:30:52 +0300, Alexandru Ardelean wrote: > The 'mac-mode' property is similar to 'phy-mode' and 'phy-connection-type', > which are enums of mode strings. > > The 'dwmac' driver supports almost all modes declared in the 'phy-mode' > enum (except for 1 or 2). But in general,

Re: [PATCH] dt-bindings: net: dwmac: fix 'mac-mode' type

2019-09-17 Thread Rob Herring
On Tue, Sep 17, 2019 at 2:31 AM Alexandru Ardelean wrote: > > The 'mac-mode' property is similar to 'phy-mode' and 'phy-connection-type', > which are enums of mode strings. > > The 'dwmac' driver supports almost all modes declared in the 'phy-mode' > enum (except for 1 or 2). But in general,

Re: [PATCH] dt-bindings: net: dwmac: fix 'mac-mode' type

2019-09-17 Thread Ardelean, Alexandru
On Tue, 2019-09-17 at 14:41 +0200, Andrew Lunn wrote: > [External] > > On Tue, Sep 17, 2019 at 01:30:52PM +0300, Alexandru Ardelean wrote: > > The 'mac-mode' property is similar to 'phy-mode' and 'phy-connection-type', > > which are enums of mode strings. > > > > The 'dwmac' driver supports

Re: [PATCH] dt-bindings: net: dwmac: fix 'mac-mode' type

2019-09-17 Thread Andrew Lunn
On Tue, Sep 17, 2019 at 01:30:52PM +0300, Alexandru Ardelean wrote: > The 'mac-mode' property is similar to 'phy-mode' and 'phy-connection-type', > which are enums of mode strings. > > The 'dwmac' driver supports almost all modes declared in the 'phy-mode' > enum (except for 1 or 2). But in

[PATCH] dt-bindings: net: dwmac: fix 'mac-mode' type

2019-09-17 Thread Alexandru Ardelean
The 'mac-mode' property is similar to 'phy-mode' and 'phy-connection-type', which are enums of mode strings. The 'dwmac' driver supports almost all modes declared in the 'phy-mode' enum (except for 1 or 2). But in general, there may be a case where 'mac-mode' becomes more generic and is moved as