Re: [PATCH] efivarfs: merge boolean flag arguments

2016-05-03 Thread Matt Fleming
On Thu, 21 Apr, at 03:24:29PM, Julia Lawall wrote: > The parameters atomic and duplicates of efivar_init always have opposite > values. Drop the parameter atomic, replace the uses of !atomic with > duplicates, and update the call sites accordingly. > > The code using duplicates is slightly

Re: [PATCH] efivarfs: merge boolean flag arguments

2016-05-03 Thread Matt Fleming
On Thu, 21 Apr, at 03:24:29PM, Julia Lawall wrote: > The parameters atomic and duplicates of efivar_init always have opposite > values. Drop the parameter atomic, replace the uses of !atomic with > duplicates, and update the call sites accordingly. > > The code using duplicates is slightly

[PATCH] efivarfs: merge boolean flag arguments

2016-04-21 Thread Julia Lawall
The parameters atomic and duplicates of efivar_init always have opposite values. Drop the parameter atomic, replace the uses of !atomic with duplicates, and update the call sites accordingly. The code using duplicates is slightly reorganized with an else, to avoid duplicating the lock code.

[PATCH] efivarfs: merge boolean flag arguments

2016-04-21 Thread Julia Lawall
The parameters atomic and duplicates of efivar_init always have opposite values. Drop the parameter atomic, replace the uses of !atomic with duplicates, and update the call sites accordingly. The code using duplicates is slightly reorganized with an else, to avoid duplicating the lock code.