Re: [PATCH] exit: trigger panic when init process is set to SIGNAL_GROUP_EXIT

2021-03-10 Thread qianli zhao
Hi, Eric Thank you for your suggestion > At the start of your changelog and your patch subject you describe what > you are doing but not why. For the next revision of the patch please > lead with the why it makes what you are trying to do much easier to > understand. got it. > > It does not

Re: [PATCH] exit: trigger panic when init process is set to SIGNAL_GROUP_EXIT

2021-03-10 Thread Eric W. Biederman
Oleg Nesterov writes: > On 03/10, Eric W. Biederman wrote: >> >> /* If global init has exited, >> * panic immediately to get a useable coredump. >> */ >> if (unlikely(is_global_init(tsk) && >> (thread_group_empty(tsk) || >> (tsk->signal->flags &

Re: [PATCH] exit: trigger panic when init process is set to SIGNAL_GROUP_EXIT

2021-03-10 Thread Eric W. Biederman
Oleg Nesterov writes: > On 03/10, Eric W. Biederman wrote: >> >> /* If global init has exited, >> * panic immediately to get a useable coredump. >> */ >> if (unlikely(is_global_init(tsk) && >> (thread_group_empty(tsk) || >> (tsk->signal->flags &

Re: [PATCH] exit: trigger panic when init process is set to SIGNAL_GROUP_EXIT

2021-03-10 Thread Oleg Nesterov
On 03/10, Eric W. Biederman wrote: > > /* If global init has exited, > * panic immediately to get a useable coredump. > */ > if (unlikely(is_global_init(tsk) && > (thread_group_empty(tsk) || > (tsk->signal->flags & SIGNAL_GROUP_EXIT { >

Re: [PATCH] exit: trigger panic when init process is set to SIGNAL_GROUP_EXIT

2021-03-10 Thread Eric W. Biederman
qianli zhao writes: > Hi,Oleg > > Thanks for your replay. > >> To be honest, I don't understand the changelog. It seems that you want >> to uglify the kernel to simplify the debugging of buggy init? Or what? > > My patch is for the following purpose: > 1. I hope to fix the occurrence of

Re: [PATCH] exit: trigger panic when init process is set to SIGNAL_GROUP_EXIT

2021-03-09 Thread qianli zhao
Hi,Oleg Thanks for your replay. > To be honest, I don't understand the changelog. It seems that you want > to uglify the kernel to simplify the debugging of buggy init? Or what? My patch is for the following purpose: 1. I hope to fix the occurrence of unexpected panic - [ 24.705390] kernel

Re: [PATCH] exit: trigger panic when init process is set to SIGNAL_GROUP_EXIT

2021-03-09 Thread Oleg Nesterov
On 03/09, Qianli Zhao wrote: > > From: Qianli Zhao > > Once any init thread finds SIGNAL_GROUP_EXIT, trigger panic immediately > instead of last thread of global init has exited, and do not allow other > init threads to exit, protect task/memory state of all sub-threads for > get reliable init

[PATCH] exit: trigger panic when init process is set to SIGNAL_GROUP_EXIT

2021-03-09 Thread Qianli Zhao
From: Qianli Zhao Once any init thread finds SIGNAL_GROUP_EXIT, trigger panic immediately instead of last thread of global init has exited, and do not allow other init threads to exit, protect task/memory state of all sub-threads for get reliable init coredump [ 24.705376] Kernel panic - not