Re: [PATCH] explicitly bind idle tasks

2005-03-07 Thread Joel Schopp
Nathan Lynch wrote: With hotplug cpu and preempt, we tend to see smp_processor_id warnings from idle loop code because it's always checking whether its cpu has gone offline. Replacing every use of smp_processor_id with _smp_processor_id in all idle loop code is one solution; another way is

Re: [PATCH] explicitly bind idle tasks

2005-03-07 Thread Joel Schopp
Nathan Lynch wrote: With hotplug cpu and preempt, we tend to see smp_processor_id warnings from idle loop code because it's always checking whether its cpu has gone offline. Replacing every use of smp_processor_id with _smp_processor_id in all idle loop code is one solution; another way is

Re: [PATCH] explicitly bind idle tasks

2005-03-01 Thread Zwane Mwaikambo
On Tue, 1 Mar 2005, Nathan Lynch wrote: > On Sun, Feb 27, 2005 at 02:49:28PM -0800, Andrew Morton wrote: > > Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote: > > > > > > > - if (cpu_is_offline(smp_processor_id()) && > > > > + if (cpu_is_offline(_smp_processor_id()) &&

[PATCH] explicitly bind idle tasks

2005-03-01 Thread Nathan Lynch
On Sun, Feb 27, 2005 at 02:49:28PM -0800, Andrew Morton wrote: > Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote: > > > > > - if (cpu_is_offline(smp_processor_id()) && > > > +if (cpu_is_offline(_smp_processor_id()) && > > > system_state ==

[PATCH] explicitly bind idle tasks

2005-03-01 Thread Nathan Lynch
On Sun, Feb 27, 2005 at 02:49:28PM -0800, Andrew Morton wrote: Benjamin Herrenschmidt [EMAIL PROTECTED] wrote: - if (cpu_is_offline(smp_processor_id()) +if (cpu_is_offline(_smp_processor_id()) system_state == SYSTEM_RUNNING)

Re: [PATCH] explicitly bind idle tasks

2005-03-01 Thread Zwane Mwaikambo
On Tue, 1 Mar 2005, Nathan Lynch wrote: On Sun, Feb 27, 2005 at 02:49:28PM -0800, Andrew Morton wrote: Benjamin Herrenschmidt [EMAIL PROTECTED] wrote: - if (cpu_is_offline(smp_processor_id()) + if (cpu_is_offline(_smp_processor_id())