Re: [PATCH] exporting capability code/name pairs (try #5.1)

2008-02-19 Thread Greg KH
On Mon, Feb 18, 2008 at 05:45:46PM +0900, Kohei KaiGai wrote: > Greg KH wrote: > >>> Also, this code can be cleaned up a lot by just using the basic kobject > >>> attributes, and not rolling your own types here. > >> I replaced my own defined capability_attribute by kobj_attribute. > >> > >> It

Re: [PATCH] exporting capability code/name pairs (try #5.1)

2008-02-19 Thread Greg KH
On Mon, Feb 18, 2008 at 05:45:46PM +0900, Kohei KaiGai wrote: Greg KH wrote: Also, this code can be cleaned up a lot by just using the basic kobject attributes, and not rolling your own types here. I replaced my own defined capability_attribute by kobj_attribute. It made the patch

Re: [PATCH] exporting capability code/name pairs (try #5.1)

2008-02-18 Thread Serge E. Hallyn
Quoting Greg KH ([EMAIL PROTECTED]): > On Mon, Feb 18, 2008 at 04:12:53PM +0900, Kohei KaiGai wrote: > > Greg KH wrote: > > > On Fri, Feb 15, 2008 at 12:38:02PM -0600, Serge E. Hallyn wrote: > > >>> > > >>> This patch enables to export code/name of capabilities supported > > >>> on the

Re: [PATCH] exporting capability code/name pairs (try #5.1)

2008-02-18 Thread Kohei KaiGai
Greg KH wrote: > On Mon, Feb 18, 2008 at 04:12:53PM +0900, Kohei KaiGai wrote: >> Greg KH wrote: >>> On Fri, Feb 15, 2008 at 12:38:02PM -0600, Serge E. Hallyn wrote: > > This patch enables to export code/name of capabilities supported > on the running kernel. > > A

Re: [PATCH] exporting capability code/name pairs (try #5.1)

2008-02-18 Thread Kohei KaiGai
Greg KH wrote: On Mon, Feb 18, 2008 at 04:12:53PM +0900, Kohei KaiGai wrote: Greg KH wrote: On Fri, Feb 15, 2008 at 12:38:02PM -0600, Serge E. Hallyn wrote: This patch enables to export code/name of capabilities supported on the running kernel. A newer kernel sometimes adds new

Re: [PATCH] exporting capability code/name pairs (try #5.1)

2008-02-18 Thread Serge E. Hallyn
Quoting Greg KH ([EMAIL PROTECTED]): On Mon, Feb 18, 2008 at 04:12:53PM +0900, Kohei KaiGai wrote: Greg KH wrote: On Fri, Feb 15, 2008 at 12:38:02PM -0600, Serge E. Hallyn wrote: This patch enables to export code/name of capabilities supported on the running kernel. A

Re: [PATCH] exporting capability code/name pairs (try #5.1)

2008-02-17 Thread Greg KH
On Mon, Feb 18, 2008 at 04:12:53PM +0900, Kohei KaiGai wrote: > Greg KH wrote: > > On Fri, Feb 15, 2008 at 12:38:02PM -0600, Serge E. Hallyn wrote: > >>> > >>> This patch enables to export code/name of capabilities supported > >>> on the running kernel. > >>> > >>> A newer kernel

Re: [PATCH] exporting capability code/name pairs (try #5.1)

2008-02-17 Thread Kohei KaiGai
Greg KH wrote: > On Fri, Feb 15, 2008 at 12:38:02PM -0600, Serge E. Hallyn wrote: >>> >>> This patch enables to export code/name of capabilities supported >>> on the running kernel. >>> >>> A newer kernel sometimes adds new capabilities, like CAP_MAC_ADMIN >>> at 2.6.25. However, we have

Re: [PATCH] exporting capability code/name pairs (try #5.1)

2008-02-17 Thread Kohei KaiGai
Greg KH wrote: On Fri, Feb 15, 2008 at 12:38:02PM -0600, Serge E. Hallyn wrote: This patch enables to export code/name of capabilities supported on the running kernel. A newer kernel sometimes adds new capabilities, like CAP_MAC_ADMIN at 2.6.25. However, we have no interface to

Re: [PATCH] exporting capability code/name pairs (try #5.1)

2008-02-17 Thread Greg KH
On Mon, Feb 18, 2008 at 04:12:53PM +0900, Kohei KaiGai wrote: Greg KH wrote: On Fri, Feb 15, 2008 at 12:38:02PM -0600, Serge E. Hallyn wrote: This patch enables to export code/name of capabilities supported on the running kernel. A newer kernel sometimes adds new

Re: [PATCH] exporting capability code/name pairs (try #5.1)

2008-02-15 Thread Greg KH
On Fri, Feb 15, 2008 at 12:38:02PM -0600, Serge E. Hallyn wrote: > Quoting Kohei KaiGai ([EMAIL PROTECTED]): > > Li Zefan wrote: > > - snip - > > >> +error1: > > >> +kobject_put(capability_kobj); > > >> +error0: > > >> +printk(KERN_ERR "Unable to export capabilities\n"); > > >> +

Re: [PATCH] exporting capability code/name pairs (try #5.1)

2008-02-15 Thread Serge E. Hallyn
Quoting Kohei KaiGai ([EMAIL PROTECTED]): > Li Zefan wrote: > - snip - > >> +error1: > >> + kobject_put(capability_kobj); > >> +error0: > >> + printk(KERN_ERR "Unable to export capabilities\n"); > >> + > >> + return 0; > > > > Should return -EFXXX .. > > Oops, > I fixed it as follows. Thanks

Re: [PATCH] exporting capability code/name pairs (try #5.1)

2008-02-15 Thread Serge E. Hallyn
Quoting Kohei KaiGai ([EMAIL PROTECTED]): Li Zefan wrote: - snip - +error1: + kobject_put(capability_kobj); +error0: + printk(KERN_ERR Unable to export capabilities\n); + + return 0; Should return -EFXXX .. Oops, I fixed it as follows. Thanks for your pointed out.

Re: [PATCH] exporting capability code/name pairs (try #5.1)

2008-02-15 Thread Greg KH
On Fri, Feb 15, 2008 at 12:38:02PM -0600, Serge E. Hallyn wrote: Quoting Kohei KaiGai ([EMAIL PROTECTED]): Li Zefan wrote: - snip - +error1: +kobject_put(capability_kobj); +error0: +printk(KERN_ERR Unable to export capabilities\n); + +return 0;

Re: [PATCH] exporting capability code/name pairs (try #5.1)

2008-02-14 Thread Kohei KaiGai
Li Zefan wrote: - snip - >> +error1: >> +kobject_put(capability_kobj); >> +error0: >> +printk(KERN_ERR "Unable to export capabilities\n"); >> + >> +return 0; > > Should return -EFXXX .. Oops, I fixed it as follows. Thanks for your pointed out. This patch enables to export

Re: [PATCH] exporting capability code/name pairs (try #5.1)

2008-02-14 Thread Kohei KaiGai
Li Zefan wrote: - snip - +error1: +kobject_put(capability_kobj); +error0: +printk(KERN_ERR Unable to export capabilities\n); + +return 0; Should return -EFXXX .. Oops, I fixed it as follows. Thanks for your pointed out. This patch enables to export code/name of