Re: [PATCH] ext4: Remove expensive flush on fast commit

2021-01-13 Thread Theodore Ts'o
On Wed, Jan 06, 2021 at 10:32:42AM +0900, Daejun Park wrote: > In the fast commit, it adds REQ_FUA and REQ_PREFLUSH on each fast commit > block when barrier is enabled. However, in recovery phase, ext4 compares > CRC value in the tail. So it is sufficient adds REQ_FUA and REQ_PREFLUSH > on the bloc

RE: Re: [PATCH] ext4: Remove expensive flush on fast commit

2021-01-07 Thread Daejun Park
> > In the fast commit, it adds REQ_FUA and REQ_PREFLUSH on each fast commit > > block when barrier is enabled. However, in recovery phase, ext4 compares > > CRC value in the tail. So it is sufficient adds REQ_FUA and REQ_PREFLUSH > > on the block that has tail. > > Does the tail block *always* co

Re: [PATCH] ext4: Remove expensive flush on fast commit

2021-01-07 Thread Andreas Dilger
On Tue, Jan 5, 2021 at 5:32 PM Daejun Park wrote: > > In the fast commit, it adds REQ_FUA and REQ_PREFLUSH on each fast commit > block when barrier is enabled. However, in recovery phase, ext4 compares > CRC value in the tail. So it is sufficient adds REQ_FUA and REQ_PREFLUSH > on the block that

Re: [PATCH] ext4: Remove expensive flush on fast commit

2021-01-06 Thread Darrick J. Wong
On Wed, Jan 06, 2021 at 10:32:42AM +0900, Daejun Park wrote: > In the fast commit, it adds REQ_FUA and REQ_PREFLUSH on each fast commit > block when barrier is enabled. However, in recovery phase, ext4 compares > CRC value in the tail. So it is sufficient adds REQ_FUA and REQ_PREFLUSH > on the bloc

Re: [PATCH] ext4: Remove expensive flush on fast commit

2021-01-06 Thread harshad shirwadkar
Thanks Daejun! This looks good. Reviewed-by: Harshad Shirwadkar On Tue, Jan 5, 2021 at 5:32 PM Daejun Park wrote: > > In the fast commit, it adds REQ_FUA and REQ_PREFLUSH on each fast commit > block when barrier is enabled. However, in recovery phase, ext4 compares > CRC value in the tail. So i

[PATCH] ext4: Remove expensive flush on fast commit

2021-01-05 Thread Daejun Park
In the fast commit, it adds REQ_FUA and REQ_PREFLUSH on each fast commit block when barrier is enabled. However, in recovery phase, ext4 compares CRC value in the tail. So it is sufficient adds REQ_FUA and REQ_PREFLUSH on the block that has tail. Signed-off-by: Daejun Park --- fs/ext4/fast_commi