Re: [PATCH] ext4: dir inode reservation V3

2007-11-20 Thread Andreas Dilger
On Nov 20, 2007 12:22 -0800, Mingming Cao wrote: > On Tue, 2007-11-20 at 12:14 +0800, Coly Li wrote: > > Mingming Cao wrote: > > > On Tue, 2007-11-13 at 22:12 +0800, Coly Li wrote: > > The hole is (s_dir_ireserve_nr - 1), not N * s_dir_ireserve_nr. Because > > directory inode will also use a inode

Re: [PATCH] ext4: dir inode reservation V3

2007-11-20 Thread Mingming Cao
On Tue, 2007-11-20 at 12:14 +0800, Coly Li wrote: > Thanks for the feedback :-) > > Mingming Cao wrote: > > On Tue, 2007-11-13 at 22:12 +0800, Coly Li wrote: > >> Basic idea of my dir inode reservation patch can be found here, > >> http://lists.openwall.net/linux-ext4/2007/11/05/3 > >> > >> 1, Wha

Re: [PATCH] ext4: dir inode reservation V3

2007-11-20 Thread Jan Kara
On Wed 21-11-07 00:40:17, Coly Li wrote: > Jan Kara wrote: > >> diff --git a/fs/ext4/ialloc.c b/fs/ext4/ialloc.c > >> index 17b5df1..f838a72 100644 > >> --- a/fs/ext4/ialloc.c > >> +++ b/fs/ext4/ialloc.c > >> @@ -10,6 +10,8 @@ > >> * Stephen Tweedie ([EMAIL PROTECTED]), 1993 > >> * Big-endian

Re: [PATCH] ext4: dir inode reservation V3

2007-11-20 Thread Coly Li
Jan, Thanks for taking time to review the patch :-) Jan Kara wrote: > Hi Coly, > > finally I've found some time to have a look at a new version of your > patch. > >> 5, Performance number >> On a Core-Duo, 2MB DDM memory, 7200 RPM SATA PC, I built a 50GB ext4 >> partition, and tried to crea

Re: [PATCH] ext4: dir inode reservation V3

2007-11-20 Thread Jan Kara
Hi Coly, finally I've found some time to have a look at a new version of your patch. > 5, Performance number > On a Core-Duo, 2MB DDM memory, 7200 RPM SATA PC, I built a 50GB ext4 > partition, and tried to create 5 directories, and create 15 (1KB) > files in each directory alternatively.

Re: [PATCH] ext4: dir inode reservation V3

2007-11-19 Thread Coly Li
Thanks for the feedback :-) Mingming Cao wrote: > On Tue, 2007-11-13 at 22:12 +0800, Coly Li wrote: >> Basic idea of my dir inode reservation patch can be found here, >> http://lists.openwall.net/linux-ext4/2007/11/05/3 >> >> 1, What does dir inode reservation do >> Dir inode reservation tries to

Re: [PATCH] ext4: dir inode reservation V3

2007-11-19 Thread Mingming Cao
On Tue, 2007-11-13 at 22:12 +0800, Coly Li wrote: > Basic idea of my dir inode reservation patch can be found here, > http://lists.openwall.net/linux-ext4/2007/11/05/3 > > 1, What does dir inode reservation do > Dir inode reservation tries to reserve several inodes in inodes table for a > directo

Re: [PATCH] ext4: dir inode reservation V3

2007-11-13 Thread Coly Li
Coly Li wrote: > Thanks for the feedback :-) > > Alex Tomas wrote: >> hmm. so you trade 265% degradation of creation for 40% improvement of >> unlink? >> > 265% degradation is only for creating 5 empty directories. This is not a > common case. > There are 13% improvement on create 15 files

Re: [PATCH] ext4: dir inode reservation V3

2007-11-13 Thread Coly Li
Thanks for the feedback :-) Alex Tomas wrote: > hmm. so you trade 265% degradation of creation for 40% improvement of > unlink? > 265% degradation is only for creating 5 empty directories. This is not a common case. There are 13% improvement on create 15 files in each directories. Total time

Re: [PATCH] ext4: dir inode reservation V3

2007-11-13 Thread Alex Tomas
hmm. so you trade 265% degradation of creation for 40% improvement of unlink? thanks, Alex Coly Li wrote: normal ext4 ext4 with dir inode reservation mount options: -o data=writeback -o data=writeback,dir_ireserve=low

[PATCH] ext4: dir inode reservation V3

2007-11-13 Thread Coly Li
Basic idea of my dir inode reservation patch can be found here, http://lists.openwall.net/linux-ext4/2007/11/05/3 1, What does dir inode reservation do Dir inode reservation tries to reserve several inodes in inodes table for a directory when this directory is created. When create new file under