Re: [PATCH] extcon: gpio: Request reasonable interrupts

2019-06-24 Thread Linus Walleij
On Mon, Jun 24, 2019 at 2:08 AM Chanwoo Choi wrote: > On 19. 6. 8. 오전 6:24, Linus Walleij wrote: > > On Tue, Jun 4, 2019 at 3:30 AM Chanwoo Choi wrote: > >> On 19. 5. 31. 오전 3:39, Linus Walleij wrote: > > > >>> + /* > >>> + * It is unlikely that this is an acknowledged interrupt that

Re: [PATCH] extcon: gpio: Request reasonable interrupts

2019-06-23 Thread Chanwoo Choi
On 19. 6. 8. 오전 6:24, Linus Walleij wrote: > On Tue, Jun 4, 2019 at 3:30 AM Chanwoo Choi wrote: >> On 19. 5. 31. 오전 3:39, Linus Walleij wrote: > >>> + /* >>> + * It is unlikely that this is an acknowledged interrupt that goes >>> + * away after handling, what we are looking for are

Re: [PATCH] extcon: gpio: Request reasonable interrupts

2019-06-07 Thread Linus Walleij
On Tue, Jun 4, 2019 at 3:30 AM Chanwoo Choi wrote: > On 19. 5. 31. 오전 3:39, Linus Walleij wrote: > > + /* > > + * It is unlikely that this is an acknowledged interrupt that goes > > + * away after handling, what we are looking for are falling edges > > + * if the signal is

Re: [PATCH] extcon: gpio: Request reasonable interrupts

2019-06-03 Thread Chanwoo Choi
Hi Linus, On 19. 5. 31. 오전 3:39, Linus Walleij wrote: > The only thing that makes sense is to request a falling edge interrupt > if the line is active low and a rising edge interrupt if the line is > active high, so just do that and get rid of the assignment from > platform data. The GPIO

[PATCH] extcon: gpio: Request reasonable interrupts

2019-05-30 Thread Linus Walleij
The only thing that makes sense is to request a falling edge interrupt if the line is active low and a rising edge interrupt if the line is active high, so just do that and get rid of the assignment from platform data. The GPIO descriptor knows if the line is active high or low. Also make irq a