Re: [PATCH] f2fs: Eliminate usage of uninitialized_var() macro

2020-06-15 Thread Kees Cook
On Mon, Jun 15, 2020 at 04:51:32PM +0800, Jason Yan wrote: > This is an effort to eliminate the uninitialized_var() macro[1]. > > The use of this macro is the wrong solution because it forces off ANY > analysis by the compiler for a given variable. It even masks "unused > variable" warnings. > >

Re: [PATCH] f2fs: Eliminate usage of uninitialized_var() macro

2020-06-15 Thread Chao Yu
On 2020/6/15 16:51, Jason Yan wrote: > This is an effort to eliminate the uninitialized_var() macro[1]. > > The use of this macro is the wrong solution because it forces off ANY > analysis by the compiler for a given variable. It even masks "unused > variable" warnings. > > Quoted from Linus[2]:

[PATCH] f2fs: Eliminate usage of uninitialized_var() macro

2020-06-15 Thread Jason Yan
This is an effort to eliminate the uninitialized_var() macro[1]. The use of this macro is the wrong solution because it forces off ANY analysis by the compiler for a given variable. It even masks "unused variable" warnings. Quoted from Linus[2]: "It's a horrible thing to use, in that it adds

Re: [f2fs-dev] [PATCH] f2fs: Eliminate usage of uninitialized_var() macro

2020-06-15 Thread Jason Yan
在 2020/6/15 16:26, Chao Yu 写道: On 2020/6/15 12:02, Jason Yan wrote: This is an effort to eliminate the uninitialized_var() macro[1]. The use of this macro is the wrong solution because it forces off ANY analysis by the compiler for a given variable. It even masks "unused variable" warnings.

Re: [f2fs-dev] [PATCH] f2fs: Eliminate usage of uninitialized_var() macro

2020-06-15 Thread Chao Yu
On 2020/6/15 12:02, Jason Yan wrote: > This is an effort to eliminate the uninitialized_var() macro[1]. > > The use of this macro is the wrong solution because it forces off ANY > analysis by the compiler for a given variable. It even masks "unused > variable" warnings. > > Quoted from Linus[2]:

[PATCH] f2fs: Eliminate usage of uninitialized_var() macro

2020-06-14 Thread Jason Yan
This is an effort to eliminate the uninitialized_var() macro[1]. The use of this macro is the wrong solution because it forces off ANY analysis by the compiler for a given variable. It even masks "unused variable" warnings. Quoted from Linus[2]: "It's a horrible thing to use, in that it adds