Re: [PATCH] f2fs: Fix deadlock in shutdown ioctl

2018-05-16 Thread Sahitya Tummala
On Wed, May 16, 2018 at 02:48:42PM +0800, Chao Yu wrote: > > > > Thanks, I thought about it too but then I checked that XFS shutdown ioctl is > > not taking any lock for this ioctl. Hence, I followed the same in F2FS. > > Do you know why XFS is not taking any lock? > > I don't know. :( No

Re: [PATCH] f2fs: Fix deadlock in shutdown ioctl

2018-05-16 Thread Sahitya Tummala
On Wed, May 16, 2018 at 02:48:42PM +0800, Chao Yu wrote: > > > > Thanks, I thought about it too but then I checked that XFS shutdown ioctl is > > not taking any lock for this ioctl. Hence, I followed the same in F2FS. > > Do you know why XFS is not taking any lock? > > I don't know. :( No

Re: [PATCH] f2fs: Fix deadlock in shutdown ioctl

2018-05-16 Thread Chao Yu
On 2018/5/15 15:57, Sahitya Tummala wrote: > On Mon, May 14, 2018 at 11:39:42AM +0800, Chao Yu wrote: >> On 2018/5/10 21:20, Sahitya Tummala wrote: >>> f2fs_ioc_shutdown() ioctl gets stuck in the below path >>> when going down with full sync (F2FS_GOING_DOWN_FULLSYNC) >>> option. >>> >>>

Re: [PATCH] f2fs: Fix deadlock in shutdown ioctl

2018-05-16 Thread Chao Yu
On 2018/5/15 15:57, Sahitya Tummala wrote: > On Mon, May 14, 2018 at 11:39:42AM +0800, Chao Yu wrote: >> On 2018/5/10 21:20, Sahitya Tummala wrote: >>> f2fs_ioc_shutdown() ioctl gets stuck in the below path >>> when going down with full sync (F2FS_GOING_DOWN_FULLSYNC) >>> option. >>> >>>

Re: [PATCH] f2fs: Fix deadlock in shutdown ioctl

2018-05-15 Thread Sahitya Tummala
On Mon, May 14, 2018 at 11:39:42AM +0800, Chao Yu wrote: > On 2018/5/10 21:20, Sahitya Tummala wrote: > > f2fs_ioc_shutdown() ioctl gets stuck in the below path > > when going down with full sync (F2FS_GOING_DOWN_FULLSYNC) > > option. > > > > __switch_to+0x90/0xc4 > > percpu_down_write+0x8c/0xc0

Re: [PATCH] f2fs: Fix deadlock in shutdown ioctl

2018-05-15 Thread Sahitya Tummala
On Mon, May 14, 2018 at 11:39:42AM +0800, Chao Yu wrote: > On 2018/5/10 21:20, Sahitya Tummala wrote: > > f2fs_ioc_shutdown() ioctl gets stuck in the below path > > when going down with full sync (F2FS_GOING_DOWN_FULLSYNC) > > option. > > > > __switch_to+0x90/0xc4 > > percpu_down_write+0x8c/0xc0

Re: [PATCH] f2fs: Fix deadlock in shutdown ioctl

2018-05-13 Thread Chao Yu
On 2018/5/10 21:20, Sahitya Tummala wrote: > f2fs_ioc_shutdown() ioctl gets stuck in the below path > when going down with full sync (F2FS_GOING_DOWN_FULLSYNC) > option. > > __switch_to+0x90/0xc4 > percpu_down_write+0x8c/0xc0 > freeze_super+0xec/0x1e4 > freeze_bdev+0xc4/0xcc >

Re: [PATCH] f2fs: Fix deadlock in shutdown ioctl

2018-05-13 Thread Chao Yu
On 2018/5/10 21:20, Sahitya Tummala wrote: > f2fs_ioc_shutdown() ioctl gets stuck in the below path > when going down with full sync (F2FS_GOING_DOWN_FULLSYNC) > option. > > __switch_to+0x90/0xc4 > percpu_down_write+0x8c/0xc0 > freeze_super+0xec/0x1e4 > freeze_bdev+0xc4/0xcc >

[PATCH] f2fs: Fix deadlock in shutdown ioctl

2018-05-10 Thread Sahitya Tummala
f2fs_ioc_shutdown() ioctl gets stuck in the below path when going down with full sync (F2FS_GOING_DOWN_FULLSYNC) option. __switch_to+0x90/0xc4 percpu_down_write+0x8c/0xc0 freeze_super+0xec/0x1e4 freeze_bdev+0xc4/0xcc f2fs_ioctl+0xc0c/0x1ce0 f2fs_compat_ioctl+0x98/0x1f0 Fix this by not holding

[PATCH] f2fs: Fix deadlock in shutdown ioctl

2018-05-10 Thread Sahitya Tummala
f2fs_ioc_shutdown() ioctl gets stuck in the below path when going down with full sync (F2FS_GOING_DOWN_FULLSYNC) option. __switch_to+0x90/0xc4 percpu_down_write+0x8c/0xc0 freeze_super+0xec/0x1e4 freeze_bdev+0xc4/0xcc f2fs_ioctl+0xc0c/0x1ce0 f2fs_compat_ioctl+0x98/0x1f0 Fix this by not holding