Re: [f2fs-dev] [PATCH] f2fs: compress: Allow modular (de)compression algorithms

2021-02-25 Thread Chao Yu
Hi Geert, On 2021/2/23 15:42, Geert Uytterhoeven wrote: I checked the code in menu_finalize(), and this seems to work like this. I discussed the oddity of the select behavior before (https://lore.kernel.org/linux-kbuild/e1a6228d-1341-6264-d97a-e2bd52a65...@infradead.org/), but I was not

Re: [PATCH] f2fs: compress: Allow modular (de)compression algorithms

2021-02-22 Thread Geert Uytterhoeven
Hi Yamada-san, On Tue, Feb 23, 2021 at 7:31 AM Masahiro Yamada wrote: > On Mon, Feb 22, 2021 at 9:59 PM Geert Uytterhoeven > wrote: > > If F2FS_FS is modular, enabling the compressions options > > F2FS_FS_{LZ4,LZ4HZ,LZO,LZORLE,ZSTD} will make the (de)compression > > algorithms

Re: [PATCH] f2fs: compress: Allow modular (de)compression algorithms

2021-02-22 Thread Masahiro Yamada
On Mon, Feb 22, 2021 at 9:59 PM Geert Uytterhoeven wrote: > > If F2FS_FS is modular, enabling the compressions options > F2FS_FS_{LZ4,LZ4HZ,LZO,LZORLE,ZSTD} will make the (de)compression > algorithms {LZ4,LZ4HC,LZO,ZSTD}_{,DE}COMPRESS builtin instead of > modular, as the former depend on an

[PATCH] f2fs: compress: Allow modular (de)compression algorithms

2021-02-22 Thread Geert Uytterhoeven
If F2FS_FS is modular, enabling the compressions options F2FS_FS_{LZ4,LZ4HZ,LZO,LZORLE,ZSTD} will make the (de)compression algorithms {LZ4,LZ4HC,LZO,ZSTD}_{,DE}COMPRESS builtin instead of modular, as the former depend on an intermediate boolean F2FS_FS_COMPRESSION, which in-turn depends on