Re: [PATCH] f2fs: fix to redirty page if fail to gc data page

On Fri, Jun 03, 2016 at 01:59:15PM +0800, Chao Yu wrote: ... > >>> Do we have another expectation? > >> > >> ENOMEM or EIO? > > > > EIO will stop everything. > > ENOMEM would be better to wait for a while from page reclaim? > > Agree, but for ioctl path, IMO, we don't need to let user waiting

Re: [PATCH] f2fs: fix to redirty page if fail to gc data page

On Fri, Jun 03, 2016 at 01:59:15PM +0800, Chao Yu wrote: ... > >>> Do we have another expectation? > >> > >> ENOMEM or EIO? > > > > EIO will stop everything. > > ENOMEM would be better to wait for a while from page reclaim? > > Agree, but for ioctl path, IMO, we don't need to let user waiting

Re: [PATCH] f2fs: fix to redirty page if fail to gc data page

On 2016/6/3 13:17, Jaegeuk Kim wrote: > On Fri, Jun 03, 2016 at 01:13:21PM +0800, Chao Yu wrote: >> On 2016/6/3 13:08, Jaegeuk Kim wrote: >>> On Tue, May 31, 2016 at 02:10:50PM +0800, Chao Yu wrote: Hi Jaegeuk, On 2016/5/30 10:37, Jaegeuk Kim wrote: > Hi Chao, > > On

Re: [PATCH] f2fs: fix to redirty page if fail to gc data page

On 2016/6/3 13:17, Jaegeuk Kim wrote: > On Fri, Jun 03, 2016 at 01:13:21PM +0800, Chao Yu wrote: >> On 2016/6/3 13:08, Jaegeuk Kim wrote: >>> On Tue, May 31, 2016 at 02:10:50PM +0800, Chao Yu wrote: Hi Jaegeuk, On 2016/5/30 10:37, Jaegeuk Kim wrote: > Hi Chao, > > On

Re: [PATCH] f2fs: fix to redirty page if fail to gc data page

On Fri, Jun 03, 2016 at 01:13:21PM +0800, Chao Yu wrote: > On 2016/6/3 13:08, Jaegeuk Kim wrote: > > On Tue, May 31, 2016 at 02:10:50PM +0800, Chao Yu wrote: > >> Hi Jaegeuk, > >> > >> On 2016/5/30 10:37, Jaegeuk Kim wrote: > >>> Hi Chao, > >>> > >>> On Sat, May 21, 2016 at 01:19:11PM +0800, Chao

Re: [PATCH] f2fs: fix to redirty page if fail to gc data page

On Fri, Jun 03, 2016 at 01:13:21PM +0800, Chao Yu wrote: > On 2016/6/3 13:08, Jaegeuk Kim wrote: > > On Tue, May 31, 2016 at 02:10:50PM +0800, Chao Yu wrote: > >> Hi Jaegeuk, > >> > >> On 2016/5/30 10:37, Jaegeuk Kim wrote: > >>> Hi Chao, > >>> > >>> On Sat, May 21, 2016 at 01:19:11PM +0800, Chao

Re: [PATCH] f2fs: fix to redirty page if fail to gc data page

On 2016/6/3 13:08, Jaegeuk Kim wrote: > On Tue, May 31, 2016 at 02:10:50PM +0800, Chao Yu wrote: >> Hi Jaegeuk, >> >> On 2016/5/30 10:37, Jaegeuk Kim wrote: >>> Hi Chao, >>> >>> On Sat, May 21, 2016 at 01:19:11PM +0800, Chao Yu wrote: From: Chao Yu If we fail to

Re: [PATCH] f2fs: fix to redirty page if fail to gc data page

On 2016/6/3 13:08, Jaegeuk Kim wrote: > On Tue, May 31, 2016 at 02:10:50PM +0800, Chao Yu wrote: >> Hi Jaegeuk, >> >> On 2016/5/30 10:37, Jaegeuk Kim wrote: >>> Hi Chao, >>> >>> On Sat, May 21, 2016 at 01:19:11PM +0800, Chao Yu wrote: From: Chao Yu If we fail to move data page

Re: [PATCH] f2fs: fix to redirty page if fail to gc data page

On Tue, May 31, 2016 at 02:10:50PM +0800, Chao Yu wrote: > Hi Jaegeuk, > > On 2016/5/30 10:37, Jaegeuk Kim wrote: > > Hi Chao, > > > > On Sat, May 21, 2016 at 01:19:11PM +0800, Chao Yu wrote: > >> From: Chao Yu > >> > >> If we fail to move data page during foreground GC, we

Re: [PATCH] f2fs: fix to redirty page if fail to gc data page

On Tue, May 31, 2016 at 02:10:50PM +0800, Chao Yu wrote: > Hi Jaegeuk, > > On 2016/5/30 10:37, Jaegeuk Kim wrote: > > Hi Chao, > > > > On Sat, May 21, 2016 at 01:19:11PM +0800, Chao Yu wrote: > >> From: Chao Yu > >> > >> If we fail to move data page during foreground GC, we should give another

Re: [PATCH] f2fs: fix to redirty page if fail to gc data page

Hi Jaegeuk, On 2016/5/30 10:37, Jaegeuk Kim wrote: > Hi Chao, > > On Sat, May 21, 2016 at 01:19:11PM +0800, Chao Yu wrote: >> From: Chao Yu >> >> If we fail to move data page during foreground GC, we should give another >> chance to writeback that page which was set dirty

Re: [PATCH] f2fs: fix to redirty page if fail to gc data page

Hi Jaegeuk, On 2016/5/30 10:37, Jaegeuk Kim wrote: > Hi Chao, > > On Sat, May 21, 2016 at 01:19:11PM +0800, Chao Yu wrote: >> From: Chao Yu >> >> If we fail to move data page during foreground GC, we should give another >> chance to writeback that page which was set dirty previously by writer.

Re: [PATCH] f2fs: fix to redirty page if fail to gc data page

Hi Chao, On Sat, May 21, 2016 at 01:19:11PM +0800, Chao Yu wrote: > From: Chao Yu > > If we fail to move data page during foreground GC, we should give another > chance to writeback that page which was set dirty previously by writer. > > Signed-off-by: Chao Yu

Re: [PATCH] f2fs: fix to redirty page if fail to gc data page

Hi Chao, On Sat, May 21, 2016 at 01:19:11PM +0800, Chao Yu wrote: > From: Chao Yu > > If we fail to move data page during foreground GC, we should give another > chance to writeback that page which was set dirty previously by writer. > > Signed-off-by: Chao Yu > --- > fs/f2fs/gc.c | 5 -

Re: [PATCH] f2fs: fix to redirty page if fail to gc data page

Ping, On 2016/5/21 13:19, Chao Yu wrote: > From: Chao Yu > > If we fail to move data page during foreground GC, we should give another > chance to writeback that page which was set dirty previously by writer. > > Signed-off-by: Chao Yu > --- >

Re: [PATCH] f2fs: fix to redirty page if fail to gc data page

Ping, On 2016/5/21 13:19, Chao Yu wrote: > From: Chao Yu > > If we fail to move data page during foreground GC, we should give another > chance to writeback that page which was set dirty previously by writer. > > Signed-off-by: Chao Yu > --- > fs/f2fs/gc.c | 5 - > 1 file changed, 4

[PATCH] f2fs: fix to redirty page if fail to gc data page

From: Chao Yu If we fail to move data page during foreground GC, we should give another chance to writeback that page which was set dirty previously by writer. Signed-off-by: Chao Yu --- fs/f2fs/gc.c | 5 - 1 file changed, 4 insertions(+), 1

[PATCH] f2fs: fix to redirty page if fail to gc data page

From: Chao Yu If we fail to move data page during foreground GC, we should give another chance to writeback that page which was set dirty previously by writer. Signed-off-by: Chao Yu --- fs/f2fs/gc.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/fs/f2fs/gc.c