RE: [PATCH] f2fs: fix to truncate inline data past EOF

2015-03-09 Thread Chao Yu
Hi Jaegeuk, > -Original Message- > From: Jaegeuk Kim [mailto:jaeg...@kernel.org] > Sent: Tuesday, March 10, 2015 11:00 AM > To: Chao Yu > Cc: 'Changman Lee'; linux-f2fs-de...@lists.sourceforge.net; > linux-kernel@vger.kernel.org > Subject: Re: [PATCH] f2

Re: [PATCH] f2fs: fix to truncate inline data past EOF

2015-03-09 Thread Jaegeuk Kim
Hi Chao, On Tue, Mar 10, 2015 at 10:02:46AM +0800, Chao Yu wrote: > Hi Jaegeuk, > [snip] > > > > +static int truncate_partial_data_page(struct inode *inode, u64 from, > > > > bool force) > > > > { > > > > unsigned offset = from & (PAGE_CACHE_SIZE - 1); > > > > struct page *pag

RE: [PATCH] f2fs: fix to truncate inline data past EOF

2015-03-09 Thread Chao Yu
March 09, 2015 11:49 AM > > > To: Chao Yu > > > Cc: 'Changman Lee'; linux-f2fs-de...@lists.sourceforge.net; > > > linux-kernel@vger.kernel.org > > > Subject: Re: [PATCH] f2fs: fix to truncate inline data past EOF > > > > > > Hi Chao, > >

Re: [PATCH] f2fs: fix to truncate inline data past EOF

2015-03-09 Thread Jaegeuk Kim
x-f2fs-de...@lists.sourceforge.net; > > linux-kernel@vger.kernel.org > > Subject: Re: [PATCH] f2fs: fix to truncate inline data past EOF > > > > Hi Chao, > > > > > > On Mon, Mar 09, 2015 at 10:24:35AM +0800, Chao Yu wrote: > > > Hi Jaege

RE: [PATCH] f2fs: fix to truncate inline data past EOF

2015-03-09 Thread Chao Yu
riday, March 06, 2015 5:34 AM > > > To: Chao Yu > > > Cc: Changman Lee; linux-f2fs-de...@lists.sourceforge.net; > > > linux-kernel@vger.kernel.org > > > Subject: Re: [PATCH] f2fs: fix to truncate inline data past EOF > > > > > > Hi Chao, > >

Re: [PATCH] f2fs: fix to truncate inline data past EOF

2015-03-08 Thread Jaegeuk Kim
..@lists.sourceforge.net; > > linux-kernel@vger.kernel.org > > Subject: Re: [PATCH] f2fs: fix to truncate inline data past EOF > > > > Hi Chao, > > > > On Thu, Mar 05, 2015 at 05:41:32PM +0800, Chao Yu wrote: > > > Previously if inode is with inline

RE: [PATCH] f2fs: fix to truncate inline data past EOF

2015-03-08 Thread Chao Yu
#0 page, sorry for the mistake. > How about checking its cached page after on-disk truncation? > > 1. page = get_node_page() > 2. check_inline > 3. truncate_inline_inode > 4. f2fs_put_page(ipage) > > 5. truncate_partial_data_page(inode, from, force) > if (

Re: [PATCH] f2fs: fix to truncate inline data past EOF

2015-03-05 Thread Jaegeuk Kim
Hi Chao, On Thu, Mar 05, 2015 at 05:41:32PM +0800, Chao Yu wrote: > Previously if inode is with inline data, we will try to invalid partial inline > data in page #0 when we truncate size of inode in > truncate_partial_data_page(). > And then we set page #0 to dirty, after this we can synchronize

[PATCH] f2fs: fix to truncate inline data past EOF

2015-03-05 Thread Chao Yu
Previously if inode is with inline data, we will try to invalid partial inline data in page #0 when we truncate size of inode in truncate_partial_data_page(). And then we set page #0 to dirty, after this we can synchronize inode page with page #0 at ->writepage(). But sometimes we will fail to ope