Re: [PATCH] f2fs: fix up f2fs_get_parent issue to retrieve correct parent inode number

2012-12-12 Thread Jaegeuk Kim
2012-12-13 (목), 07:44 +0900, Namjae Jeon: > 2012/12/13, Leon Romanovsky : > > On Wed, Dec 12, 2012 at 8:50 AM, Fubo Chen wrote: > >> On Wed, Dec 12, 2012 at 5:12 PM, Leon Romanovsky wrote: > >>> On Wed, Dec 12, 2012 at 7:05 AM, Fubo Chen wrote: > > On Wed, Dec 12, 2012 at 3:37 PM,

Re: [PATCH] f2fs: fix up f2fs_get_parent issue to retrieve correct parent inode number

2012-12-12 Thread Namjae Jeon
2012/12/13, Leon Romanovsky : > On Wed, Dec 12, 2012 at 8:50 AM, Fubo Chen wrote: >> On Wed, Dec 12, 2012 at 5:12 PM, Leon Romanovsky wrote: >>> On Wed, Dec 12, 2012 at 7:05 AM, Fubo Chen wrote: On Wed, Dec 12, 2012 at 3:37 PM, Namjae Jeon wrote: > + /* dot and dotdot

Re: [PATCH] f2fs: fix up f2fs_get_parent issue to retrieve correct parent inode number

2012-12-12 Thread Leon Romanovsky
On Wed, Dec 12, 2012 at 8:50 AM, Fubo Chen wrote: > On Wed, Dec 12, 2012 at 5:12 PM, Leon Romanovsky wrote: >> On Wed, Dec 12, 2012 at 7:05 AM, Fubo Chen wrote: >>> >>> On Wed, Dec 12, 2012 at 3:37 PM, Namjae Jeon wrote: >>> > + /* dot and dotdot dentries should have zero-value hash code

Re: [PATCH] f2fs: fix up f2fs_get_parent issue to retrieve correct parent inode number

2012-12-12 Thread Fubo Chen
On Wed, Dec 12, 2012 at 5:12 PM, Leon Romanovsky wrote: > On Wed, Dec 12, 2012 at 7:05 AM, Fubo Chen wrote: >> >> On Wed, Dec 12, 2012 at 3:37 PM, Namjae Jeon wrote: >> > + /* dot and dotdot dentries should have zero-value hash code */ >> > + if (!memcmp(name, ".", 1) ||

Re: [PATCH] f2fs: fix up f2fs_get_parent issue to retrieve correct parent inode number

2012-12-12 Thread Leon Romanovsky
On Wed, Dec 12, 2012 at 7:05 AM, Fubo Chen wrote: > > On Wed, Dec 12, 2012 at 3:37 PM, Namjae Jeon wrote: > > + /* dot and dotdot dentries should have zero-value hash code */ > > + if (!memcmp(name, ".", 1) || !memcmp(name, "..", 2)) > > + return 0; > > That looks

Re: [PATCH] f2fs: fix up f2fs_get_parent issue to retrieve correct parent inode number

2012-12-12 Thread Fubo Chen
On Wed, Dec 12, 2012 at 3:37 PM, Namjae Jeon wrote: > + /* dot and dotdot dentries should have zero-value hash code */ > + if (!memcmp(name, ".", 1) || !memcmp(name, "..", 2)) > + return 0; That looks suspicious. If memcmp(name, "..", 2) == 0 then always memcmp(name,

[PATCH] f2fs: fix up f2fs_get_parent issue to retrieve correct parent inode number

2012-12-12 Thread Namjae Jeon
From: Namjae Jeon Test Case: [NFS Client] ls -lR . [NFS Server] while [ 1 ] do echo 3 > /proc/sys/vm/drop_caches done Error on NFS Client: "No such file or directory" When cache is dropped at the server, it results in lookup failure at the NFS client due to non-connection with the parent. The

[PATCH] f2fs: fix up f2fs_get_parent issue to retrieve correct parent inode number

2012-12-12 Thread Namjae Jeon
From: Namjae Jeon namjae.j...@samsung.com Test Case: [NFS Client] ls -lR . [NFS Server] while [ 1 ] do echo 3 /proc/sys/vm/drop_caches done Error on NFS Client: No such file or directory When cache is dropped at the server, it results in lookup failure at the NFS client due to non-connection

Re: [PATCH] f2fs: fix up f2fs_get_parent issue to retrieve correct parent inode number

2012-12-12 Thread Fubo Chen
On Wed, Dec 12, 2012 at 3:37 PM, Namjae Jeon linkinj...@gmail.com wrote: + /* dot and dotdot dentries should have zero-value hash code */ + if (!memcmp(name, ., 1) || !memcmp(name, .., 2)) + return 0; That looks suspicious. If memcmp(name, .., 2) == 0 then always

Re: [PATCH] f2fs: fix up f2fs_get_parent issue to retrieve correct parent inode number

2012-12-12 Thread Leon Romanovsky
On Wed, Dec 12, 2012 at 7:05 AM, Fubo Chen fubo.c...@gmail.com wrote: On Wed, Dec 12, 2012 at 3:37 PM, Namjae Jeon linkinj...@gmail.com wrote: + /* dot and dotdot dentries should have zero-value hash code */ + if (!memcmp(name, ., 1) || !memcmp(name, .., 2)) +

Re: [PATCH] f2fs: fix up f2fs_get_parent issue to retrieve correct parent inode number

2012-12-12 Thread Fubo Chen
On Wed, Dec 12, 2012 at 5:12 PM, Leon Romanovsky l...@leon.nu wrote: On Wed, Dec 12, 2012 at 7:05 AM, Fubo Chen fubo.c...@gmail.com wrote: On Wed, Dec 12, 2012 at 3:37 PM, Namjae Jeon linkinj...@gmail.com wrote: + /* dot and dotdot dentries should have zero-value hash code */ +

Re: [PATCH] f2fs: fix up f2fs_get_parent issue to retrieve correct parent inode number

2012-12-12 Thread Leon Romanovsky
On Wed, Dec 12, 2012 at 8:50 AM, Fubo Chen fubo.c...@gmail.com wrote: On Wed, Dec 12, 2012 at 5:12 PM, Leon Romanovsky l...@leon.nu wrote: On Wed, Dec 12, 2012 at 7:05 AM, Fubo Chen fubo.c...@gmail.com wrote: On Wed, Dec 12, 2012 at 3:37 PM, Namjae Jeon linkinj...@gmail.com wrote: + /*

Re: [PATCH] f2fs: fix up f2fs_get_parent issue to retrieve correct parent inode number

2012-12-12 Thread Namjae Jeon
2012/12/13, Leon Romanovsky l...@leon.nu: On Wed, Dec 12, 2012 at 8:50 AM, Fubo Chen fubo.c...@gmail.com wrote: On Wed, Dec 12, 2012 at 5:12 PM, Leon Romanovsky l...@leon.nu wrote: On Wed, Dec 12, 2012 at 7:05 AM, Fubo Chen fubo.c...@gmail.com wrote: On Wed, Dec 12, 2012 at 3:37 PM, Namjae

Re: [PATCH] f2fs: fix up f2fs_get_parent issue to retrieve correct parent inode number

2012-12-12 Thread Jaegeuk Kim
2012-12-13 (목), 07:44 +0900, Namjae Jeon: 2012/12/13, Leon Romanovsky l...@leon.nu: On Wed, Dec 12, 2012 at 8:50 AM, Fubo Chen fubo.c...@gmail.com wrote: On Wed, Dec 12, 2012 at 5:12 PM, Leon Romanovsky l...@leon.nu wrote: On Wed, Dec 12, 2012 at 7:05 AM, Fubo Chen fubo.c...@gmail.com

Re: [PATCH] f2fs: fix up f2fs_get_parent issue to retrieve correct parent inode number

2012-12-11 Thread Namjae Jeon
2012/12/12, Jaegeuk Kim : > 2012-12-12 (수), 00:10 +0900, Namjae Jeon: >> From: Namjae Jeon >> >> Test Case: >> [NFS Client] >> ls -lR . >> >> [NFS Server] >> while [ 1 ] >> do >> echo 3 > /proc/sys/vm/drop_caches >> done >> >> Error on NFS Client: "No such file or directory" >> >> When cache is

Re: [PATCH] f2fs: fix up f2fs_get_parent issue to retrieve correct parent inode number

2012-12-11 Thread Jaegeuk Kim
2012-12-12 (수), 00:10 +0900, Namjae Jeon: > From: Namjae Jeon > > Test Case: > [NFS Client] > ls -lR . > > [NFS Server] > while [ 1 ] > do > echo 3 > /proc/sys/vm/drop_caches > done > > Error on NFS Client: "No such file or directory" > > When cache is dropped at the server, it results in

[PATCH] f2fs: fix up f2fs_get_parent issue to retrieve correct parent inode number

2012-12-11 Thread Namjae Jeon
From: Namjae Jeon Test Case: [NFS Client] ls -lR . [NFS Server] while [ 1 ] do echo 3 > /proc/sys/vm/drop_caches done Error on NFS Client: "No such file or directory" When cache is dropped at the server, it results in lookup failure at the NFS client due to non-connection with the parent. The

[PATCH] f2fs: fix up f2fs_get_parent issue to retrieve correct parent inode number

2012-12-11 Thread Namjae Jeon
From: Namjae Jeon namjae.j...@samsung.com Test Case: [NFS Client] ls -lR . [NFS Server] while [ 1 ] do echo 3 /proc/sys/vm/drop_caches done Error on NFS Client: No such file or directory When cache is dropped at the server, it results in lookup failure at the NFS client due to non-connection

Re: [PATCH] f2fs: fix up f2fs_get_parent issue to retrieve correct parent inode number

2012-12-11 Thread Jaegeuk Kim
2012-12-12 (수), 00:10 +0900, Namjae Jeon: From: Namjae Jeon namjae.j...@samsung.com Test Case: [NFS Client] ls -lR . [NFS Server] while [ 1 ] do echo 3 /proc/sys/vm/drop_caches done Error on NFS Client: No such file or directory When cache is dropped at the server, it results

Re: [PATCH] f2fs: fix up f2fs_get_parent issue to retrieve correct parent inode number

2012-12-11 Thread Namjae Jeon
2012/12/12, Jaegeuk Kim jaegeuk@samsung.com: 2012-12-12 (수), 00:10 +0900, Namjae Jeon: From: Namjae Jeon namjae.j...@samsung.com Test Case: [NFS Client] ls -lR . [NFS Server] while [ 1 ] do echo 3 /proc/sys/vm/drop_caches done Error on NFS Client: No such file or directory