Re: [PATCH] fat: Fix oops on corrupted vfat fs

2014-11-26 Thread OGAWA Hirofumi
Andrew Morton writes: > On Thu, 27 Nov 2014 00:31:28 +0900 OGAWA Hirofumi > wrote: > >> a) don't bother with ->d_time for positives - we only check it for negatives >> anyway. >> b) make sure to set it at unlink and rmdir time - at *that* point soon-to-be >> negative dentry matches

Re: [PATCH] fat: Fix oops on corrupted vfat fs

2014-11-26 Thread Andrew Morton
On Thu, 27 Nov 2014 00:31:28 +0900 OGAWA Hirofumi wrote: > a) don't bother with ->d_time for positives - we only check it for negatives > anyway. > b) make sure to set it at unlink and rmdir time - at *that* point soon-to-be > negative dentry matches then-current directory contents > c) don't

[PATCH] fat: Fix oops on corrupted vfat fs

2014-11-26 Thread OGAWA Hirofumi
a) don't bother with ->d_time for positives - we only check it for negatives anyway. b) make sure to set it at unlink and rmdir time - at *that* point soon-to-be negative dentry matches then-current directory contents c) don't go into renaming of old alias in vfat_lookup() unless it has the same

[PATCH] fat: Fix oops on corrupted vfat fs

2014-11-26 Thread OGAWA Hirofumi
a) don't bother with -d_time for positives - we only check it for negatives anyway. b) make sure to set it at unlink and rmdir time - at *that* point soon-to-be negative dentry matches then-current directory contents c) don't go into renaming of old alias in vfat_lookup() unless it has the same

Re: [PATCH] fat: Fix oops on corrupted vfat fs

2014-11-26 Thread Andrew Morton
On Thu, 27 Nov 2014 00:31:28 +0900 OGAWA Hirofumi hirof...@mail.parknet.co.jp wrote: a) don't bother with -d_time for positives - we only check it for negatives anyway. b) make sure to set it at unlink and rmdir time - at *that* point soon-to-be negative dentry matches then-current directory

Re: [PATCH] fat: Fix oops on corrupted vfat fs

2014-11-26 Thread OGAWA Hirofumi
Andrew Morton a...@linux-foundation.org writes: On Thu, 27 Nov 2014 00:31:28 +0900 OGAWA Hirofumi hirof...@mail.parknet.co.jp wrote: a) don't bother with -d_time for positives - we only check it for negatives anyway. b) make sure to set it at unlink and rmdir time - at *that* point