Re: [PATCH] fbdev: broadsheetfb: fix memory leak

2015-09-25 Thread Sudip Mukherjee
On Thu, Sep 24, 2015 at 01:12:48PM +0300, Tomi Valkeinen wrote: > > On 18/09/15 14:16, Sudip Mukherjee wrote: > > On the error path we have missed releasing the firmware. > > > > Signed-off-by: Sudip Mukherjee > > --- > > This looks like correct fix, but where is the firmware released when >

Re: [PATCH] fbdev: broadsheetfb: fix memory leak

2015-09-25 Thread Sudip Mukherjee
On Thu, Sep 24, 2015 at 01:12:48PM +0300, Tomi Valkeinen wrote: > > On 18/09/15 14:16, Sudip Mukherjee wrote: > > On the error path we have missed releasing the firmware. > > > > Signed-off-by: Sudip Mukherjee > > --- > > This looks like correct fix, but where is the

Re: [PATCH] fbdev: broadsheetfb: fix memory leak

2015-09-24 Thread Tomi Valkeinen
On 18/09/15 14:16, Sudip Mukherjee wrote: > On the error path we have missed releasing the firmware. > > Signed-off-by: Sudip Mukherjee > --- > drivers/video/fbdev/broadsheetfb.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/video/fbdev/broadsheetfb.c

Re: [PATCH] fbdev: broadsheetfb: fix memory leak

2015-09-24 Thread Tomi Valkeinen
On 18/09/15 14:16, Sudip Mukherjee wrote: > On the error path we have missed releasing the firmware. > > Signed-off-by: Sudip Mukherjee > --- > drivers/video/fbdev/broadsheetfb.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git

[PATCH] fbdev: broadsheetfb: fix memory leak

2015-09-18 Thread Sudip Mukherjee
On the error path we have missed releasing the firmware. Signed-off-by: Sudip Mukherjee --- drivers/video/fbdev/broadsheetfb.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/video/fbdev/broadsheetfb.c b/drivers/video/fbdev/broadsheetfb.c index

[PATCH] fbdev: broadsheetfb: fix memory leak

2015-09-18 Thread Sudip Mukherjee
On the error path we have missed releasing the firmware. Signed-off-by: Sudip Mukherjee --- drivers/video/fbdev/broadsheetfb.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/video/fbdev/broadsheetfb.c