Re: [PATCH] fbdev: geocode: Add the missed pci_disable_device() for gx1fb_map_video_memory()

2020-06-04 Thread Pekka Paalanen
On Wed, 3 Jun 2020 17:25:47 +0800 Chuhong Yuan wrote: > Although gx1fb_probe() has handled the failure of gx1fb_map_video_memory() > partly, it does not call pci_disable_device() as gx1fb_map_video_memory() > calls pci_enable_device(). > Add the missed function call to fix the bug. > > Fixes:

Re: [PATCH] fbdev: geocode: Add the missed pci_disable_device() in gx1fb_map_video_memory()

2020-06-03 Thread Markus Elfring
> Add the missed function call to fix the bug. … > +++ b/drivers/video/fbdev/geode/gx1fb_core.c > @@ -208,29 +208,44 @@ static int gx1fb_map_video_memory(struct fb_info > *info, struct pci_dev *dev) … > return 0; > + > +err: > + pci_disable_device(dev); > + return ret; > } … I

[PATCH] fbdev: geocode: Add the missed pci_disable_device() for gx1fb_map_video_memory()

2020-06-03 Thread Chuhong Yuan
Although gx1fb_probe() has handled the failure of gx1fb_map_video_memory() partly, it does not call pci_disable_device() as gx1fb_map_video_memory() calls pci_enable_device(). Add the missed function call to fix the bug. Fixes: 53eed4ec8bcd ("[PATCH] fbdev: geode updates]") Signed-off-by: Chuhong