Re: [PATCH] fence: Use smp_mb__before_atomic()

2014-06-05 Thread Rob Clark
On Thu, Jun 5, 2014 at 11:48 AM, Greg Kroah-Hartman wrote: > On Thu, Jun 05, 2014 at 07:51:10AM -0400, Rob Clark wrote: >> On Wed, Jun 4, 2014 at 1:49 PM, Greg Kroah-Hartman >> wrote: >> > On Wed, Jun 04, 2014 at 03:28:33PM +0200, Thierry Reding wrote: >> >> On Wed, Jun 04, 2014 at 04:57:07PM

Re: [PATCH] fence: Use smp_mb__before_atomic()

2014-06-05 Thread Greg Kroah-Hartman
On Thu, Jun 05, 2014 at 10:09:29PM +0530, Sumit Semwal wrote: > Hi Greg, > > On 5 June 2014 21:18, Greg Kroah-Hartman wrote: > >> > But again, why is the fence.c code needed at all anyway? I'm not sold > >> > on that. > >> > >> Fence serves as a way to synchronize between (for example) multiple

Re: [PATCH] fence: Use smp_mb__before_atomic()

2014-06-05 Thread Sumit Semwal
Hi Greg, On 5 June 2014 21:18, Greg Kroah-Hartman wrote: > On Thu, Jun 05, 2014 at 07:51:10AM -0400, Rob Clark wrote: >> On Wed, Jun 4, 2014 at 1:49 PM, Greg Kroah-Hartman >> wrote: >> > On Wed, Jun 04, 2014 at 03:28:33PM +0200, Thierry Reding wrote: >> >> On Wed, Jun 04, 2014 at 04:57:07PM

Re: [PATCH] fence: Use smp_mb__before_atomic()

2014-06-05 Thread Greg Kroah-Hartman
On Thu, Jun 05, 2014 at 02:00:16PM +0200, Maarten Lankhorst wrote: > >I don't think the question about whether we need something like fence > >to augment dma-buf is really in doubt. Maybe it should live somewhere > >else, I'm not sure. But it makes sense for it to live wherever > >dma-buf does,

Re: [PATCH] fence: Use smp_mb__before_atomic()

2014-06-05 Thread Greg Kroah-Hartman
On Thu, Jun 05, 2014 at 05:56:36PM +0530, Sumit Semwal wrote: > Hi Greg, > Pending agreement on the need of fence.c (Rob has given the most > prominent use case for it, and the lack of existing mechanisms to use > already), See my disagreement there :) > would you be ok if I move all the

Re: [PATCH] fence: Use smp_mb__before_atomic()

2014-06-05 Thread Greg Kroah-Hartman
On Thu, Jun 05, 2014 at 07:51:10AM -0400, Rob Clark wrote: > On Wed, Jun 4, 2014 at 1:49 PM, Greg Kroah-Hartman > wrote: > > On Wed, Jun 04, 2014 at 03:28:33PM +0200, Thierry Reding wrote: > >> On Wed, Jun 04, 2014 at 04:57:07PM +0530, Sumit Semwal wrote: > >> > Hi Greg, > >> > > >> > > >> > On

Re: [PATCH] fence: Use smp_mb__before_atomic()

2014-06-05 Thread Sumit Semwal
Hi Greg, On 5 June 2014 17:21, Rob Clark wrote: > On Wed, Jun 4, 2014 at 1:49 PM, Greg Kroah-Hartman > wrote: >> On Wed, Jun 04, 2014 at 03:28:33PM +0200, Thierry Reding wrote: >>> On Wed, Jun 04, 2014 at 04:57:07PM +0530, Sumit Semwal wrote: >>> > Hi Greg, >>> > >>> > >>> > On 30 May 2014

Re: [PATCH] fence: Use smp_mb__before_atomic()

2014-06-05 Thread Maarten Lankhorst
op 05-06-14 13:51, Rob Clark schreef: On Wed, Jun 4, 2014 at 1:49 PM, Greg Kroah-Hartman wrote: On Wed, Jun 04, 2014 at 03:28:33PM +0200, Thierry Reding wrote: On Wed, Jun 04, 2014 at 04:57:07PM +0530, Sumit Semwal wrote: Hi Greg, On 30 May 2014 21:38, Greg Kroah-Hartman wrote: On Fri,

Re: [PATCH] fence: Use smp_mb__before_atomic()

2014-06-05 Thread Rob Clark
On Wed, Jun 4, 2014 at 1:49 PM, Greg Kroah-Hartman wrote: > On Wed, Jun 04, 2014 at 03:28:33PM +0200, Thierry Reding wrote: >> On Wed, Jun 04, 2014 at 04:57:07PM +0530, Sumit Semwal wrote: >> > Hi Greg, >> > >> > >> > On 30 May 2014 21:38, Greg Kroah-Hartman >> > wrote: >> > > On Fri, May 30,

Re: [PATCH] fence: Use smp_mb__before_atomic()

2014-06-05 Thread Rob Clark
On Wed, Jun 4, 2014 at 1:49 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Wed, Jun 04, 2014 at 03:28:33PM +0200, Thierry Reding wrote: On Wed, Jun 04, 2014 at 04:57:07PM +0530, Sumit Semwal wrote: Hi Greg, On 30 May 2014 21:38, Greg Kroah-Hartman gre...@linuxfoundation.org

Re: [PATCH] fence: Use smp_mb__before_atomic()

2014-06-05 Thread Maarten Lankhorst
op 05-06-14 13:51, Rob Clark schreef: On Wed, Jun 4, 2014 at 1:49 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Wed, Jun 04, 2014 at 03:28:33PM +0200, Thierry Reding wrote: On Wed, Jun 04, 2014 at 04:57:07PM +0530, Sumit Semwal wrote: Hi Greg, On 30 May 2014 21:38, Greg

Re: [PATCH] fence: Use smp_mb__before_atomic()

2014-06-05 Thread Sumit Semwal
Hi Greg, On 5 June 2014 17:21, Rob Clark robdcl...@gmail.com wrote: On Wed, Jun 4, 2014 at 1:49 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Wed, Jun 04, 2014 at 03:28:33PM +0200, Thierry Reding wrote: On Wed, Jun 04, 2014 at 04:57:07PM +0530, Sumit Semwal wrote: Hi Greg,

Re: [PATCH] fence: Use smp_mb__before_atomic()

2014-06-05 Thread Greg Kroah-Hartman
On Thu, Jun 05, 2014 at 07:51:10AM -0400, Rob Clark wrote: On Wed, Jun 4, 2014 at 1:49 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Wed, Jun 04, 2014 at 03:28:33PM +0200, Thierry Reding wrote: On Wed, Jun 04, 2014 at 04:57:07PM +0530, Sumit Semwal wrote: Hi Greg,

Re: [PATCH] fence: Use smp_mb__before_atomic()

2014-06-05 Thread Greg Kroah-Hartman
On Thu, Jun 05, 2014 at 05:56:36PM +0530, Sumit Semwal wrote: Hi Greg, Pending agreement on the need of fence.c (Rob has given the most prominent use case for it, and the lack of existing mechanisms to use already), See my disagreement there :) would you be ok if I move all the dma-buf* and

Re: [PATCH] fence: Use smp_mb__before_atomic()

2014-06-05 Thread Greg Kroah-Hartman
On Thu, Jun 05, 2014 at 02:00:16PM +0200, Maarten Lankhorst wrote: I don't think the question about whether we need something like fence to augment dma-buf is really in doubt. Maybe it should live somewhere else, I'm not sure. But it makes sense for it to live wherever dma-buf does, as they

Re: [PATCH] fence: Use smp_mb__before_atomic()

2014-06-05 Thread Sumit Semwal
Hi Greg, On 5 June 2014 21:18, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Thu, Jun 05, 2014 at 07:51:10AM -0400, Rob Clark wrote: On Wed, Jun 4, 2014 at 1:49 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Wed, Jun 04, 2014 at 03:28:33PM +0200, Thierry Reding wrote:

Re: [PATCH] fence: Use smp_mb__before_atomic()

2014-06-05 Thread Greg Kroah-Hartman
On Thu, Jun 05, 2014 at 10:09:29PM +0530, Sumit Semwal wrote: Hi Greg, On 5 June 2014 21:18, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: But again, why is the fence.c code needed at all anyway? I'm not sold on that. Fence serves as a way to synchronize between (for example)

Re: [PATCH] fence: Use smp_mb__before_atomic()

2014-06-05 Thread Rob Clark
On Thu, Jun 5, 2014 at 11:48 AM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Thu, Jun 05, 2014 at 07:51:10AM -0400, Rob Clark wrote: On Wed, Jun 4, 2014 at 1:49 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Wed, Jun 04, 2014 at 03:28:33PM +0200, Thierry Reding wrote:

Re: [PATCH] fence: Use smp_mb__before_atomic()

2014-06-04 Thread Greg Kroah-Hartman
On Wed, Jun 04, 2014 at 03:28:33PM +0200, Thierry Reding wrote: > On Wed, Jun 04, 2014 at 04:57:07PM +0530, Sumit Semwal wrote: > > Hi Greg, > > > > > > On 30 May 2014 21:38, Greg Kroah-Hartman wrote: > > > On Fri, May 30, 2014 at 10:15:05AM +0200, Thierry Reding wrote: > > >> On Wed, May 28,

Re: [PATCH] fence: Use smp_mb__before_atomic()

2014-06-04 Thread Greg Kroah-Hartman
On Wed, Jun 04, 2014 at 04:57:07PM +0530, Sumit Semwal wrote: > Hi Greg, > > > On 30 May 2014 21:38, Greg Kroah-Hartman wrote: > > On Fri, May 30, 2014 at 10:15:05AM +0200, Thierry Reding wrote: > >> On Wed, May 28, 2014 at 01:51:45PM -0700, Greg Kroah-Hartman wrote: > >> > On Wed, May 28, 2014

Re: [PATCH] fence: Use smp_mb__before_atomic()

2014-06-04 Thread Thierry Reding
On Wed, Jun 04, 2014 at 04:57:07PM +0530, Sumit Semwal wrote: > Hi Greg, > > > On 30 May 2014 21:38, Greg Kroah-Hartman wrote: > > On Fri, May 30, 2014 at 10:15:05AM +0200, Thierry Reding wrote: > >> On Wed, May 28, 2014 at 01:51:45PM -0700, Greg Kroah-Hartman wrote: > >> > On Wed, May 28, 2014

Re: [PATCH] fence: Use smp_mb__before_atomic()

2014-06-04 Thread Sumit Semwal
Hi Greg, On 30 May 2014 21:38, Greg Kroah-Hartman wrote: > On Fri, May 30, 2014 at 10:15:05AM +0200, Thierry Reding wrote: >> On Wed, May 28, 2014 at 01:51:45PM -0700, Greg Kroah-Hartman wrote: >> > On Wed, May 28, 2014 at 04:26:32PM +0200, Thierry Reding wrote: >> > > From: Thierry Reding >>

Re: [PATCH] fence: Use smp_mb__before_atomic()

2014-06-04 Thread Sumit Semwal
Hi Greg, On 30 May 2014 21:38, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Fri, May 30, 2014 at 10:15:05AM +0200, Thierry Reding wrote: On Wed, May 28, 2014 at 01:51:45PM -0700, Greg Kroah-Hartman wrote: On Wed, May 28, 2014 at 04:26:32PM +0200, Thierry Reding wrote: From:

Re: [PATCH] fence: Use smp_mb__before_atomic()

2014-06-04 Thread Thierry Reding
On Wed, Jun 04, 2014 at 04:57:07PM +0530, Sumit Semwal wrote: Hi Greg, On 30 May 2014 21:38, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Fri, May 30, 2014 at 10:15:05AM +0200, Thierry Reding wrote: On Wed, May 28, 2014 at 01:51:45PM -0700, Greg Kroah-Hartman wrote: On Wed,

Re: [PATCH] fence: Use smp_mb__before_atomic()

2014-06-04 Thread Greg Kroah-Hartman
On Wed, Jun 04, 2014 at 04:57:07PM +0530, Sumit Semwal wrote: Hi Greg, On 30 May 2014 21:38, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Fri, May 30, 2014 at 10:15:05AM +0200, Thierry Reding wrote: On Wed, May 28, 2014 at 01:51:45PM -0700, Greg Kroah-Hartman wrote: On Wed,

Re: [PATCH] fence: Use smp_mb__before_atomic()

2014-06-04 Thread Greg Kroah-Hartman
On Wed, Jun 04, 2014 at 03:28:33PM +0200, Thierry Reding wrote: On Wed, Jun 04, 2014 at 04:57:07PM +0530, Sumit Semwal wrote: Hi Greg, On 30 May 2014 21:38, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Fri, May 30, 2014 at 10:15:05AM +0200, Thierry Reding wrote: On Wed,

Re: [PATCH] fence: Use smp_mb__before_atomic()

2014-05-30 Thread Greg Kroah-Hartman
On Fri, May 30, 2014 at 10:15:05AM +0200, Thierry Reding wrote: > On Wed, May 28, 2014 at 01:51:45PM -0700, Greg Kroah-Hartman wrote: > > On Wed, May 28, 2014 at 04:26:32PM +0200, Thierry Reding wrote: > > > From: Thierry Reding > > > > > > Commit febdbfe8a91c (arch: Prepare for

Re: [PATCH] fence: Use smp_mb__before_atomic()

2014-05-30 Thread Thierry Reding
On Wed, May 28, 2014 at 01:51:45PM -0700, Greg Kroah-Hartman wrote: > On Wed, May 28, 2014 at 04:26:32PM +0200, Thierry Reding wrote: > > From: Thierry Reding > > > > Commit febdbfe8a91c (arch: Prepare for smp_mb__{before,after}_atomic()) > > deprecated the

Re: [PATCH] fence: Use smp_mb__before_atomic()

2014-05-30 Thread Thierry Reding
On Wed, May 28, 2014 at 01:51:45PM -0700, Greg Kroah-Hartman wrote: On Wed, May 28, 2014 at 04:26:32PM +0200, Thierry Reding wrote: From: Thierry Reding tred...@nvidia.com Commit febdbfe8a91c (arch: Prepare for smp_mb__{before,after}_atomic()) deprecated the

Re: [PATCH] fence: Use smp_mb__before_atomic()

2014-05-30 Thread Greg Kroah-Hartman
On Fri, May 30, 2014 at 10:15:05AM +0200, Thierry Reding wrote: On Wed, May 28, 2014 at 01:51:45PM -0700, Greg Kroah-Hartman wrote: On Wed, May 28, 2014 at 04:26:32PM +0200, Thierry Reding wrote: From: Thierry Reding tred...@nvidia.com Commit febdbfe8a91c (arch: Prepare for

Re: [PATCH] fence: Use smp_mb__before_atomic()

2014-05-28 Thread Greg Kroah-Hartman
On Wed, May 28, 2014 at 04:26:32PM +0200, Thierry Reding wrote: > From: Thierry Reding > > Commit febdbfe8a91c (arch: Prepare for smp_mb__{before,after}_atomic()) > deprecated the smp_mb__{before,after}_{atomic,clear}_{dec,inc,bit}*() > functions in favour of the unified

Re: [PATCH] fence: Use smp_mb__before_atomic()

2014-05-28 Thread Maarten Lankhorst
On 28-05-14 16:26, Thierry Reding wrote: From: Thierry Reding Commit febdbfe8a91c (arch: Prepare for smp_mb__{before,after}_atomic()) deprecated the smp_mb__{before,after}_{atomic,clear}_{dec,inc,bit}*() functions in favour of the unified smp_mb__{before,after}_atomic(). Signed-off-by:

[PATCH] fence: Use smp_mb__before_atomic()

2014-05-28 Thread Thierry Reding
From: Thierry Reding Commit febdbfe8a91c (arch: Prepare for smp_mb__{before,after}_atomic()) deprecated the smp_mb__{before,after}_{atomic,clear}_{dec,inc,bit}*() functions in favour of the unified smp_mb__{before,after}_atomic(). Signed-off-by: Thierry Reding --- drivers/base/fence.c | 4

Re: [PATCH] fence: Use smp_mb__before_atomic()

2014-05-28 Thread Maarten Lankhorst
On 28-05-14 16:26, Thierry Reding wrote: From: Thierry Reding tred...@nvidia.com Commit febdbfe8a91c (arch: Prepare for smp_mb__{before,after}_atomic()) deprecated the smp_mb__{before,after}_{atomic,clear}_{dec,inc,bit}*() functions in favour of the unified smp_mb__{before,after}_atomic().

Re: [PATCH] fence: Use smp_mb__before_atomic()

2014-05-28 Thread Greg Kroah-Hartman
On Wed, May 28, 2014 at 04:26:32PM +0200, Thierry Reding wrote: From: Thierry Reding tred...@nvidia.com Commit febdbfe8a91c (arch: Prepare for smp_mb__{before,after}_atomic()) deprecated the smp_mb__{before,after}_{atomic,clear}_{dec,inc,bit}*() functions in favour of the unified

[PATCH] fence: Use smp_mb__before_atomic()

2014-05-28 Thread Thierry Reding
From: Thierry Reding tred...@nvidia.com Commit febdbfe8a91c (arch: Prepare for smp_mb__{before,after}_atomic()) deprecated the smp_mb__{before,after}_{atomic,clear}_{dec,inc,bit}*() functions in favour of the unified smp_mb__{before,after}_atomic(). Signed-off-by: Thierry Reding