Re: [PATCH] filesystem-dax: Disable PMD support

2019-07-04 Thread Jan Kara
On Wed 03-07-19 08:47:00, Matthew Wilcox wrote: > On Mon, Jul 01, 2019 at 02:11:19PM +0200, Jan Kara wrote: > > BTW, looking into the xarray code, I think I found another difference > > between the old radix tree code and the new xarray code that could cause > > issues. In the old radix tree code

Re: [PATCH] filesystem-dax: Disable PMD support

2019-07-03 Thread Matthew Wilcox
On Mon, Jul 01, 2019 at 02:11:19PM +0200, Jan Kara wrote: > BTW, looking into the xarray code, I think I found another difference > between the old radix tree code and the new xarray code that could cause > issues. In the old radix tree code if we tried to insert PMD entry but > there was some PTE

Re: [PATCH] filesystem-dax: Disable PMD support

2019-07-03 Thread Jan Kara
On Sun 30-06-19 08:23:24, Matthew Wilcox wrote: > On Sun, Jun 30, 2019 at 01:01:04AM -0700, Dan Williams wrote: > > @@ -215,7 +216,7 @@ static wait_queue_head_t > > *dax_entry_waitqueue(struct xa_state *xas, > > * queue to the start of that PMD. This ensures that all offsets in > >

Re: [PATCH] filesystem-dax: Disable PMD support

2019-07-02 Thread Boaz Harrosh
On 03/07/2019 03:42, Dan Williams wrote: > On Tue, Jul 2, 2019 at 5:23 PM Boaz Harrosh wrote: <> > > Yes, but the trick is how to manage cases where someone waiting on one > type needs to be woken up by an event on the other. Exactly I'm totally with you on this. > So all I'm saying it lets

Re: [PATCH] filesystem-dax: Disable PMD support

2019-07-02 Thread Dan Williams
On Tue, Jul 2, 2019 at 5:23 PM Boaz Harrosh wrote: > > On 02/07/2019 18:37, Dan Williams wrote: > <> > > > > I'd be inclined to do the brute force fix of not trying to get fancy > > with separate PTE/PMD waitqueues and then follow on with a more clever > > performance enhancement later. Thoughts

Re: [PATCH] filesystem-dax: Disable PMD support

2019-07-02 Thread Boaz Harrosh
On 02/07/2019 18:37, Dan Williams wrote: <> > > I'd be inclined to do the brute force fix of not trying to get fancy > with separate PTE/PMD waitqueues and then follow on with a more clever > performance enhancement later. Thoughts about that? > Sir Dan I do not understand how separate

Re: [PATCH] filesystem-dax: Disable PMD support

2019-07-02 Thread Dan Williams
On Mon, Jul 1, 2019 at 8:34 PM Matthew Wilcox wrote: > > On Sun, Jun 30, 2019 at 02:37:32PM -0700, Dan Williams wrote: > > On Sun, Jun 30, 2019 at 8:23 AM Matthew Wilcox wrote: > > > I think my theory was slightly mistaken, but your fix has the effect of > > > fixing the actual problem too. > >

Re: [PATCH] filesystem-dax: Disable PMD support

2019-07-01 Thread Matthew Wilcox
On Sun, Jun 30, 2019 at 02:37:32PM -0700, Dan Williams wrote: > On Sun, Jun 30, 2019 at 8:23 AM Matthew Wilcox wrote: > > I think my theory was slightly mistaken, but your fix has the effect of > > fixing the actual problem too. > > > > The xas->xa_index for a PMD is going to be PMD-aligned (ie a

Re: [PATCH] filesystem-dax: Disable PMD support

2019-06-30 Thread Dan Williams
On Sun, Jun 30, 2019 at 8:23 AM Matthew Wilcox wrote: > > On Sun, Jun 30, 2019 at 01:01:04AM -0700, Dan Williams wrote: > > On Sun, Jun 30, 2019 at 12:27 AM Dan Williams > > wrote: > > > > > > On Sat, Jun 29, 2019 at 9:03 AM Matthew Wilcox > > > wrote: > > > > > > > > On Thu, Jun 27, 2019 at

Re: [PATCH] filesystem-dax: Disable PMD support

2019-06-30 Thread Matthew Wilcox
On Sun, Jun 30, 2019 at 01:01:04AM -0700, Dan Williams wrote: > On Sun, Jun 30, 2019 at 12:27 AM Dan Williams > wrote: > > > > On Sat, Jun 29, 2019 at 9:03 AM Matthew Wilcox wrote: > > > > > > On Thu, Jun 27, 2019 at 07:39:37PM -0700, Dan Williams wrote: > > > > On Thu, Jun 27, 2019 at 12:59 PM

Re: [PATCH] filesystem-dax: Disable PMD support

2019-06-30 Thread Dan Williams
On Sun, Jun 30, 2019 at 12:27 AM Dan Williams wrote: > > On Sat, Jun 29, 2019 at 9:03 AM Matthew Wilcox wrote: > > > > On Thu, Jun 27, 2019 at 07:39:37PM -0700, Dan Williams wrote: > > > On Thu, Jun 27, 2019 at 12:59 PM Matthew Wilcox > > > wrote: > > > > > > > > On Thu, Jun 27, 2019 at

Re: [PATCH] filesystem-dax: Disable PMD support

2019-06-30 Thread Dan Williams
On Sat, Jun 29, 2019 at 9:03 AM Matthew Wilcox wrote: > > On Thu, Jun 27, 2019 at 07:39:37PM -0700, Dan Williams wrote: > > On Thu, Jun 27, 2019 at 12:59 PM Matthew Wilcox wrote: > > > > > > On Thu, Jun 27, 2019 at 12:09:29PM -0700, Dan Williams wrote: > > > > > This bug feels like we failed to

Re: [PATCH] filesystem-dax: Disable PMD support

2019-06-29 Thread Matthew Wilcox
On Thu, Jun 27, 2019 at 07:39:37PM -0700, Dan Williams wrote: > On Thu, Jun 27, 2019 at 12:59 PM Matthew Wilcox wrote: > > > > On Thu, Jun 27, 2019 at 12:09:29PM -0700, Dan Williams wrote: > > > > This bug feels like we failed to unlock, or unlocked the wrong entry > > > > and this hunk in the

Re: [PATCH] filesystem-dax: Disable PMD support

2019-06-28 Thread Matthew Wilcox
On Fri, Jun 28, 2019 at 09:39:01AM -0700, Dan Williams wrote: > On Fri, Jun 28, 2019 at 9:37 AM Matthew Wilcox wrote: > > That was the conclusion I came to; that one thread holding the mmap sem > > for read isn't being woken up when it should be. Just need to find it ... > > obviously it's

Re: [PATCH] filesystem-dax: Disable PMD support

2019-06-28 Thread Dan Williams
On Fri, Jun 28, 2019 at 9:37 AM Matthew Wilcox wrote: > > On Thu, Jun 27, 2019 at 07:39:37PM -0700, Dan Williams wrote: > > On Thu, Jun 27, 2019 at 12:59 PM Matthew Wilcox wrote: > > > On Thu, Jun 27, 2019 at 12:09:29PM -0700, Dan Williams wrote: > > > > > This bug feels like we failed to

Re: [PATCH] filesystem-dax: Disable PMD support

2019-06-28 Thread Matthew Wilcox
On Thu, Jun 27, 2019 at 07:39:37PM -0700, Dan Williams wrote: > On Thu, Jun 27, 2019 at 12:59 PM Matthew Wilcox wrote: > > On Thu, Jun 27, 2019 at 12:09:29PM -0700, Dan Williams wrote: > > > > This bug feels like we failed to unlock, or unlocked the wrong entry > > > > and this hunk in the

Re: [PATCH] filesystem-dax: Disable PMD support

2019-06-27 Thread Dan Williams
On Thu, Jun 27, 2019 at 12:59 PM Matthew Wilcox wrote: > > On Thu, Jun 27, 2019 at 12:09:29PM -0700, Dan Williams wrote: > > > This bug feels like we failed to unlock, or unlocked the wrong entry > > > and this hunk in the bisected commit looks suspect to me. Why do we > > > still need to drop

Re: [PATCH] filesystem-dax: Disable PMD support

2019-06-27 Thread Matthew Wilcox
On Thu, Jun 27, 2019 at 12:09:29PM -0700, Dan Williams wrote: > > This bug feels like we failed to unlock, or unlocked the wrong entry > > and this hunk in the bisected commit looks suspect to me. Why do we > > still need to drop the lock now that the radix_tree_preload() calls > > are gone? > >

Re: [PATCH] filesystem-dax: Disable PMD support

2019-06-27 Thread Dan Williams
On Thu, Jun 27, 2019 at 11:58 AM Dan Williams wrote: > > On Thu, Jun 27, 2019 at 11:29 AM Dan Williams > wrote: > > > > On Thu, Jun 27, 2019 at 9:06 AM Dan Williams > > wrote: > > > > > > On Thu, Jun 27, 2019 at 5:34 AM Matthew Wilcox > > > wrote: > > > > > > > > On Wed, Jun 26, 2019 at

Re: [PATCH] filesystem-dax: Disable PMD support

2019-06-27 Thread Dan Williams
On Thu, Jun 27, 2019 at 11:29 AM Dan Williams wrote: > > On Thu, Jun 27, 2019 at 9:06 AM Dan Williams wrote: > > > > On Thu, Jun 27, 2019 at 5:34 AM Matthew Wilcox wrote: > > > > > > On Wed, Jun 26, 2019 at 05:15:45PM -0700, Dan Williams wrote: > > > > Ever since the conversion of DAX to the

Re: [PATCH] filesystem-dax: Disable PMD support

2019-06-27 Thread Dan Williams
On Thu, Jun 27, 2019 at 9:06 AM Dan Williams wrote: > > On Thu, Jun 27, 2019 at 5:34 AM Matthew Wilcox wrote: > > > > On Wed, Jun 26, 2019 at 05:15:45PM -0700, Dan Williams wrote: > > > Ever since the conversion of DAX to the Xarray a RocksDB benchmark has > > > been encountering intermittent

Re: [PATCH] filesystem-dax: Disable PMD support

2019-06-27 Thread Dan Williams
On Thu, Jun 27, 2019 at 5:34 AM Matthew Wilcox wrote: > > On Wed, Jun 26, 2019 at 05:15:45PM -0700, Dan Williams wrote: > > Ever since the conversion of DAX to the Xarray a RocksDB benchmark has > > been encountering intermittent lockups. The backtraces always include > > the filesystem-DAX PMD

Re: [PATCH] filesystem-dax: Disable PMD support

2019-06-27 Thread Matthew Wilcox
On Wed, Jun 26, 2019 at 05:15:45PM -0700, Dan Williams wrote: > Ever since the conversion of DAX to the Xarray a RocksDB benchmark has > been encountering intermittent lockups. The backtraces always include > the filesystem-DAX PMD path, multi-order entries have been a source of > bugs in the

[PATCH] filesystem-dax: Disable PMD support

2019-06-26 Thread Dan Williams
Ever since the conversion of DAX to the Xarray a RocksDB benchmark has been encountering intermittent lockups. The backtraces always include the filesystem-DAX PMD path, multi-order entries have been a source of bugs in the past, and disabling the PMD path allows a test that fails in minutes to