Re: [PATCH] finish processor.h integration

2007-12-19 Thread Ingo Molnar
* Glauber de Oliveira Costa <[EMAIL PROTECTED]> wrote: > > i fixed it up by hand - the result is below - does it look OK to > > you? (Also, could you check latest x86.git whether i've picked up > > all your patches correctly - the reject might be indicative of some > > missing pieces.) > >

Re: [PATCH] finish processor.h integration

2007-12-19 Thread Glauber de Oliveira Costa
On Dec 19, 2007 8:17 AM, Ingo Molnar <[EMAIL PROTECTED]> wrote: > > * Glauber de Oliveira Costa <[EMAIL PROTECTED]> wrote: > > > What's left in processor_32.h and processor_64.h cannot be cleanly > > integrated. However, it's just a couple of definitions. They are moved > > to processor.h around

Re: [PATCH] finish processor.h integration

2007-12-19 Thread Ingo Molnar
* Glauber de Oliveira Costa <[EMAIL PROTECTED]> wrote: > What's left in processor_32.h and processor_64.h cannot be cleanly > integrated. However, it's just a couple of definitions. They are moved > to processor.h around ifdefs, and the original files are deleted. Note > that there's much

Re: [PATCH] finish processor.h integration

2007-12-19 Thread Ingo Molnar
* Glauber de Oliveira Costa [EMAIL PROTECTED] wrote: What's left in processor_32.h and processor_64.h cannot be cleanly integrated. However, it's just a couple of definitions. They are moved to processor.h around ifdefs, and the original files are deleted. Note that there's much less

Re: [PATCH] finish processor.h integration

2007-12-19 Thread Glauber de Oliveira Costa
On Dec 19, 2007 8:17 AM, Ingo Molnar [EMAIL PROTECTED] wrote: * Glauber de Oliveira Costa [EMAIL PROTECTED] wrote: What's left in processor_32.h and processor_64.h cannot be cleanly integrated. However, it's just a couple of definitions. They are moved to processor.h around ifdefs, and

Re: [PATCH] finish processor.h integration

2007-12-19 Thread Ingo Molnar
* Glauber de Oliveira Costa [EMAIL PROTECTED] wrote: i fixed it up by hand - the result is below - does it look OK to you? (Also, could you check latest x86.git whether i've picked up all your patches correctly - the reject might be indicative of some missing pieces.) Your fix is

Re: [PATCH] finish processor.h integration

2007-12-18 Thread Glauber de Oliveira Costa
On Dec 18, 2007 7:32 PM, Frans Pop <[EMAIL PROTECTED]> wrote: > On Tuesday 18 December 2007, Glauber de Oliveira Costa wrote: > > On Dec 18, 2007 6:54 PM, Frans Pop <[EMAIL PROTECTED]> wrote: > > > Glauber de Oliveira Costa wrote: > > > > What's left in processor_32.h and processor_64.h cannot be

Re: [PATCH] finish processor.h integration

2007-12-18 Thread Frans Pop
On Tuesday 18 December 2007, Glauber de Oliveira Costa wrote: > On Dec 18, 2007 6:54 PM, Frans Pop <[EMAIL PROTECTED]> wrote: > > Glauber de Oliveira Costa wrote: > > > What's left in processor_32.h and processor_64.h cannot be cleanly > > > integrated. However, it's just a couple of definitions.

Re: [PATCH] finish processor.h integration

2007-12-18 Thread Ingo Molnar
* Glauber de Oliveira Costa <[EMAIL PROTECTED]> wrote: > On Dec 18, 2007 6:54 PM, Frans Pop <[EMAIL PROTECTED]> wrote: > > Glauber de Oliveira Costa wrote: > > > What's left in processor_32.h and processor_64.h cannot be cleanly > > > integrated. However, it's just a couple of definitions. They

Re: [PATCH] finish processor.h integration

2007-12-18 Thread Glauber de Oliveira Costa
On Dec 18, 2007 6:54 PM, Frans Pop <[EMAIL PROTECTED]> wrote: > Glauber de Oliveira Costa wrote: > > What's left in processor_32.h and processor_64.h cannot be cleanly > > integrated. However, it's just a couple of definitions. They are moved > > to processor.h around ifdefs, and the original

Re: [PATCH] finish processor.h integration

2007-12-18 Thread Frans Pop
Glauber de Oliveira Costa wrote: > What's left in processor_32.h and processor_64.h cannot be cleanly > integrated. However, it's just a couple of definitions. They are moved > to processor.h around ifdefs, and the original files are deleted. Note > that there's much less headers included in the

[PATCH] finish processor.h integration

2007-12-18 Thread Glauber de Oliveira Costa
What's left in processor_32.h and processor_64.h cannot be cleanly integrated. However, it's just a couple of definitions. They are moved to processor.h around ifdefs, and the original files are deleted. Note that there's much less headers included in the final version. Signed-off-by: Glauber de

Re: [PATCH 21/21] [PATCH] finish processor.h integration

2007-12-18 Thread Ingo Molnar
* Glauber de Oliveira Costa <[EMAIL PROTECTED]> wrote: > Ingo Molnar wrote: >> * Ingo Molnar <[EMAIL PROTECTED]> wrote: >> >>> yes, our include file dependencies are a jungle, the differences between >>> 32-bit and 64-bit are arbitrary in 80% of the cases, but still there's no >>> reason why

Re: [PATCH 21/21] [PATCH] finish processor.h integration

2007-12-18 Thread Ingo Molnar
* Glauber de Oliveira Costa <[EMAIL PROTECTED]> wrote: >> here the problem is apparently caused by your patch, a careless >> 'unification' of include file sections. 32-bit had this: > > Point is this patches do unification, but they are not just that, as > you can see. I am attempting to

Re: [PATCH 21/21] [PATCH] finish processor.h integration

2007-12-18 Thread Glauber de Oliveira Costa
Ingo Molnar wrote: * Ingo Molnar <[EMAIL PROTECTED]> wrote: yes, our include file dependencies are a jungle, the differences between 32-bit and 64-bit are arbitrary in 80% of the cases, but still there's no reason why this couldnt be done correctly. The patch below is a quick bandaid that

Re: [PATCH 21/21] [PATCH] finish processor.h integration

2007-12-18 Thread Glauber de Oliveira Costa
Ingo Molnar wrote: * Ingo Molnar <[EMAIL PROTECTED]> wrote: What's left in processor_32.h and processor_64.h cannot be cleanly integrated. However, it's just a couple of definitions. They are moved to processor.h around ifdefs, and the original files are deleted. Note that there's much less

Re: [PATCH 21/21] [PATCH] finish processor.h integration

2007-12-18 Thread Ingo Molnar
* Ingo Molnar <[EMAIL PROTECTED]> wrote: > yes, our include file dependencies are a jungle, the differences > between 32-bit and 64-bit are arbitrary in 80% of the cases, but still > there's no reason why this couldnt be done correctly. The patch below > is a quick bandaid that adds the

Re: [PATCH 21/21] [PATCH] finish processor.h integration

2007-12-18 Thread Ingo Molnar
* Ingo Molnar <[EMAIL PROTECTED]> wrote: > > What's left in processor_32.h and processor_64.h cannot be cleanly > > integrated. However, it's just a couple of definitions. They are > > moved to processor.h around ifdefs, and the original files are > > deleted. Note that there's much less

Re: [PATCH 21/21] [PATCH] finish processor.h integration

2007-12-18 Thread Ingo Molnar
* Ingo Molnar [EMAIL PROTECTED] wrote: What's left in processor_32.h and processor_64.h cannot be cleanly integrated. However, it's just a couple of definitions. They are moved to processor.h around ifdefs, and the original files are deleted. Note that there's much less headers

Re: [PATCH 21/21] [PATCH] finish processor.h integration

2007-12-18 Thread Ingo Molnar
* Ingo Molnar [EMAIL PROTECTED] wrote: yes, our include file dependencies are a jungle, the differences between 32-bit and 64-bit are arbitrary in 80% of the cases, but still there's no reason why this couldnt be done correctly. The patch below is a quick bandaid that adds the missing

Re: [PATCH 21/21] [PATCH] finish processor.h integration

2007-12-18 Thread Glauber de Oliveira Costa
Ingo Molnar wrote: * Ingo Molnar [EMAIL PROTECTED] wrote: What's left in processor_32.h and processor_64.h cannot be cleanly integrated. However, it's just a couple of definitions. They are moved to processor.h around ifdefs, and the original files are deleted. Note that there's much less

Re: [PATCH 21/21] [PATCH] finish processor.h integration

2007-12-18 Thread Glauber de Oliveira Costa
Ingo Molnar wrote: * Ingo Molnar [EMAIL PROTECTED] wrote: yes, our include file dependencies are a jungle, the differences between 32-bit and 64-bit are arbitrary in 80% of the cases, but still there's no reason why this couldnt be done correctly. The patch below is a quick bandaid that adds

Re: [PATCH 21/21] [PATCH] finish processor.h integration

2007-12-18 Thread Ingo Molnar
* Glauber de Oliveira Costa [EMAIL PROTECTED] wrote: here the problem is apparently caused by your patch, a careless 'unification' of include file sections. 32-bit had this: Point is this patches do unification, but they are not just that, as you can see. I am attempting to cleanup

Re: [PATCH 21/21] [PATCH] finish processor.h integration

2007-12-18 Thread Ingo Molnar
* Glauber de Oliveira Costa [EMAIL PROTECTED] wrote: Ingo Molnar wrote: * Ingo Molnar [EMAIL PROTECTED] wrote: yes, our include file dependencies are a jungle, the differences between 32-bit and 64-bit are arbitrary in 80% of the cases, but still there's no reason why this couldnt be

[PATCH] finish processor.h integration

2007-12-18 Thread Glauber de Oliveira Costa
What's left in processor_32.h and processor_64.h cannot be cleanly integrated. However, it's just a couple of definitions. They are moved to processor.h around ifdefs, and the original files are deleted. Note that there's much less headers included in the final version. Signed-off-by: Glauber de

Re: [PATCH] finish processor.h integration

2007-12-18 Thread Frans Pop
Glauber de Oliveira Costa wrote: What's left in processor_32.h and processor_64.h cannot be cleanly integrated. However, it's just a couple of definitions. They are moved to processor.h around ifdefs, and the original files are deleted. Note that there's much less headers included in the final

Re: [PATCH] finish processor.h integration

2007-12-18 Thread Ingo Molnar
* Glauber de Oliveira Costa [EMAIL PROTECTED] wrote: On Dec 18, 2007 6:54 PM, Frans Pop [EMAIL PROTECTED] wrote: Glauber de Oliveira Costa wrote: What's left in processor_32.h and processor_64.h cannot be cleanly integrated. However, it's just a couple of definitions. They are moved

Re: [PATCH] finish processor.h integration

2007-12-18 Thread Glauber de Oliveira Costa
On Dec 18, 2007 6:54 PM, Frans Pop [EMAIL PROTECTED] wrote: Glauber de Oliveira Costa wrote: What's left in processor_32.h and processor_64.h cannot be cleanly integrated. However, it's just a couple of definitions. They are moved to processor.h around ifdefs, and the original files are

Re: [PATCH] finish processor.h integration

2007-12-18 Thread Frans Pop
On Tuesday 18 December 2007, Glauber de Oliveira Costa wrote: On Dec 18, 2007 6:54 PM, Frans Pop [EMAIL PROTECTED] wrote: Glauber de Oliveira Costa wrote: What's left in processor_32.h and processor_64.h cannot be cleanly integrated. However, it's just a couple of definitions. They are

Re: [PATCH] finish processor.h integration

2007-12-18 Thread Glauber de Oliveira Costa
On Dec 18, 2007 7:32 PM, Frans Pop [EMAIL PROTECTED] wrote: On Tuesday 18 December 2007, Glauber de Oliveira Costa wrote: On Dec 18, 2007 6:54 PM, Frans Pop [EMAIL PROTECTED] wrote: Glauber de Oliveira Costa wrote: What's left in processor_32.h and processor_64.h cannot be cleanly

[PATCH 21/21] [PATCH] finish processor.h integration

2007-12-17 Thread Glauber de Oliveira Costa
What's left in processor_32.h and processor_64.h cannot be cleanly integrated. However, it's just a couple of definitions. They are moved to processor.h around ifdefs, and the original files are deleted. Note that there's much less headers included in the final version. Signed-off-by: Glauber de

[PATCH 21/21] [PATCH] finish processor.h integration

2007-12-17 Thread Glauber de Oliveira Costa
What's left in processor_32.h and processor_64.h cannot be cleanly integrated. However, it's just a couple of definitions. They are moved to processor.h around ifdefs, and the original files are deleted. Note that there's much less headers included in the final version. Signed-off-by: Glauber de