Re: [PATCH] firmware: qcom_scm: Fix legacy convention SCM accessors

2020-07-13 Thread Bjorn Andersson
On Mon 13 Jul 09:35 PDT 2020, Elliot Berman wrote: > For the Qualcomm TrustZone firmwares which I am familiar with: > > Reviewed-by: Elliot Berman > Thanks for the patch Jonathan and thanks for the review Elliot! Applied Regards, Bjorn > On 7/4/2020 10:23 AM, Jonathan McDowell wrote: > >

Re: [PATCH] firmware: qcom_scm: Fix legacy convention SCM accessors

2020-07-13 Thread Elliot Berman
For the Qualcomm TrustZone firmwares which I am familiar with: Reviewed-by: Elliot Berman On 7/4/2020 10:23 AM, Jonathan McDowell wrote: > The move to a combined driver for the QCOM SCM hardware changed the > io_writel and io_readl helpers to use non-atomic calls, despite the > commit message

[PATCH] firmware: qcom_scm: Fix legacy convention SCM accessors

2020-07-04 Thread Jonathan McDowell
The move to a combined driver for the QCOM SCM hardware changed the io_writel and io_readl helpers to use non-atomic calls, despite the commit message saying that atomic was a better option. This breaks these helpers on hardware that uses the old legacy convention (access fails with a -95 return