Re: [PATCH] firmware: tegra: add BPMP debugfs support

2017-10-02 Thread Timo Alho
On 29.09.2017 17:58, Jonathan Hunter wrote: +static int bpmp_populate_dir(struct tegra_bpmp *bpmp, struct seqbuf *seqbuf, + struct dentry *parent, uint32_t depth) Do we need to use uint32_t here? +{ +    int err; +    uint32_t d, t; And here? It's part of the BPMP ABI

Re: [PATCH] firmware: tegra: add BPMP debugfs support

2017-10-02 Thread Timo Alho
On 29.09.2017 17:58, Jonathan Hunter wrote: +static int bpmp_populate_dir(struct tegra_bpmp *bpmp, struct seqbuf *seqbuf, + struct dentry *parent, uint32_t depth) Do we need to use uint32_t here? +{ +    int err; +    uint32_t d, t; And here? It's part of the BPMP ABI

Re: [PATCH] firmware: tegra: add BPMP debugfs support

2017-09-29 Thread Jon Hunter
On 29/09/17 14:41, Timo Alho wrote:> On 21.09.2017 14:10, Jonathan Hunter wrote: >>> --- a/drivers/firmware/tegra/bpmp.c >>> +++ b/drivers/firmware/tegra/bpmp.c >>> @@ -824,6 +824,8 @@ static int tegra_bpmp_probe(struct >>> platform_device *pdev) >>>   if (err < 0) >>>   goto

Re: [PATCH] firmware: tegra: add BPMP debugfs support

2017-09-29 Thread Jon Hunter
On 29/09/17 14:41, Timo Alho wrote:> On 21.09.2017 14:10, Jonathan Hunter wrote: >>> --- a/drivers/firmware/tegra/bpmp.c >>> +++ b/drivers/firmware/tegra/bpmp.c >>> @@ -824,6 +824,8 @@ static int tegra_bpmp_probe(struct >>> platform_device *pdev) >>>   if (err < 0) >>>   goto

Re: [PATCH] firmware: tegra: add BPMP debugfs support

2017-09-29 Thread Timo Alho
Jon, Thanks for reviewing this! On 21.09.2017 14:10, Jonathan Hunter wrote: --- a/drivers/firmware/tegra/bpmp.c +++ b/drivers/firmware/tegra/bpmp.c @@ -824,6 +824,8 @@ static int tegra_bpmp_probe(struct platform_device *pdev) if (err < 0) goto free_mrq; +

Re: [PATCH] firmware: tegra: add BPMP debugfs support

2017-09-29 Thread Timo Alho
Jon, Thanks for reviewing this! On 21.09.2017 14:10, Jonathan Hunter wrote: --- a/drivers/firmware/tegra/bpmp.c +++ b/drivers/firmware/tegra/bpmp.c @@ -824,6 +824,8 @@ static int tegra_bpmp_probe(struct platform_device *pdev) if (err < 0) goto free_mrq; +

Re: [PATCH] firmware: tegra: add BPMP debugfs support

2017-09-21 Thread Jon Hunter
Hi Timo, On 22/08/17 15:04, Timo Alho wrote: > Tegra power management firmware running on co-processor (BPMP) > implements a simple pseudo file system akin to debugfs. The file > system can be used for debugging purposes to examine and change the > status of selected resources controlled by the

Re: [PATCH] firmware: tegra: add BPMP debugfs support

2017-09-21 Thread Jon Hunter
Hi Timo, On 22/08/17 15:04, Timo Alho wrote: > Tegra power management firmware running on co-processor (BPMP) > implements a simple pseudo file system akin to debugfs. The file > system can be used for debugging purposes to examine and change the > status of selected resources controlled by the

[PATCH] firmware: tegra: add BPMP debugfs support

2017-08-22 Thread Timo Alho
Tegra power management firmware running on co-processor (BPMP) implements a simple pseudo file system akin to debugfs. The file system can be used for debugging purposes to examine and change the status of selected resources controlled by the firmware (such as clocks, resets, voltages, powergates,

[PATCH] firmware: tegra: add BPMP debugfs support

2017-08-22 Thread Timo Alho
Tegra power management firmware running on co-processor (BPMP) implements a simple pseudo file system akin to debugfs. The file system can be used for debugging purposes to examine and change the status of selected resources controlled by the firmware (such as clocks, resets, voltages, powergates,