Re: [PATCH] firmware_class: Add firmware filename overrides

2015-03-10 Thread Charles Mooney
Okay, thanks for the reviews. My hope was to avoid having to add that feature into each driver, but that's okay. -Charlie On Fri, Mar 6, 2015 at 3:33 PM, Marcel Holtmann wrote: > Hi Charles, > Specifically this was motivated by a situation where we have one device with

Re: [PATCH] firmware_class: Add firmware filename overrides

2015-03-10 Thread Charles Mooney
Okay, thanks for the reviews. My hope was to avoid having to add that feature into each driver, but that's okay. -Charlie On Fri, Mar 6, 2015 at 3:33 PM, Marcel Holtmann mar...@holtmann.org wrote: Hi Charles, Specifically this was motivated by a situation where we have one device with a

Re: [PATCH] firmware_class: Add firmware filename overrides

2015-03-06 Thread Marcel Holtmann
Hi Charles, >>> Specifically this was motivated by a situation where we have one >>> device with a dual-sourced touchscreen. Both use the same driver but >>> have different hardware & fw. Our FW updating software therefore, >>> needs to be able to update with the

Re: [PATCH] firmware_class: Add firmware filename overrides

2015-03-06 Thread Charles Mooney
On Thu, Mar 5, 2015 at 5:27 PM, Ming Lei wrote: > On Fri, Mar 6, 2015 at 6:36 AM, Dmitry Torokhov wrote: >> On Thu, Mar 5, 2015 at 2:12 PM, Marcel Holtmann wrote: >>> Hi Dmitry, >>> >> Specifically this was motivated by a situation where we have one >> device with a dual-sourced

Re: [PATCH] firmware_class: Add firmware filename overrides

2015-03-06 Thread Marcel Holtmann
Hi Charles, Specifically this was motivated by a situation where we have one device with a dual-sourced touchscreen. Both use the same driver but have different hardware fw. Our FW updating software therefore, needs to be able to update with the correct FW and detect all this at runtime

Re: [PATCH] firmware_class: Add firmware filename overrides

2015-03-06 Thread Charles Mooney
On Thu, Mar 5, 2015 at 5:27 PM, Ming Lei ming@canonical.com wrote: On Fri, Mar 6, 2015 at 6:36 AM, Dmitry Torokhov d...@chromium.org wrote: On Thu, Mar 5, 2015 at 2:12 PM, Marcel Holtmann mar...@holtmann.org wrote: Hi Dmitry, Specifically this was motivated by a situation where we have

Re: [PATCH] firmware_class: Add firmware filename overrides

2015-03-05 Thread Ming Lei
On Fri, Mar 6, 2015 at 6:36 AM, Dmitry Torokhov wrote: > On Thu, Mar 5, 2015 at 2:12 PM, Marcel Holtmann wrote: >> Hi Dmitry, >> > Specifically this was motivated by a situation where we have one > device with a dual-sourced touchscreen. Both use the same driver but >

Re: [PATCH] firmware_class: Add firmware filename overrides

2015-03-05 Thread Dmitry Torokhov
On Thu, Mar 5, 2015 at 2:12 PM, Marcel Holtmann wrote: > Hi Dmitry, > Specifically this was motivated by a situation where we have one device with a dual-sourced touchscreen. Both use the same driver but have different hardware & fw. Our FW updating software therefore,

Re: [PATCH] firmware_class: Add firmware filename overrides

2015-03-05 Thread Marcel Holtmann
Hi Dmitry, >>> Specifically this was motivated by a situation where we have one >>> device with a dual-sourced touchscreen. Both use the same driver but >>> have different hardware & fw. Our FW updating software therefore, >>> needs to be able to update with the correct FW and

Re: [PATCH] firmware_class: Add firmware filename overrides

2015-03-05 Thread Marcel Holtmann
Hi Dmitry, > Specifically this was motivated by a situation where we have one > device with a dual-sourced touchscreen. Both use the same driver but > have different hardware & fw. Our FW updating software therefore, > needs to be able to update with the correct FW and detect all

Re: [PATCH] firmware_class: Add firmware filename overrides

2015-03-05 Thread Dmitry Torokhov
Hi Marcel, On Thu, Mar 5, 2015 at 11:11 AM, Marcel Holtmann wrote: > Hi Dmitry, > >> Specifically this was motivated by a situation where we have one >> device with a dual-sourced touchscreen. Both use the same driver but >> have different hardware & fw. Our FW updating software

Re: [PATCH] firmware_class: Add firmware filename overrides

2015-03-05 Thread Dmitry Torokhov
On Thu, Mar 5, 2015 at 10:13 AM, Marcel Holtmann wrote: > Hi Charles, > Specifically this was motivated by a situation where we have one device with a dual-sourced touchscreen. Both use the same driver but have different hardware & fw. Our FW updating software therefore, needs

Re: [PATCH] firmware_class: Add firmware filename overrides

2015-03-05 Thread Marcel Holtmann
Hi Charles, >>> Specifically this was motivated by a situation where we have one >>> device with a dual-sourced touchscreen. Both use the same driver but >>> have different hardware & fw. Our FW updating software therefore, >>> needs to be able to update with the correct FW and detect all this at

Re: [PATCH] firmware_class: Add firmware filename overrides

2015-03-05 Thread Charles Mooney
On Thu, Mar 5, 2015 at 9:39 AM, Marcel Holtmann wrote: > Hi Charles, > >> Specifically this was motivated by a situation where we have one >> device with a dual-sourced touchscreen. Both use the same driver but >> have different hardware & fw. Our FW updating software therefore, >> needs to be

Re: [PATCH] firmware_class: Add firmware filename overrides

2015-03-05 Thread Marcel Holtmann
Hi Charles, > Specifically this was motivated by a situation where we have one > device with a dual-sourced touchscreen. Both use the same driver but > have different hardware & fw. Our FW updating software therefore, > needs to be able to update with the correct FW and detect all this at >

Re: [PATCH] firmware_class: Add firmware filename overrides

2015-03-05 Thread Charles Mooney
Specifically this was motivated by a situation where we have one device with a dual-sourced touchscreen. Both use the same driver but have different hardware & fw. Our FW updating software therefore, needs to be able to update with the correct FW and detect all this at runtime due to a read-only

Re: [PATCH] firmware_class: Add firmware filename overrides

2015-03-05 Thread Ming Lei
On Thu, Mar 5, 2015 at 8:48 AM, Dmitry Torokhov wrote: > On Wed, Mar 04, 2015 at 03:57:09PM -0800, Greg KH wrote: >> On Wed, Mar 04, 2015 at 03:25:10PM -0800, Charlie Mooney wrote: >> > This patch adds an additional feature to the firmware_class.c module. >> > To allow a unified method of

Re: [PATCH] firmware_class: Add firmware filename overrides

2015-03-05 Thread Dmitry Torokhov
On Thu, Mar 5, 2015 at 2:12 PM, Marcel Holtmann mar...@holtmann.org wrote: Hi Dmitry, Specifically this was motivated by a situation where we have one device with a dual-sourced touchscreen. Both use the same driver but have different hardware fw. Our FW updating software therefore, needs

Re: [PATCH] firmware_class: Add firmware filename overrides

2015-03-05 Thread Marcel Holtmann
Hi Dmitry, Specifically this was motivated by a situation where we have one device with a dual-sourced touchscreen. Both use the same driver but have different hardware fw. Our FW updating software therefore, needs to be able to update with the correct FW and detect all this at runtime due

Re: [PATCH] firmware_class: Add firmware filename overrides

2015-03-05 Thread Ming Lei
On Fri, Mar 6, 2015 at 6:36 AM, Dmitry Torokhov d...@chromium.org wrote: On Thu, Mar 5, 2015 at 2:12 PM, Marcel Holtmann mar...@holtmann.org wrote: Hi Dmitry, Specifically this was motivated by a situation where we have one device with a dual-sourced touchscreen. Both use the same driver but

Re: [PATCH] firmware_class: Add firmware filename overrides

2015-03-05 Thread Charles Mooney
Specifically this was motivated by a situation where we have one device with a dual-sourced touchscreen. Both use the same driver but have different hardware fw. Our FW updating software therefore, needs to be able to update with the correct FW and detect all this at runtime due to a read-only

Re: [PATCH] firmware_class: Add firmware filename overrides

2015-03-05 Thread Marcel Holtmann
Hi Charles, Specifically this was motivated by a situation where we have one device with a dual-sourced touchscreen. Both use the same driver but have different hardware fw. Our FW updating software therefore, needs to be able to update with the correct FW and detect all this at runtime due

Re: [PATCH] firmware_class: Add firmware filename overrides

2015-03-05 Thread Charles Mooney
On Thu, Mar 5, 2015 at 9:39 AM, Marcel Holtmann mar...@holtmann.org wrote: Hi Charles, Specifically this was motivated by a situation where we have one device with a dual-sourced touchscreen. Both use the same driver but have different hardware fw. Our FW updating software therefore, needs

Re: [PATCH] firmware_class: Add firmware filename overrides

2015-03-05 Thread Ming Lei
On Thu, Mar 5, 2015 at 8:48 AM, Dmitry Torokhov d...@chromium.org wrote: On Wed, Mar 04, 2015 at 03:57:09PM -0800, Greg KH wrote: On Wed, Mar 04, 2015 at 03:25:10PM -0800, Charlie Mooney wrote: This patch adds an additional feature to the firmware_class.c module. To allow a unified method of

Re: [PATCH] firmware_class: Add firmware filename overrides

2015-03-05 Thread Marcel Holtmann
Hi Charles, Specifically this was motivated by a situation where we have one device with a dual-sourced touchscreen. Both use the same driver but have different hardware fw. Our FW updating software therefore, needs to be able to update with the correct FW and detect all this at runtime due

Re: [PATCH] firmware_class: Add firmware filename overrides

2015-03-05 Thread Dmitry Torokhov
On Thu, Mar 5, 2015 at 10:13 AM, Marcel Holtmann mar...@holtmann.org wrote: Hi Charles, Specifically this was motivated by a situation where we have one device with a dual-sourced touchscreen. Both use the same driver but have different hardware fw. Our FW updating software therefore, needs

Re: [PATCH] firmware_class: Add firmware filename overrides

2015-03-05 Thread Dmitry Torokhov
Hi Marcel, On Thu, Mar 5, 2015 at 11:11 AM, Marcel Holtmann mar...@holtmann.org wrote: Hi Dmitry, Specifically this was motivated by a situation where we have one device with a dual-sourced touchscreen. Both use the same driver but have different hardware fw. Our FW updating software

Re: [PATCH] firmware_class: Add firmware filename overrides

2015-03-05 Thread Marcel Holtmann
Hi Dmitry, Specifically this was motivated by a situation where we have one device with a dual-sourced touchscreen. Both use the same driver but have different hardware fw. Our FW updating software therefore, needs to be able to update with the correct FW and detect all this at runtime due

Re: [PATCH] firmware_class: Add firmware filename overrides

2015-03-04 Thread Dmitry Torokhov
On Wed, Mar 04, 2015 at 03:57:09PM -0800, Greg KH wrote: > On Wed, Mar 04, 2015 at 03:25:10PM -0800, Charlie Mooney wrote: > > This patch adds an additional feature to the firmware_class.c module. > > To allow a unified method of specifying new firmware locations when > > drivers request a

Re: [PATCH] firmware_class: Add firmware filename overrides

2015-03-04 Thread Greg KH
On Wed, Mar 04, 2015 at 03:25:10PM -0800, Charlie Mooney wrote: > This patch adds an additional feature to the firmware_class.c module. > To allow a unified method of specifying new firmware locations when > drivers request a firmware binary to update their devices with, we > have added the

[PATCH] firmware_class: Add firmware filename overrides

2015-03-04 Thread Charlie Mooney
This patch adds an additional feature to the firmware_class.c module. To allow a unified method of specifying new firmware locations when drivers request a firmware binary to update their devices with, we have added the concept of a "fw override" A fw override is a rule that matches firmware

Re: [PATCH] firmware_class: Add firmware filename overrides

2015-03-04 Thread Dmitry Torokhov
On Wed, Mar 04, 2015 at 03:57:09PM -0800, Greg KH wrote: On Wed, Mar 04, 2015 at 03:25:10PM -0800, Charlie Mooney wrote: This patch adds an additional feature to the firmware_class.c module. To allow a unified method of specifying new firmware locations when drivers request a firmware

[PATCH] firmware_class: Add firmware filename overrides

2015-03-04 Thread Charlie Mooney
This patch adds an additional feature to the firmware_class.c module. To allow a unified method of specifying new firmware locations when drivers request a firmware binary to update their devices with, we have added the concept of a fw override A fw override is a rule that matches firmware

Re: [PATCH] firmware_class: Add firmware filename overrides

2015-03-04 Thread Greg KH
On Wed, Mar 04, 2015 at 03:25:10PM -0800, Charlie Mooney wrote: This patch adds an additional feature to the firmware_class.c module. To allow a unified method of specifying new firmware locations when drivers request a firmware binary to update their devices with, we have added the concept of