Re: [PATCH] fix dependency generation

2007-04-01 Thread Sam Ravnborg
On Sat, Mar 31, 2007 at 06:11:36PM +0200, Roman Zippel wrote: > Hi, > > On Sat, 31 Mar 2007, Sam Ravnborg wrote: > > > The problem is that tristate symbol represent three values. > > =n => CONFIG_SYMBOL is undefined > > =y => CONFIG_SYMBOL is defined > > =m => COMFIG_SYMBOL_MODULE is defined > >

Re: [PATCH] fix dependency generation

2007-04-01 Thread Sam Ravnborg
On Sat, Mar 31, 2007 at 06:11:36PM +0200, Roman Zippel wrote: Hi, On Sat, 31 Mar 2007, Sam Ravnborg wrote: The problem is that tristate symbol represent three values. =n = CONFIG_SYMBOL is undefined =y = CONFIG_SYMBOL is defined =m = COMFIG_SYMBOL_MODULE is defined The function

Re: [PATCH] fix dependency generation

2007-03-31 Thread Roman Zippel
Hi, On Sat, 31 Mar 2007, Sam Ravnborg wrote: > The problem is that tristate symbol represent three values. > =n => CONFIG_SYMBOL is undefined > =y => CONFIG_SYMBOL is defined > =m => COMFIG_SYMBOL_MODULE is defined > > The function split_config does not take into account the > different values

Re: [PATCH] fix dependency generation

2007-03-31 Thread Roman Zippel
Hi, On Sat, 31 Mar 2007, Sam Ravnborg wrote: The problem is that tristate symbol represent three values. =n = CONFIG_SYMBOL is undefined =y = CONFIG_SYMBOL is defined =m = COMFIG_SYMBOL_MODULE is defined The function split_config does not take into account the different values and

Re: [PATCH] fix dependency generation

2007-03-30 Thread Sam Ravnborg
On Thu, Mar 29, 2007 at 10:27:14AM +0100, Jan Beulich wrote: > Commit 2e3646e51b2d6415549b310655df63e7e0d7a080 changed the way > the split config tree is built, but failed to also adjust fixdep > accordingly - if changing a config option from or to m, files > referencing the respective

Re: [PATCH] fix dependency generation

2007-03-30 Thread Jeff Dike
On Fri, Mar 30, 2007 at 04:43:17PM +0100, Jan Beulich wrote: > >But that will break UM - no?? > >See following note from fixdep: > > * Note 2: if somebody writes HELLO_CONFIG_BOOM in a file, it will depend > > onto > > * CONFIG_BOOM. This could seem a bug (not too hard to fix), but please do > >

Re: [PATCH] fix dependency generation

2007-03-30 Thread Jan Beulich
>>> Sam Ravnborg <[EMAIL PROTECTED]> 30.03.07 17:08 >>> >On Thu, Mar 29, 2007 at 10:27:14AM +0100, Jan Beulich wrote: >> Commit 2e3646e51b2d6415549b310655df63e7e0d7a080 changed the way >> the split config tree is built, but failed to also adjust fixdep >> accordingly - if changing a config option

Re: [PATCH] fix dependency generation

2007-03-30 Thread Randy Dunlap
Jan Beulich wrote: Randy Dunlap <[EMAIL PROTECTED]> 29.03.07 18:38 >>> On Thu, 29 Mar 2007 17:06:24 +0100 Jan Beulich wrote: Randy Dunlap <[EMAIL PROTECTED]> 29.03.07 17:39 >>> --- linux-2.6.21-rc5/scripts/basic/fixdep.c 2007-02-04 19:44:54.0 +0100 +++

Re: [PATCH] fix dependency generation

2007-03-30 Thread Sam Ravnborg
On Thu, Mar 29, 2007 at 10:27:14AM +0100, Jan Beulich wrote: > Commit 2e3646e51b2d6415549b310655df63e7e0d7a080 changed the way > the split config tree is built, but failed to also adjust fixdep > accordingly - if changing a config option from or to m, files > referencing the respective

Re: [PATCH] fix dependency generation

2007-03-30 Thread Jan Beulich
>>> Randy Dunlap <[EMAIL PROTECTED]> 29.03.07 18:38 >>> >On Thu, 29 Mar 2007 17:06:24 +0100 Jan Beulich wrote: > >> >>> Randy Dunlap <[EMAIL PROTECTED]> 29.03.07 17:39 >>> >> >> --- linux-2.6.21-rc5/scripts/basic/fixdep.c 2007-02-04 >> >> 19:44:54.0 +0100 >> >> +++

Re: [PATCH] fix dependency generation

2007-03-30 Thread Jan Beulich
Randy Dunlap [EMAIL PROTECTED] 29.03.07 18:38 On Thu, 29 Mar 2007 17:06:24 +0100 Jan Beulich wrote: Randy Dunlap [EMAIL PROTECTED] 29.03.07 17:39 --- linux-2.6.21-rc5/scripts/basic/fixdep.c 2007-02-04 19:44:54.0 +0100 +++ 2.6.21-rc5-fixdep-mod/scripts/basic/fixdep.c

Re: [PATCH] fix dependency generation

2007-03-30 Thread Sam Ravnborg
On Thu, Mar 29, 2007 at 10:27:14AM +0100, Jan Beulich wrote: Commit 2e3646e51b2d6415549b310655df63e7e0d7a080 changed the way the split config tree is built, but failed to also adjust fixdep accordingly - if changing a config option from or to m, files referencing the respective

Re: [PATCH] fix dependency generation

2007-03-30 Thread Randy Dunlap
Jan Beulich wrote: Randy Dunlap [EMAIL PROTECTED] 29.03.07 18:38 On Thu, 29 Mar 2007 17:06:24 +0100 Jan Beulich wrote: Randy Dunlap [EMAIL PROTECTED] 29.03.07 17:39 --- linux-2.6.21-rc5/scripts/basic/fixdep.c 2007-02-04 19:44:54.0 +0100 +++

Re: [PATCH] fix dependency generation

2007-03-30 Thread Jan Beulich
Sam Ravnborg [EMAIL PROTECTED] 30.03.07 17:08 On Thu, Mar 29, 2007 at 10:27:14AM +0100, Jan Beulich wrote: Commit 2e3646e51b2d6415549b310655df63e7e0d7a080 changed the way the split config tree is built, but failed to also adjust fixdep accordingly - if changing a config option from or to m,

Re: [PATCH] fix dependency generation

2007-03-30 Thread Jeff Dike
On Fri, Mar 30, 2007 at 04:43:17PM +0100, Jan Beulich wrote: But that will break UM - no?? See following note from fixdep: * Note 2: if somebody writes HELLO_CONFIG_BOOM in a file, it will depend onto * CONFIG_BOOM. This could seem a bug (not too hard to fix), but please do not * fix

Re: [PATCH] fix dependency generation

2007-03-30 Thread Sam Ravnborg
On Thu, Mar 29, 2007 at 10:27:14AM +0100, Jan Beulich wrote: Commit 2e3646e51b2d6415549b310655df63e7e0d7a080 changed the way the split config tree is built, but failed to also adjust fixdep accordingly - if changing a config option from or to m, files referencing the respective

Re: [PATCH] fix dependency generation

2007-03-29 Thread Randy Dunlap
On Thu, 29 Mar 2007 17:06:24 +0100 Jan Beulich wrote: > >>> Randy Dunlap <[EMAIL PROTECTED]> 29.03.07 17:39 >>> > >> --- linux-2.6.21-rc5/scripts/basic/fixdep.c2007-02-04 > >> 19:44:54.0 +0100 > >> +++ 2.6.21-rc5-fixdep-mod/scripts/basic/fixdep.c 2007-03-29 > >>

Re: [PATCH] fix dependency generation

2007-03-29 Thread Jan Beulich
>>> Randy Dunlap <[EMAIL PROTECTED]> 29.03.07 17:39 >>> >> --- linux-2.6.21-rc5/scripts/basic/fixdep.c 2007-02-04 19:44:54.0 >> +0100 >> +++ 2.6.21-rc5-fixdep-mod/scripts/basic/fixdep.c 2007-03-29 >> 11:11:10.0 +0200 >> @@ -29,8 +29,7 @@ >> * option which is mentioned in

Re: [PATCH] fix dependency generation

2007-03-29 Thread Randy Dunlap
On Thu, 29 Mar 2007 10:27:14 +0100 Jan Beulich wrote: > Commit 2e3646e51b2d6415549b310655df63e7e0d7a080 changed the way > the split config tree is built, but failed to also adjust fixdep > accordingly - if changing a config option from or to m, files > referencing the respective CONFIG_..._MODULE

[PATCH] fix dependency generation

2007-03-29 Thread Jan Beulich
Commit 2e3646e51b2d6415549b310655df63e7e0d7a080 changed the way the split config tree is built, but failed to also adjust fixdep accordingly - if changing a config option from or to m, files referencing the respective CONFIG_..._MODULE (but not the corresponding CONFIG_...) didn't get rebuilt.

[PATCH] fix dependency generation

2007-03-29 Thread Jan Beulich
Commit 2e3646e51b2d6415549b310655df63e7e0d7a080 changed the way the split config tree is built, but failed to also adjust fixdep accordingly - if changing a config option from or to m, files referencing the respective CONFIG_..._MODULE (but not the corresponding CONFIG_...) didn't get rebuilt.

Re: [PATCH] fix dependency generation

2007-03-29 Thread Randy Dunlap
On Thu, 29 Mar 2007 10:27:14 +0100 Jan Beulich wrote: Commit 2e3646e51b2d6415549b310655df63e7e0d7a080 changed the way the split config tree is built, but failed to also adjust fixdep accordingly - if changing a config option from or to m, files referencing the respective CONFIG_..._MODULE

Re: [PATCH] fix dependency generation

2007-03-29 Thread Jan Beulich
Randy Dunlap [EMAIL PROTECTED] 29.03.07 17:39 --- linux-2.6.21-rc5/scripts/basic/fixdep.c 2007-02-04 19:44:54.0 +0100 +++ 2.6.21-rc5-fixdep-mod/scripts/basic/fixdep.c 2007-03-29 11:11:10.0 +0200 @@ -29,8 +29,7 @@ * option which is mentioned in any of the listed

Re: [PATCH] fix dependency generation

2007-03-29 Thread Randy Dunlap
On Thu, 29 Mar 2007 17:06:24 +0100 Jan Beulich wrote: Randy Dunlap [EMAIL PROTECTED] 29.03.07 17:39 --- linux-2.6.21-rc5/scripts/basic/fixdep.c2007-02-04 19:44:54.0 +0100 +++ 2.6.21-rc5-fixdep-mod/scripts/basic/fixdep.c 2007-03-29 11:11:10.0 +0200 @@ -29,8