Re: [PATCH] fix infoleak in fcntl

2016-05-08 Thread Richard Weinberger
Am 08.05.2016 um 17:40 schrieb Kangjie Lu: > > > On Sun, May 8, 2016 at 8:58 AM, Richard Weinberger > > wrote: > > On Tue, May 3, 2016 at 10:34 PM, Kangjie Lu > wrote: >

Re: [PATCH] fix infoleak in fcntl

2016-05-08 Thread Richard Weinberger
Am 08.05.2016 um 17:40 schrieb Kangjie Lu: > > > On Sun, May 8, 2016 at 8:58 AM, Richard Weinberger > mailto:richard.weinber...@gmail.com>> wrote: > > On Tue, May 3, 2016 at 10:34 PM, Kangjie Lu > wrote: > > The stack object “si” has a total size of 128

Re: [PATCH] fix infoleak in fcntl

2016-05-08 Thread Richard Weinberger
On Tue, May 3, 2016 at 10:34 PM, Kangjie Lu wrote: > The stack object “si” has a total size of 128 bytes; however, only > 16 bytes are initialized. The remaining uninitialized bytes are > sent to userland via send_signal. How did you find all these leaks? Since you sent more

Re: [PATCH] fix infoleak in fcntl

2016-05-08 Thread Richard Weinberger
On Tue, May 3, 2016 at 10:34 PM, Kangjie Lu wrote: > The stack object “si” has a total size of 128 bytes; however, only > 16 bytes are initialized. The remaining uninitialized bytes are > sent to userland via send_signal. How did you find all these leaks? Since you sent more than one patch I

Re: [PATCH] fix infoleak in fcntl

2016-05-08 Thread Christoph Hellwig
On Tue, May 03, 2016 at 04:34:09PM -0400, Kangjie Lu wrote: > The stack object ???si??? has a total size of 128 bytes; however, only > 16 bytes are initialized. The remaining uninitialized bytes are > sent to userland via send_signal. > > Signed-off-by: Kangjie Lu Looks fine,

Re: [PATCH] fix infoleak in fcntl

2016-05-08 Thread Christoph Hellwig
On Tue, May 03, 2016 at 04:34:09PM -0400, Kangjie Lu wrote: > The stack object ???si??? has a total size of 128 bytes; however, only > 16 bytes are initialized. The remaining uninitialized bytes are > sent to userland via send_signal. > > Signed-off-by: Kangjie Lu Looks fine, Reviewed-by:

[PATCH] fix infoleak in fcntl

2016-05-03 Thread Kangjie Lu
The stack object “si” has a total size of 128 bytes; however, only 16 bytes are initialized. The remaining uninitialized bytes are sent to userland via send_signal. Signed-off-by: Kangjie Lu --- fs/fcntl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/fcntl.c

[PATCH] fix infoleak in fcntl

2016-05-03 Thread Kangjie Lu
The stack object “si” has a total size of 128 bytes; however, only 16 bytes are initialized. The remaining uninitialized bytes are sent to userland via send_signal. Signed-off-by: Kangjie Lu --- fs/fcntl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/fcntl.c b/fs/fcntl.c index