Re: [PATCH] fix inverted test in __skb_recv_datagram

2015-12-08 Thread Rainer Weikusat
David Miller writes: [...] > Please, in the future, place proper subsystem prefixes in your > Subject lines. In this case, "net: " would have been appropriate > and it wouldn't be the end of the world if you capitalized > your commit header line too. > > I fixed both of these things while insta

Re: [PATCH] fix inverted test in __skb_recv_datagram

2015-12-08 Thread David Miller
From: Rainer Weikusat Date: Tue, 08 Dec 2015 14:47:56 + > As the kernel generally uses negated error numbers, *err needs to be > compared with -EAGAIN (d'oh). > > Signed-off-by: Rainer Weikusat > Fixes: ea3793ee29d3 ("core: enable more fine-grained datagram reception > control") Applied,

Re: [PATCH] fix inverted test in __skb_recv_datagram

2015-12-08 Thread David Miller
From: Rainer Weikusat Date: Tue, 08 Dec 2015 14:46:36 + > David Miller writes: >> From: Rainer Weikusat >> Date: Mon, 07 Dec 2015 23:30:58 + >> >>> As the kernel generally uses negated error numbers, *err needs to be >>> compared with -EAGAIN (d'oh). >>> >>> Signed-off-by: Rainer Weiku

Re: [PATCH] fix inverted test in __skb_recv_datagram

2015-12-08 Thread Rainer Weikusat
As the kernel generally uses negated error numbers, *err needs to be compared with -EAGAIN (d'oh). Signed-off-by: Rainer Weikusat Fixes: ea3793ee29d3 ("core: enable more fine-grained datagram reception control") --- diff --git a/net/core/datagram.c b/net/core/datagram.c index 7daff66..fa9dc64 10

Re: [PATCH] fix inverted test in __skb_recv_datagram

2015-12-08 Thread Rainer Weikusat
David Miller writes: > From: Rainer Weikusat > Date: Mon, 07 Dec 2015 23:30:58 + > >> As the kernel generally uses negated error numbers, *err needs to be >> compared with -EAGAIN (d'oh). >> >> Signed-off-by: Rainer Weikusat >> Fixes: ea3793ee29d3 > > Improperly formatted Fixes: tag, you mu

Re: [PATCH] fix inverted test in __skb_recv_datagram

2015-12-07 Thread David Miller
From: Rainer Weikusat Date: Mon, 07 Dec 2015 23:30:58 + > As the kernel generally uses negated error numbers, *err needs to be > compared with -EAGAIN (d'oh). > > Signed-off-by: Rainer Weikusat > Fixes: ea3793ee29d3 Improperly formatted Fixes: tag, you must also include the commit header l

[PATCH] fix inverted test in __skb_recv_datagram

2015-12-07 Thread Rainer Weikusat
As the kernel generally uses negated error numbers, *err needs to be compared with -EAGAIN (d'oh). Signed-off-by: Rainer Weikusat Fixes: ea3793ee29d3 --- diff --git a/net/core/datagram.c b/net/core/datagram.c index 7daff66..fa9dc64 100644 --- a/net/core/datagram.c +++ b/net/core/datagram.c @@ -27