Re: [PATCH] fix namespaced fscaps when !CONFIG_SECURITY

2020-12-05 Thread Serge E. Hallyn
Oh, I see you'd changed it inline :) Thanks On Sat, Dec 05, 2020 at 11:40:00AM -0600, Serge E. Hallyn wrote: > How odd - where did that come from? > > James, I force-pushed that with corrected bugzilla link to > 2020-11-29/fix-nscaps. Sorry about that. > > On Fri, Dec 04, 2020 at 07:58:14AM

Re: [PATCH] fix namespaced fscaps when !CONFIG_SECURITY

2020-12-05 Thread Serge E. Hallyn
How odd - where did that come from? James, I force-pushed that with corrected bugzilla link to 2020-11-29/fix-nscaps. Sorry about that. On Fri, Dec 04, 2020 at 07:58:14AM -0800, Andrew G. Morgan wrote: > The correct bug reference for this patch is: > >

Re: [PATCH] fix namespaced fscaps when !CONFIG_SECURITY

2020-12-04 Thread James Morris
On Fri, 4 Dec 2020, Andrew G. Morgan wrote: > The correct bug reference for this patch is: > > https://bugzilla.kernel.org/show_bug.cgi?id=209689 > > Reviewed-by: Andrew G. Morgan Thanks. Applied to git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security.git fixes-5.10 and

Re: [PATCH] fix namespaced fscaps when !CONFIG_SECURITY

2020-12-04 Thread Andrew G. Morgan
The correct bug reference for this patch is: https://bugzilla.kernel.org/show_bug.cgi?id=209689 Reviewed-by: Andrew G. Morgan On Mon, Nov 30, 2020 at 6:58 PM James Morris wrote: > > On Sun, 29 Nov 2020, Serge E. Hallyn wrote: > > > Hi James, > > > > would you mind adding this to the security

Re: [PATCH] fix namespaced fscaps when !CONFIG_SECURITY

2020-11-30 Thread James Morris
On Sun, 29 Nov 2020, Serge E. Hallyn wrote: > Hi James, > > would you mind adding this to the security tree? (You can cherrypick > from > https://git.kernel.org/pub/scm/linux/kernel/git/sergeh/linux.git/commit/?h=2020-11-29/fix-nscaps > ) Sure. > > thanks, > -serge > > On Tue, Nov 17,

Re: [PATCH] fix namespaced fscaps when !CONFIG_SECURITY

2020-11-29 Thread Serge E. Hallyn
Hi James, would you mind adding this to the security tree? (You can cherrypick from https://git.kernel.org/pub/scm/linux/kernel/git/sergeh/linux.git/commit/?h=2020-11-29/fix-nscaps ) thanks, -serge On Tue, Nov 17, 2020 at 08:09:59AM -0800, Andrew G. Morgan wrote: > Signed-off-by: Andrew G.

Re: [PATCH] fix namespaced fscaps when !CONFIG_SECURITY

2020-11-19 Thread Andrew G. Morgan
Reviewed-by: Andrew G. Morgan Works for me too. On Thu, Nov 19, 2020 at 7:20 PM James Morris wrote: > > On Tue, 17 Nov 2020, Andrew G. Morgan wrote: > > > Signed-off-by: Andrew G. Morgan > > This should be Acked-by or Reviewed-by, unless this is your patch, or it > came via your tree. > > >

Re: [PATCH] fix namespaced fscaps when !CONFIG_SECURITY

2020-11-19 Thread James Morris
On Tue, 17 Nov 2020, Andrew G. Morgan wrote: > Signed-off-by: Andrew G. Morgan This should be Acked-by or Reviewed-by, unless this is your patch, or it came via your tree. -- James Morris

Re: [PATCH] fix namespaced fscaps when !CONFIG_SECURITY

2020-11-19 Thread James Morris
On Tue, 17 Nov 2020, Serge E. Hallyn wrote: > *1 - note, if libcap is too old for getcap to have the '-n' > option, then use verify-caps instead. > > Signed-off-by: Serge Hallyn > Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1593431 "Perf fails to compile with python 3.7" Wrong bug

Re: [PATCH] fix namespaced fscaps when !CONFIG_SECURITY

2020-11-19 Thread James Morris
[Adding LSM list] On Tue, 17 Nov 2020, Serge E. Hallyn wrote: > Namespaced file capabilities were introduced in 8db6c34f1dbc . > When userspace reads an xattr for a namespaced capability, a > virtualized representation of it is returned if the caller is > in a user namespace owned by the

Re: [PATCH] fix namespaced fscaps when !CONFIG_SECURITY

2020-11-17 Thread Casey Schaufler
On 11/17/2020 7:08 AM, Serge E. Hallyn wrote: > Namespaced file capabilities were introduced in 8db6c34f1dbc . > When userspace reads an xattr for a namespaced capability, a > virtualized representation of it is returned if the caller is > in a user namespace owned by the capability's owning

Re: [PATCH] fix namespaced fscaps when !CONFIG_SECURITY

2020-11-17 Thread Andrew G. Morgan
Signed-off-by: Andrew G. Morgan On Tue, Nov 17, 2020 at 7:09 AM Serge E. Hallyn wrote: > > Namespaced file capabilities were introduced in 8db6c34f1dbc . > When userspace reads an xattr for a namespaced capability, a > virtualized representation of it is returned if the caller is > in a user

[PATCH] fix namespaced fscaps when !CONFIG_SECURITY

2020-11-17 Thread Serge E. Hallyn
Namespaced file capabilities were introduced in 8db6c34f1dbc . When userspace reads an xattr for a namespaced capability, a virtualized representation of it is returned if the caller is in a user namespace owned by the capability's owning rootid. The function which performs this virtualization was