Re: Re: Re: [PATCH] fix race condition between device_del and device_add

2015-03-30 Thread gre...@linuxfoundation.org
On Mon, Mar 30, 2015 at 02:02:27PM +, EunTaik Lee wrote: > > The problem was on 3.10.49. > > I carefully looked up the patches again and found out that there was > a patch on 3.18 that will solve the problem > > commite4a60d139060975eb956717e4f63ae348d4d8cc5 > sysfs: driver core:

Re: Re: Re: [PATCH] fix race condition between device_del and device_add

2015-03-30 Thread EunTaik Lee
The problem was on 3.10.49. I carefully looked up the patches again and found out that there was a patch on 3.18 that will solve the problem commit e4a60d139060975eb956717e4f63ae348d4d8cc5 sysfs: driver core: Fix glue dir race condition by gdp_mutex Sorry for bothering you. Thanks, Eun Taik

Re: Re: [PATCH] fix race condition between device_del and device_add

2015-03-30 Thread gre...@linuxfoundation.org
On Mon, Mar 30, 2015 at 11:54:54AM +, EunTaik Lee wrote: > > > > >The bus that the device is on should prevent this, why isn't that > >working for you? What type of device/bus do you see this problem on? > > The device is a firmware class device on a virtual bus. What kernel code is

Re: Re: [PATCH] fix race condition between device_del and device_add

2015-03-30 Thread EunTaik Lee
> >The bus that the device is on should prevent this, why isn't that >working for you? What type of device/bus do you see this problem on? The device is a firmware class device on a virtual bus. >> Signed-off-by: eun.taik.lee > >We need a "real" name here, I don't think your name has '.' in

Re: [PATCH] fix race condition between device_del and device_add

2015-03-30 Thread gre...@linuxfoundation.org
On Mon, Mar 30, 2015 at 09:06:43AM +, EunTaik Lee wrote: > There is a possible race condition when a device > is added while another device with the same parent > , with ref count of one, is deleted. > > CPU0CPU1 > device_add() device_del() > get_device_parent()

Fwd: [PATCH] fix race condition between device_del and device_add

2015-03-30 Thread EunTaik Lee
There is a possible race condition when a device is added while another device with the same parent , with ref count of one, is deleted. CPU0CPU1 device_add() device_del() get_device_parent() put_device(parent); kobj = kobject_get(k); kobject_put() kref_put()

Re: [PATCH] fix race condition between device_del and device_add

2015-03-30 Thread gre...@linuxfoundation.org
On Mon, Mar 30, 2015 at 09:06:43AM +, EunTaik Lee wrote: There is a possible race condition when a device is added while another device with the same parent , with ref count of one, is deleted. CPU0CPU1 device_add() device_del() get_device_parent() put_device(parent);

Fwd: [PATCH] fix race condition between device_del and device_add

2015-03-30 Thread EunTaik Lee
There is a possible race condition when a device is added while another device with the same parent , with ref count of one, is deleted. CPU0CPU1 device_add() device_del() get_device_parent() put_device(parent); kobj = kobject_get(k); kobject_put() kref_put()

Re: Re: [PATCH] fix race condition between device_del and device_add

2015-03-30 Thread gre...@linuxfoundation.org
On Mon, Mar 30, 2015 at 11:54:54AM +, EunTaik Lee wrote: The bus that the device is on should prevent this, why isn't that working for you? What type of device/bus do you see this problem on? The device is a firmware class device on a virtual bus. What kernel code is causing this?

Re: Re: Re: [PATCH] fix race condition between device_del and device_add

2015-03-30 Thread gre...@linuxfoundation.org
On Mon, Mar 30, 2015 at 02:02:27PM +, EunTaik Lee wrote: The problem was on 3.10.49. I carefully looked up the patches again and found out that there was a patch on 3.18 that will solve the problem commite4a60d139060975eb956717e4f63ae348d4d8cc5 sysfs: driver core: Fix glue

Re: Re: Re: [PATCH] fix race condition between device_del and device_add

2015-03-30 Thread EunTaik Lee
The problem was on 3.10.49. I carefully looked up the patches again and found out that there was a patch on 3.18 that will solve the problem commit e4a60d139060975eb956717e4f63ae348d4d8cc5 sysfs: driver core: Fix glue dir race condition by gdp_mutex Sorry for bothering you. Thanks, Eun Taik

Re: Re: [PATCH] fix race condition between device_del and device_add

2015-03-30 Thread EunTaik Lee
The bus that the device is on should prevent this, why isn't that working for you? What type of device/bus do you see this problem on? The device is a firmware class device on a virtual bus. Signed-off-by: eun.taik.lee We need a real name here, I don't think your name has '.' in it, right?