Re: [PATCH] floppy: reintroduce O_NDELAY fix

2021-02-04 Thread Denis Efremov
On 2/4/21 12:24 PM, Jiri Kosina wrote: > On Tue, 26 Jan 2021, Denis Efremov wrote: > >> Applied. I'll send it to Jens soon with a couple of cleanup patches. >> >> https://github.com/evdenis/linux-floppy/commit/e32f6163c47efbdbad06258560aa00d1c7e5b699 > > Denis, > > I don't see this fix in Jen

Re: [PATCH] floppy: reintroduce O_NDELAY fix

2021-02-04 Thread Jiri Kosina
On Tue, 26 Jan 2021, Denis Efremov wrote: > Applied. I'll send it to Jens soon with a couple of cleanup patches. > > https://github.com/evdenis/linux-floppy/commit/e32f6163c47efbdbad06258560aa00d1c7e5b699 Denis, I don't see this fix in Jens' tree yet. Is there any problem with the patch? Than

Re: [PATCH] floppy: reintroduce O_NDELAY fix

2021-01-26 Thread Denis Efremov
On 1/22/21 2:13 PM, Jiri Kosina wrote: > From: Jiri Kosina > > This issue was originally fixed in 09954bad4 ("floppy: refactor open() > flags handling"). > > The fix as a side-effect, however, introduce issue for open(O_ACCMODE) > that is being used for ioctl-only open. I wrote a fix for th

Re: [PATCH] floppy: reintroduce O_NDELAY fix

2021-01-26 Thread Kurt Garloff
Hi Denis, Jiri, Jens, Am 26.01.21 um 09:21 schrieb Denis Efremov: > On 1/22/21 2:13 PM, Jiri Kosina wrote: >> From: Jiri Kosina >> >> This issue was originally fixed in 09954bad4 ("floppy: refactor open() >> flags handling"). >> >> The fix as a side-effect, however, introduce issue for open(O_AC

Re: [PATCH] floppy: reintroduce O_NDELAY fix

2021-01-26 Thread Denis Efremov
On 1/26/21 12:31 PM, Kurt Garloff wrote: > Hi Denis, Jiri, Jens, > > Am 26.01.21 um 09:21 schrieb Denis Efremov: >> On 1/22/21 2:13 PM, Jiri Kosina wrote: >>> From: Jiri Kosina >>> >>> This issue was originally fixed in 09954bad4 ("floppy: refactor open() >>> flags handling"). >>> >>> The fix

[PATCH] floppy: reintroduce O_NDELAY fix

2021-01-22 Thread Jiri Kosina
From: Jiri Kosina This issue was originally fixed in 09954bad4 ("floppy: refactor open() flags handling"). The fix as a side-effect, however, introduce issue for open(O_ACCMODE) that is being used for ioctl-only open. I wrote a fix for that, but instead of it being merged, full revert of 0995

Re: [PATCH] floppy: reintroduce O_NDELAY fix

2021-01-21 Thread kernel test robot
Hi Jiri, I love your patch! Yet something to improve: [auto build test ERROR on block/for-next] [also build test ERROR on linux/master linus/master v5.11-rc4 next-20210121] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base