Re: [PATCH] fork: report pid reservation failure properly

2015-02-27 Thread Michal Hocko
On Thu 26-02-15 14:49:08, Andrew Morton wrote: > On Mon, 23 Feb 2015 21:17:01 +0100 Michal Hocko wrote: > > > ping on this one? Should I just resend (your way Andrew)? Or are there > > any objections to the patch as is. > > Were Eric's concerns all addressed? I hope so. I didn't touch pid

Re: [PATCH] fork: report pid reservation failure properly

2015-02-27 Thread Michal Hocko
On Thu 26-02-15 14:49:08, Andrew Morton wrote: On Mon, 23 Feb 2015 21:17:01 +0100 Michal Hocko mho...@suse.cz wrote: ping on this one? Should I just resend (your way Andrew)? Or are there any objections to the patch as is. Were Eric's concerns all addressed? I hope so. I didn't touch

Re: [PATCH] fork: report pid reservation failure properly

2015-02-26 Thread Andrew Morton
On Mon, 23 Feb 2015 21:17:01 +0100 Michal Hocko wrote: > ping on this one? Should I just resend (your way Andrew)? Or are there > any objections to the patch as is. Were Eric's concerns all addressed? Oleg: wake up ;) Overall it looks like a pretty minor issue? -- To unsubscribe from this

Re: [PATCH] fork: report pid reservation failure properly

2015-02-26 Thread Andrew Morton
On Mon, 23 Feb 2015 21:17:01 +0100 Michal Hocko mho...@suse.cz wrote: ping on this one? Should I just resend (your way Andrew)? Or are there any objections to the patch as is. Were Eric's concerns all addressed? Oleg: wake up ;) Overall it looks like a pretty minor issue? -- To unsubscribe

Re: [PATCH] fork: report pid reservation failure properly

2015-02-23 Thread Michal Hocko
ping on this one? Should I just resend (your way Andrew)? Or are there any objections to the patch as is. On Wed 04-02-15 11:43:48, Michal Hocko wrote: > copy_process will report any failure in alloc_pid as ENOMEM currently > which is misleading because the pid allocation might fail not only when

Re: [PATCH] fork: report pid reservation failure properly

2015-02-23 Thread Michal Hocko
ping on this one? Should I just resend (your way Andrew)? Or are there any objections to the patch as is. On Wed 04-02-15 11:43:48, Michal Hocko wrote: copy_process will report any failure in alloc_pid as ENOMEM currently which is misleading because the pid allocation might fail not only when

[PATCH] fork: report pid reservation failure properly

2015-02-04 Thread Michal Hocko
copy_process will report any failure in alloc_pid as ENOMEM currently which is misleading because the pid allocation might fail not only when the memory is short but also when the pid space is consumed already. The current man page even mentions this case: " EAGAIN A system-imposed limit

Re: [RFC PATCH] fork: report pid reservation failure properly

2015-02-04 Thread Michal Hocko
On Tue 03-02-15 14:44:31, Eric W. Biederman wrote: > Michal Hocko writes: > > > On Tue 03-02-15 16:33:03, Michael Kerrisk wrote: > >> Hi Michal, > >> > >> > >> On 3 February 2015 at 16:05, Michal Hocko wrote: > >> > Hi, > >> > while debugging an unexpected ENOMEM from fork (there was no

Re: [RFC PATCH] fork: report pid reservation failure properly

2015-02-04 Thread Michal Hocko
On Tue 03-02-15 14:44:31, Eric W. Biederman wrote: Michal Hocko mho...@suse.cz writes: On Tue 03-02-15 16:33:03, Michael Kerrisk wrote: Hi Michal, On 3 February 2015 at 16:05, Michal Hocko mho...@suse.cz wrote: Hi, while debugging an unexpected ENOMEM from fork (there was no

[PATCH] fork: report pid reservation failure properly

2015-02-04 Thread Michal Hocko
copy_process will report any failure in alloc_pid as ENOMEM currently which is misleading because the pid allocation might fail not only when the memory is short but also when the pid space is consumed already. The current man page even mentions this case: EAGAIN A system-imposed limit on

Re: [RFC PATCH] fork: report pid reservation failure properly

2015-02-03 Thread Eric W. Biederman
Michal Hocko writes: > On Tue 03-02-15 16:33:03, Michael Kerrisk wrote: >> Hi Michal, >> >> >> On 3 February 2015 at 16:05, Michal Hocko wrote: >> > Hi, >> > while debugging an unexpected ENOMEM from fork (there was no memory >> > pressure and OVERCOMMIT_ALWAYS) I have found out that fork

Re: [RFC PATCH] fork: report pid reservation failure properly

2015-02-03 Thread Michal Hocko
ns or something similar. > > > > Any feedback would be appreciated. > > --- > > From 2a576175345fffa04da19cd51a25b7d94187b5f9 Mon Sep 17 00:00:00 2001 > > From: Michal Hocko > > Date: Fri, 30 Jan 2015 14:50:15 +0100 > > Subject: [PATCH] fork: report

Re: [RFC PATCH] fork: report pid reservation failure properly

2015-02-03 Thread Michael Kerrisk (man-pages)
or something similar. > > Any feedback would be appreciated. > --- > From 2a576175345fffa04da19cd51a25b7d94187b5f9 Mon Sep 17 00:00:00 2001 > From: Michal Hocko > Date: Fri, 30 Jan 2015 14:50:15 +0100 > Subject: [PATCH] fork: report pid reservation failure properly > > copy_pr

[RFC PATCH] fork: report pid reservation failure properly

2015-02-03 Thread Michal Hocko
2015 14:50:15 +0100 Subject: [PATCH] fork: report pid reservation failure properly copy_process will report any failure in alloc_pid as ENOMEM currently which is misleading because the pid allocation might fail not only when the memory is short but also when the pid space is consumed already. Th

Re: [RFC PATCH] fork: report pid reservation failure properly

2015-02-03 Thread Michael Kerrisk (man-pages)
2a576175345fffa04da19cd51a25b7d94187b5f9 Mon Sep 17 00:00:00 2001 From: Michal Hocko mho...@suse.cz Date: Fri, 30 Jan 2015 14:50:15 +0100 Subject: [PATCH] fork: report pid reservation failure properly copy_process will report any failure in alloc_pid as ENOMEM currently which is misleading because the pid

[RFC PATCH] fork: report pid reservation failure properly

2015-02-03 Thread Michal Hocko
14:50:15 +0100 Subject: [PATCH] fork: report pid reservation failure properly copy_process will report any failure in alloc_pid as ENOMEM currently which is misleading because the pid allocation might fail not only when the memory is short but also when the pid space is consumed already

Re: [RFC PATCH] fork: report pid reservation failure properly

2015-02-03 Thread Michal Hocko
pid reservation failure properly copy_process will report any failure in alloc_pid as ENOMEM currently which is misleading because the pid allocation might fail not only when the memory is short but also when the pid space is consumed already. The current man page even mentions

Re: [RFC PATCH] fork: report pid reservation failure properly

2015-02-03 Thread Eric W. Biederman
Michal Hocko mho...@suse.cz writes: On Tue 03-02-15 16:33:03, Michael Kerrisk wrote: Hi Michal, On 3 February 2015 at 16:05, Michal Hocko mho...@suse.cz wrote: Hi, while debugging an unexpected ENOMEM from fork (there was no memory pressure and OVERCOMMIT_ALWAYS) I have found out