[PATCH] fpga: stratix10-soc: fix wrong of_node_put() in init function

2019-01-26 Thread Alan Tull
From: Nicolas Saenz Julienne After finding a "firmware" dt node stratix10 tries to match it's compatible string with it. To do so it's calling of_find_matching_node() which already takes care of decreasing the refcount on the "firmware" node. We are then incorrectly decreasing the refcount on

Re: [PATCH] fpga: stratix10-soc: fix wrong of_node_put() in init function

2018-12-03 Thread Moritz Fischer
Hi Nicolas, good catch. On Mon, Dec 3, 2018 at 8:13 AM Alan Tull wrote: > > On Mon, Dec 3, 2018 at 6:22 AM Nicolas Saenz Julienne > wrote: > > Hi Nicolas, > > Thanks for catching this! I'll fix up one formatting thing (below). > > > > > After finding a "firmware" dt node stratix10 tries to

Re: [PATCH] fpga: stratix10-soc: fix wrong of_node_put() in init function

2018-12-03 Thread Moritz Fischer
Hi Nicolas, good catch. On Mon, Dec 3, 2018 at 8:13 AM Alan Tull wrote: > > On Mon, Dec 3, 2018 at 6:22 AM Nicolas Saenz Julienne > wrote: > > Hi Nicolas, > > Thanks for catching this! I'll fix up one formatting thing (below). > > > > > After finding a "firmware" dt node stratix10 tries to

Re: [PATCH] fpga: stratix10-soc: fix wrong of_node_put() in init function

2018-12-03 Thread Alan Tull
On Mon, Dec 3, 2018 at 6:22 AM Nicolas Saenz Julienne wrote: Hi Nicolas, Thanks for catching this! I'll fix up one formatting thing (below). > > After finding a "firmware" dt node stratix10 tries to match it's > compatible string with it. To do so it's calling of_find_matching_node() > which

Re: [PATCH] fpga: stratix10-soc: fix wrong of_node_put() in init function

2018-12-03 Thread Alan Tull
On Mon, Dec 3, 2018 at 6:22 AM Nicolas Saenz Julienne wrote: Hi Nicolas, Thanks for catching this! I'll fix up one formatting thing (below). > > After finding a "firmware" dt node stratix10 tries to match it's > compatible string with it. To do so it's calling of_find_matching_node() > which

[PATCH] fpga: stratix10-soc: fix wrong of_node_put() in init function

2018-12-03 Thread Nicolas Saenz Julienne
After finding a "firmware" dt node stratix10 tries to match it's compatible string with it. To do so it's calling of_find_matching_node() which already takes care of decreasing the refcount on the "firmware" node. We are then incorrectly decreasing the refcount on that node again. This patch

[PATCH] fpga: stratix10-soc: fix wrong of_node_put() in init function

2018-12-03 Thread Nicolas Saenz Julienne
After finding a "firmware" dt node stratix10 tries to match it's compatible string with it. To do so it's calling of_find_matching_node() which already takes care of decreasing the refcount on the "firmware" node. We are then incorrectly decreasing the refcount on that node again. This patch