Re: [PATCH] fs/9p/xattr.c: catch the error of p9_client_clunk when setting xattr failed

2018-07-24 Thread Dominique Martinet
piaojun wrote on Wed, Jul 25, 2018: > On 2018/7/25 11:32, Dominique Martinet wrote: > >>p9_client_write(fid, 0, &from, &retval); > > > > I'm not sure what to do about this but it's also possible for > > p9_client_write to not write the full length without setting and error. > > > > We

Re: [PATCH] fs/9p/xattr.c: catch the error of p9_client_clunk when setting xattr failed

2018-07-24 Thread piaojun
Hi Dominique, On 2018/7/25 11:32, Dominique Martinet wrote: > piaojun wrote on Wed, Jul 25, 2018: >> In my testing, v9fs_fid_xattr_set will return successfully even if the >> backend ext4 filesystem has no space to store xattr key-value. That will >> cause inconsistent behavior between front end a

Re: [PATCH] fs/9p/xattr.c: catch the error of p9_client_clunk when setting xattr failed

2018-07-24 Thread Dominique Martinet
piaojun wrote on Wed, Jul 25, 2018: > In my testing, v9fs_fid_xattr_set will return successfully even if the > backend ext4 filesystem has no space to store xattr key-value. That will > cause inconsistent behavior between front end and back end. The reason is > that lsetxattr will be triggered by p

[PATCH] fs/9p/xattr.c: catch the error of p9_client_clunk when setting xattr failed

2018-07-24 Thread piaojun
In my testing, v9fs_fid_xattr_set will return successfully even if the backend ext4 filesystem has no space to store xattr key-value. That will cause inconsistent behavior between front end and back end. The reason is that lsetxattr will be triggered by p9_client_clunk, and unfortunately we did not