[Added Borislav and Sam to cc.]
Christoph Hellwig schreef op wo 16-07-2014 om 10:58 [-0700]:
> On Wed, Jul 16, 2014 at 08:08:41PM +0300, Boaz Harrosh wrote:
> > This is the wrong fix. GCC is wrong here. As shown by Paul Bolle if
> > you move the from / to set from dio_get_page() to here the
On Wed, Jul 16, 2014 at 08:08:41PM +0300, Boaz Harrosh wrote:
> This is the wrong fix. GCC is wrong here. As shown by Paul Bolle if
> you move the from / to set from dio_get_page() to here the warning goes away.
>
> The minimal fix must use uninitialized_var() in this case. See patch below
>
>
On Wed, Jul 16, 2014 at 08:08:41PM +0300, Boaz Harrosh wrote:
> On 07/13/2014 02:50 PM, Christoph Hellwig wrote:
> > pramod.gurav@gmail.com wrote ...
> >> diff --git a/fs/direct-io.c b/fs/direct-io.c
> >> index 98040ba388ac..c0a9854d2bc7 100644
> >> --- a/fs/direct-io.c
> >> +++
On 07/13/2014 02:50 PM, Christoph Hellwig wrote:
> pramod.gurav@gmail.com wrote ...
>> diff --git a/fs/direct-io.c b/fs/direct-io.c
>> index 98040ba388ac..c0a9854d2bc7 100644
>> --- a/fs/direct-io.c
>> +++ b/fs/direct-io.c
>> @@ -910,7 +910,8 @@ static int do_direct_IO(struct dio *dio, struct
On 07/13/2014 02:50 PM, Christoph Hellwig wrote:
pramod.gurav@gmail.com wrote ...
diff --git a/fs/direct-io.c b/fs/direct-io.c
index 98040ba388ac..c0a9854d2bc7 100644
--- a/fs/direct-io.c
+++ b/fs/direct-io.c
@@ -910,7 +910,8 @@ static int do_direct_IO(struct dio *dio, struct
On Wed, Jul 16, 2014 at 08:08:41PM +0300, Boaz Harrosh wrote:
On 07/13/2014 02:50 PM, Christoph Hellwig wrote:
pramod.gurav@gmail.com wrote ...
diff --git a/fs/direct-io.c b/fs/direct-io.c
index 98040ba388ac..c0a9854d2bc7 100644
--- a/fs/direct-io.c
+++ b/fs/direct-io.c
@@ -910,7
On Wed, Jul 16, 2014 at 08:08:41PM +0300, Boaz Harrosh wrote:
This is the wrong fix. GCC is wrong here. As shown by Paul Bolle if
you move the from / to set from dio_get_page() to here the warning goes away.
The minimal fix must use uninitialized_var() in this case. See patch below
But I
[Added Borislav and Sam to cc.]
Christoph Hellwig schreef op wo 16-07-2014 om 10:58 [-0700]:
On Wed, Jul 16, 2014 at 08:08:41PM +0300, Boaz Harrosh wrote:
This is the wrong fix. GCC is wrong here. As shown by Paul Bolle if
you move the from / to set from dio_get_page() to here the warning
Thanks Christoph for the review. :)
On Sun, Jul 13, 2014 at 5:20 PM, Christoph Hellwig wrote:
> Looks good to me,
>
> Reviewed-by: Christoph Hellwig
>
> Al, can you pick this up? It's the only warnings in many of my usual
> kernel builds at the moment.
>
--
Thanks and Regards
Pramod
--
To
Thanks Christoph for the review. :)
On Sun, Jul 13, 2014 at 5:20 PM, Christoph Hellwig h...@infradead.org wrote:
Looks good to me,
Reviewed-by: Christoph Hellwig h...@lst.de
Al, can you pick this up? It's the only warnings in many of my usual
kernel builds at the moment.
--
Thanks and
Looks good to me,
Reviewed-by: Christoph Hellwig
Al, can you pick this up? It's the only warnings in many of my usual
kernel builds at the moment.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo
Looks good to me,
Reviewed-by: Christoph Hellwig h...@lst.de
Al, can you pick this up? It's the only warnings in many of my usual
kernel builds at the moment.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More
From: Pramod Gurav
Fixes below warning while compiling the kernel.
fs/direct-io.c: In function ‘__blockdev_direct_IO’:
fs/direct-io.c:1011:12: warning: ‘to’ may be used uninitialized in this
function [-Wmaybe-uninitialized]
fs/direct-io.c:913:16: note: ‘to’ was declared here
From: Pramod Gurav pramod.gurav@gmail.com
Fixes below warning while compiling the kernel.
fs/direct-io.c: In function ‘__blockdev_direct_IO’:
fs/direct-io.c:1011:12: warning: ‘to’ may be used uninitialized in this
function [-Wmaybe-uninitialized]
fs/direct-io.c:913:16: note: ‘to’ was
14 matches
Mail list logo
