Re: [PATCH] fs: Eliminate a local variable to make the code more clear

2020-09-09 Thread Hao Lee
On Wed, Sep 09, 2020 at 07:54:44AM -0500, Eric W. Biederman wrote: > Hao Lee writes: > > > On Tue, Sep 08, 2020 at 07:48:57PM +0100, Al Viro wrote: > >> On Tue, Sep 08, 2020 at 01:06:56PM +, Hao Lee wrote: > >> > ping > >> > > >> > On Wed, Jul 29, 2020 at 03:21:28PM +, Hao Lee wrote: > >

Re: [PATCH] fs: Eliminate a local variable to make the code more clear

2020-09-09 Thread Eric W. Biederman
Hao Lee writes: > On Tue, Sep 08, 2020 at 07:48:57PM +0100, Al Viro wrote: >> On Tue, Sep 08, 2020 at 01:06:56PM +, Hao Lee wrote: >> > ping >> > >> > On Wed, Jul 29, 2020 at 03:21:28PM +, Hao Lee wrote: >> > > The dentry local variable is introduced in 'commit 84d17192d2afd ("get >> > >

Re: [PATCH] fs: Eliminate a local variable to make the code more clear

2020-09-08 Thread Hao Lee
On Tue, Sep 08, 2020 at 07:48:57PM +0100, Al Viro wrote: > On Tue, Sep 08, 2020 at 01:06:56PM +, Hao Lee wrote: > > ping > > > > On Wed, Jul 29, 2020 at 03:21:28PM +, Hao Lee wrote: > > > The dentry local variable is introduced in 'commit 84d17192d2afd ("get > > > rid of full-hash scan on

Re: [PATCH] fs: Eliminate a local variable to make the code more clear

2020-09-08 Thread Hao Lee
ping On Wed, Jul 29, 2020 at 03:21:28PM +, Hao Lee wrote: > The dentry local variable is introduced in 'commit 84d17192d2afd ("get > rid of full-hash scan on detaching vfsmounts")' to reduce the length of > some long statements for example > mutex_lock(&path->dentry->d_inode->i_mutex). We have

Re: [PATCH] fs: Eliminate a local variable to make the code more clear

2020-09-08 Thread Al Viro
On Tue, Sep 08, 2020 at 01:06:56PM +, Hao Lee wrote: > ping > > On Wed, Jul 29, 2020 at 03:21:28PM +, Hao Lee wrote: > > The dentry local variable is introduced in 'commit 84d17192d2afd ("get > > rid of full-hash scan on detaching vfsmounts")' to reduce the length of > > some long statemen

Re: [PATCH] fs: Eliminate a local variable to make the code more clear

2020-08-13 Thread Hao Lee
Ping On Wed, Jul 29, 2020 at 11:21 PM Hao Lee wrote: > > The dentry local variable is introduced in 'commit 84d17192d2afd ("get > rid of full-hash scan on detaching vfsmounts")' to reduce the length of > some long statements for example > mutex_lock(&path->dentry->d_inode->i_mutex). We have alrea

[PATCH] fs: Eliminate a local variable to make the code more clear

2020-07-29 Thread Hao Lee
The dentry local variable is introduced in 'commit 84d17192d2afd ("get rid of full-hash scan on detaching vfsmounts")' to reduce the length of some long statements for example mutex_lock(&path->dentry->d_inode->i_mutex). We have already used inode_lock(dentry->d_inode) to do the same thing now, and