Re: [PATCH] fs: btrfs: free-space-cache.c: remove two unnecessary checks before calling kfree()

2015-02-11 Thread Bas Peters
Markus, 2015-02-11 13:18 GMT+01:00 SF Markus Elfring : >>> https://lkml.org/lkml/2014/10/31/606 >>> http://article.gmane.org/gmane.linux.kernel/1818924 >>> https://systeme.lip6.fr/pipermail/cocci/2014-October/001321.html >> >> Oh, I see you already made the exact same change. > > Would you like

Re: [PATCH] fs: btrfs: free-space-cache.c: remove two unnecessary checks before calling kfree()

2015-02-11 Thread SF Markus Elfring
>> https://lkml.org/lkml/2014/10/31/606 >> http://article.gmane.org/gmane.linux.kernel/1818924 >> https://systeme.lip6.fr/pipermail/cocci/2014-October/001321.html > > Oh, I see you already made the exact same change. Would you like to add any tags to my update suggestion? Regards, Markus -- To

Re: [PATCH] fs: btrfs: free-space-cache.c: remove two unnecessary checks before calling kfree()

2015-02-11 Thread Bas Peters
2015-02-11 12:30 GMT+01:00 SF Markus Elfring : >> kfree checks whether the pointer it is passed is NULL. The two foregoing >> checks are therefore unnecessary. >> >> This issue was detected using Coccinelle. > > Would you like to integrate my update suggestion "btrfs: Deletion of > unnecessary

Re: [PATCH] fs: btrfs: free-space-cache.c: remove two unnecessary checks before calling kfree()

2015-02-11 Thread SF Markus Elfring
> kfree checks whether the pointer it is passed is NULL. The two foregoing > checks are therefore unnecessary. > > This issue was detected using Coccinelle. Would you like to integrate my update suggestion "btrfs: Deletion of unnecessary checks before six function calls"?

Re: [PATCH] fs: btrfs: free-space-cache.c: remove two unnecessary checks before calling kfree()

2015-02-11 Thread Julia Lawall
On Wed, 11 Feb 2015, Bas Peters wrote: > kfree checks whether the pointer it is passed is NULL. The two foregoing > checks are therefore unnecessary. > > This issue was detected using Coccinelle. > > Signed-off-by: Bas Peters > --- > fs/btrfs/free-space-cache.c | 6 ++ > 1 file changed, 2

[PATCH] fs: btrfs: free-space-cache.c: remove two unnecessary checks before calling kfree()

2015-02-11 Thread Bas Peters
kfree checks whether the pointer it is passed is NULL. The two foregoing checks are therefore unnecessary. This issue was detected using Coccinelle. Signed-off-by: Bas Peters --- fs/btrfs/free-space-cache.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git

Re: [PATCH] fs: btrfs: free-space-cache.c: remove two unnecessary checks before calling kfree()

2015-02-11 Thread Julia Lawall
On Wed, 11 Feb 2015, Bas Peters wrote: kfree checks whether the pointer it is passed is NULL. The two foregoing checks are therefore unnecessary. This issue was detected using Coccinelle. Signed-off-by: Bas Peters baspeter...@gmail.com --- fs/btrfs/free-space-cache.c | 6 ++ 1

[PATCH] fs: btrfs: free-space-cache.c: remove two unnecessary checks before calling kfree()

2015-02-11 Thread Bas Peters
kfree checks whether the pointer it is passed is NULL. The two foregoing checks are therefore unnecessary. This issue was detected using Coccinelle. Signed-off-by: Bas Peters baspeter...@gmail.com --- fs/btrfs/free-space-cache.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff

Re: [PATCH] fs: btrfs: free-space-cache.c: remove two unnecessary checks before calling kfree()

2015-02-11 Thread Bas Peters
2015-02-11 12:30 GMT+01:00 SF Markus Elfring elfr...@users.sourceforge.net: kfree checks whether the pointer it is passed is NULL. The two foregoing checks are therefore unnecessary. This issue was detected using Coccinelle. Would you like to integrate my update suggestion btrfs: Deletion of

Re: [PATCH] fs: btrfs: free-space-cache.c: remove two unnecessary checks before calling kfree()

2015-02-11 Thread SF Markus Elfring
kfree checks whether the pointer it is passed is NULL. The two foregoing checks are therefore unnecessary. This issue was detected using Coccinelle. Would you like to integrate my update suggestion btrfs: Deletion of unnecessary checks before six function calls?

Re: [PATCH] fs: btrfs: free-space-cache.c: remove two unnecessary checks before calling kfree()

2015-02-11 Thread Bas Peters
Markus, 2015-02-11 13:18 GMT+01:00 SF Markus Elfring elfr...@users.sourceforge.net: https://lkml.org/lkml/2014/10/31/606 http://article.gmane.org/gmane.linux.kernel/1818924 https://systeme.lip6.fr/pipermail/cocci/2014-October/001321.html Oh, I see you already made the exact same change.

Re: [PATCH] fs: btrfs: free-space-cache.c: remove two unnecessary checks before calling kfree()

2015-02-11 Thread SF Markus Elfring
https://lkml.org/lkml/2014/10/31/606 http://article.gmane.org/gmane.linux.kernel/1818924 https://systeme.lip6.fr/pipermail/cocci/2014-October/001321.html Oh, I see you already made the exact same change. Would you like to add any tags to my update suggestion? Regards, Markus -- To